* [dpdk-dev] [PATCH] app/test: fix compilation error when debug mode enabled
@ 2016-09-26 13:52 Arek Kusztal
2016-09-26 14:11 ` Jain, Deepak K
2016-09-26 19:14 ` De Lara Guarch, Pablo
0 siblings, 2 replies; 4+ messages in thread
From: Arek Kusztal @ 2016-09-26 13:52 UTC (permalink / raw)
To: dev
Cc: fiona.trahe, deepak.k.jain, pablo.de.lara.guarch, john.griffin,
Arek Kusztal
This patch fixes compilation error in test_cryptodev.c when
RTE_LOG_DEBUG is specified
Fixes: ba0dda7a7100 ("app/test: add GMAC authentication tests to cryptodev tests")
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
app/test/test_cryptodev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
index d744b37..609908b 100644
--- a/app/test/test_cryptodev.c
+++ b/app/test/test_cryptodev.c
@@ -4288,7 +4288,7 @@ static int create_gmac_session(uint8_t dev_id,
ut_params->cipher_xform.cipher.key.data = cipher_key;
ut_params->cipher_xform.cipher.key.length = tdata->key.len;
- TEST_HEXDUMP(stdout, "key:", key, key_len);
+ TEST_HEXDUMP(stdout, "key:", cipher_key, tdata->key.len);
ut_params->auth_xform.type = RTE_CRYPTO_SYM_XFORM_AUTH;
ut_params->auth_xform.next = NULL;
@@ -4430,8 +4430,6 @@ test_AES_GMAC_authentication_verify(const struct gmac_test_data *tdata)
TEST_ASSERT_EQUAL(ut_params->op->status, RTE_CRYPTO_OP_STATUS_SUCCESS,
"crypto op processing failed");
- TEST_HEXDUMP(stdout, "auth tag:", auth_tag, tdata->gmac_tag.len);
-
return 0;
}
--
2.1.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/test: fix compilation error when debug mode enabled
2016-09-26 13:52 [dpdk-dev] [PATCH] app/test: fix compilation error when debug mode enabled Arek Kusztal
@ 2016-09-26 14:11 ` Jain, Deepak K
2016-09-26 19:14 ` De Lara Guarch, Pablo
1 sibling, 0 replies; 4+ messages in thread
From: Jain, Deepak K @ 2016-09-26 14:11 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, dev
Cc: Trahe, Fiona, De Lara Guarch, Pablo, Griffin, John
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Monday, September 26, 2016 2:53 PM
> To: dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Griffin, John <john.griffin@intel.com>;
> Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] app/test: fix compilation error when debug mode enabled
>
> This patch fixes compilation error in test_cryptodev.c when
> RTE_LOG_DEBUG is specified
>
> Fixes: ba0dda7a7100 ("app/test: add GMAC authentication tests to
> cryptodev tests")
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> app/test/test_cryptodev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index
> d744b37..609908b 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -4288,7 +4288,7 @@ static int create_gmac_session(uint8_t dev_id,
> ut_params->cipher_xform.cipher.key.data = cipher_key;
> ut_params->cipher_xform.cipher.key.length = tdata->key.len;
>
> - TEST_HEXDUMP(stdout, "key:", key, key_len);
> + TEST_HEXDUMP(stdout, "key:", cipher_key, tdata->key.len);
>
> ut_params->auth_xform.type = RTE_CRYPTO_SYM_XFORM_AUTH;
> >gmac_tag.len);
> -
> return 0;
>
> }
> --
> 2.1.0
Acked-by: Deepak Kumar Jain <deepak.k.jain@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/test: fix compilation error when debug mode enabled
2016-09-26 13:52 [dpdk-dev] [PATCH] app/test: fix compilation error when debug mode enabled Arek Kusztal
2016-09-26 14:11 ` Jain, Deepak K
@ 2016-09-26 19:14 ` De Lara Guarch, Pablo
2016-09-27 10:02 ` Kusztal, ArkadiuszX
1 sibling, 1 reply; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2016-09-26 19:14 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, dev; +Cc: Trahe, Fiona, Jain, Deepak K, Griffin, John
Hi Arek,
> -----Original Message-----
> From: Kusztal, ArkadiuszX
> Sent: Monday, September 26, 2016 6:53 AM
> To: dev@dpdk.org
> Cc: Trahe, Fiona; Jain, Deepak K; De Lara Guarch, Pablo; Griffin, John; Kusztal,
> ArkadiuszX
> Subject: [PATCH] app/test: fix compilation error when debug mode enabled
>
> This patch fixes compilation error in test_cryptodev.c when
> RTE_LOG_DEBUG is specified
>
> Fixes: ba0dda7a7100 ("app/test: add GMAC authentication tests to cryptodev
> tests")
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> app/test/test_cryptodev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index d744b37..609908b 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -4288,7 +4288,7 @@ static int create_gmac_session(uint8_t dev_id,
> ut_params->cipher_xform.cipher.key.data = cipher_key;
> ut_params->cipher_xform.cipher.key.length = tdata->key.len;
>
> - TEST_HEXDUMP(stdout, "key:", key, key_len);
> + TEST_HEXDUMP(stdout, "key:", cipher_key, tdata->key.len);
>
> ut_params->auth_xform.type = RTE_CRYPTO_SYM_XFORM_AUTH;
> ut_params->auth_xform.next = NULL;
> @@ -4430,8 +4430,6 @@ test_AES_GMAC_authentication_verify(const struct
> gmac_test_data *tdata)
> TEST_ASSERT_EQUAL(ut_params->op->status,
> RTE_CRYPTO_OP_STATUS_SUCCESS,
> "crypto op processing failed");
>
> - TEST_HEXDUMP(stdout, "auth tag:", auth_tag, tdata->gmac_tag.len);
This removal is not related to this fix. If you want to remove it, better to send it in another patch.
Thanks,
Pablo
> -
> return 0;
>
> }
> --
> 2.1.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/test: fix compilation error when debug mode enabled
2016-09-26 19:14 ` De Lara Guarch, Pablo
@ 2016-09-27 10:02 ` Kusztal, ArkadiuszX
0 siblings, 0 replies; 4+ messages in thread
From: Kusztal, ArkadiuszX @ 2016-09-27 10:02 UTC (permalink / raw)
To: De Lara Guarch, Pablo, dev; +Cc: Trahe, Fiona, Jain, Deepak K, Griffin, John
> -----Original Message-----
> From: De Lara Guarch, Pablo
> Sent: Monday, September 26, 2016 8:14 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>; Griffin, John <john.griffin@intel.com>
> Subject: RE: [PATCH] app/test: fix compilation error when debug mode
> enabled
>
> Hi Arek,
>
> > -----Original Message-----
> > From: Kusztal, ArkadiuszX
> > Sent: Monday, September 26, 2016 6:53 AM
> > To: dev@dpdk.org
> > Cc: Trahe, Fiona; Jain, Deepak K; De Lara Guarch, Pablo; Griffin,
> > John; Kusztal, ArkadiuszX
> > Subject: [PATCH] app/test: fix compilation error when debug mode
> > enabled
> >
> > This patch fixes compilation error in test_cryptodev.c when
> > RTE_LOG_DEBUG is specified
> >
> > Fixes: ba0dda7a7100 ("app/test: add GMAC authentication tests to
> > cryptodev
> > tests")
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> > app/test/test_cryptodev.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> > index d744b37..609908b 100644
> > --- a/app/test/test_cryptodev.c
> > +++ b/app/test/test_cryptodev.c
> > @@ -4288,7 +4288,7 @@ static int create_gmac_session(uint8_t dev_id,
> > ut_params->cipher_xform.cipher.key.data = cipher_key;
> > ut_params->cipher_xform.cipher.key.length = tdata->key.len;
> >
> > - TEST_HEXDUMP(stdout, "key:", key, key_len);
> > + TEST_HEXDUMP(stdout, "key:", cipher_key, tdata->key.len);
> >
> > ut_params->auth_xform.type = RTE_CRYPTO_SYM_XFORM_AUTH;
> > ut_params->auth_xform.next = NULL;
> > @@ -4430,8 +4430,6 @@ test_AES_GMAC_authentication_verify(const
> struct
> > gmac_test_data *tdata)
> > TEST_ASSERT_EQUAL(ut_params->op->status,
> > RTE_CRYPTO_OP_STATUS_SUCCESS,
> > "crypto op processing failed");
> >
> > - TEST_HEXDUMP(stdout, "auth tag:", auth_tag, tdata-
> >gmac_tag.len);
>
> This removal is not related to this fix. If you want to remove it, better to send
> it in another patch.
>
> Thanks,
> Pablo
> > -
> > return 0;
> >
> > }
> > --
> > 2.1.0
Self Nack - Both lines are removed in different patch
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-27 10:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-26 13:52 [dpdk-dev] [PATCH] app/test: fix compilation error when debug mode enabled Arek Kusztal
2016-09-26 14:11 ` Jain, Deepak K
2016-09-26 19:14 ` De Lara Guarch, Pablo
2016-09-27 10:02 ` Kusztal, ArkadiuszX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).