From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4A9A63B5 for ; Tue, 27 Sep 2016 12:02:19 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 27 Sep 2016 03:02:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,404,1470726000"; d="scan'208";a="766376712" Received: from irsmsx101.ger.corp.intel.com ([163.33.3.153]) by FMSMGA003.fm.intel.com with ESMTP; 27 Sep 2016 03:02:17 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.198]) by IRSMSX101.ger.corp.intel.com ([163.33.3.153]) with mapi id 14.03.0248.002; Tue, 27 Sep 2016 11:02:16 +0100 From: "Kusztal, ArkadiuszX" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "Trahe, Fiona" , "Jain, Deepak K" , "Griffin, John" Thread-Topic: [PATCH] app/test: fix compilation error when debug mode enabled Thread-Index: AQHSF/1PljHPjtGIpU+bDEV2BYmFkKCME4wAgAEIy/A= Date: Tue, 27 Sep 2016 10:02:16 +0000 Message-ID: <80307F746F1522479831AB1253B7024E6E5DB4@IRSMSX102.ger.corp.intel.com> References: <1474897968-27642-1-git-send-email-arkadiuszx.kusztal@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWQyODA5NGUtNjI1My00ZDE5LTkzYjQtOGFkMGNjMjVmNzYyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkZ3QklTMERKWkVGWDMxSXZ3WTE5VFJ3MnJwNW1tNHBVQTA0MGJ4VFhLenc9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/test: fix compilation error when debug mode enabled X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Sep 2016 10:02:19 -0000 > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Monday, September 26, 2016 8:14 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Trahe, Fiona ; Jain, Deepak K > ; Griffin, John > Subject: RE: [PATCH] app/test: fix compilation error when debug mode > enabled >=20 > Hi Arek, >=20 > > -----Original Message----- > > From: Kusztal, ArkadiuszX > > Sent: Monday, September 26, 2016 6:53 AM > > To: dev@dpdk.org > > Cc: Trahe, Fiona; Jain, Deepak K; De Lara Guarch, Pablo; Griffin, > > John; Kusztal, ArkadiuszX > > Subject: [PATCH] app/test: fix compilation error when debug mode > > enabled > > > > This patch fixes compilation error in test_cryptodev.c when > > RTE_LOG_DEBUG is specified > > > > Fixes: ba0dda7a7100 ("app/test: add GMAC authentication tests to > > cryptodev > > tests") > > > > Signed-off-by: Arek Kusztal > > --- > > app/test/test_cryptodev.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c > > index d744b37..609908b 100644 > > --- a/app/test/test_cryptodev.c > > +++ b/app/test/test_cryptodev.c > > @@ -4288,7 +4288,7 @@ static int create_gmac_session(uint8_t dev_id, > > ut_params->cipher_xform.cipher.key.data =3D cipher_key; > > ut_params->cipher_xform.cipher.key.length =3D tdata->key.len; > > > > - TEST_HEXDUMP(stdout, "key:", key, key_len); > > + TEST_HEXDUMP(stdout, "key:", cipher_key, tdata->key.len); > > > > ut_params->auth_xform.type =3D RTE_CRYPTO_SYM_XFORM_AUTH; > > ut_params->auth_xform.next =3D NULL; > > @@ -4430,8 +4430,6 @@ test_AES_GMAC_authentication_verify(const > struct > > gmac_test_data *tdata) > > TEST_ASSERT_EQUAL(ut_params->op->status, > > RTE_CRYPTO_OP_STATUS_SUCCESS, > > "crypto op processing failed"); > > > > - TEST_HEXDUMP(stdout, "auth tag:", auth_tag, tdata- > >gmac_tag.len); >=20 > This removal is not related to this fix. If you want to remove it, better= to send > it in another patch. >=20 > Thanks, > Pablo > > - > > return 0; > > > > } > > -- > > 2.1.0 Self Nack - Both lines are removed in different patch