From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8477D7E93 for ; Wed, 5 Oct 2016 11:27:16 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 05 Oct 2016 02:27:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,448,1473145200"; d="scan'208";a="1040569580" Received: from irsmsx110.ger.corp.intel.com ([163.33.3.25]) by orsmga001.jf.intel.com with ESMTP; 05 Oct 2016 02:27:14 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.198]) by irsmsx110.ger.corp.intel.com ([163.33.3.25]) with mapi id 14.03.0248.002; Wed, 5 Oct 2016 10:26:42 +0100 From: "Kusztal, ArkadiuszX" To: Akhil Goyal , "dev@dpdk.org" , "Doherty, Declan" CC: "Jain, Deepak K" , "Trahe, Fiona" , "Griffin, John" Thread-Topic: [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest should be stored at a DMAeble address Thread-Index: AQHSHtNyWfuUk+gvLE6t2pq54RDMo6CZk36g Date: Wed, 5 Oct 2016 09:26:42 +0000 Message-ID: <80307F746F1522479831AB1253B7024E6E9988@IRSMSX102.ger.corp.intel.com> References: <20160926163300.22990-1-akhil.goyal@nxp.com> <20160926163300.22990-3-akhil.goyal@nxp.com> <17b5c942-4b83-2ef0-a0f7-6755eaf73383@nxp.com> In-Reply-To: <17b5c942-4b83-2ef0-a0f7-6755eaf73383@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWE4YjBjODYtM2NmYS00MWFiLTk5YjQtNDA4Mzk2N2IyYjFkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InFZd1l0dlFsTHZZNzBkTnV0dXdqNFVjUGw5MWhLYlBid2dLMUZGRmRNK2c9In0= x-ctpclassification: CTP_IC x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest should be stored at a DMAeble address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Oct 2016 09:27:17 -0000 Hi Akhil, Could you rebase it against newest next-crypto subtree, there were changes = with function names in the meantime. And to make it really consistent across all hw tests could you add this cha= nge to qat_snow3g too,=20 for snow3g I assume aad need to obtain correct physical address too. Regards, Arek > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Akhil Goyal > Sent: Wednesday, October 05, 2016 7:40 AM > To: dev@dpdk.org; Doherty, Declan > Subject: Re: [dpdk-dev] [PATCH] test_cryptodev_perf: IV and digest should > be stored at a DMAeble address >=20 > On 9/26/2016 10:03 PM, akhil.goyal@nxp.com wrote: > > From: Akhil Goyal > > > > For physical crypto devices, IV and digest are processed by the crypto > > device which need the contents to be written on some DMA able address. > > > > So in order to do that, IV and digest are accomodated in the packet. > > > > Signed-off-by: Akhil Goyal > > --- > > app/test/test_cryptodev_perf.c | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/app/test/test_cryptodev_perf.c > > b/app/test/test_cryptodev_perf.c index 0ea7ec1..930d5b8 100644 > > --- a/app/test/test_cryptodev_perf.c > > +++ b/app/test/test_cryptodev_perf.c > > @@ -2366,9 +2366,13 @@ test_perf_set_crypto_op(struct rte_crypto_op > *op, struct rte_mbuf *m, > > op->sym->auth.aad.length =3D AES_CBC_CIPHER_IV_LENGTH; > > > > /* Cipher Parameters */ > > - op->sym->cipher.iv.data =3D aes_cbc_iv; > > + op->sym->cipher.iv.data =3D (uint8_t *)m->buf_addr + m->data_off; > > + op->sym->cipher.iv.phys_addr =3D rte_pktmbuf_mtophys(m); > > op->sym->cipher.iv.length =3D AES_CBC_CIPHER_IV_LENGTH; > > > > + rte_memcpy(op->sym->cipher.iv.data, aes_cbc_iv, > > + AES_CBC_CIPHER_IV_LENGTH); > > + > > /* Data lengths/offsets Parameters */ > > op->sym->auth.data.offset =3D 0; > > op->sym->auth.data.length =3D data_len; @@ -2468,7 +2472,9 @@ > > test_perf_aes_sha(uint8_t dev_id, uint16_t queue_id, > > rte_pktmbuf_free(mbufs[k]); > > return -1; > > } > > - > > + /* Make room for Digest and IV in mbuf */ > > + rte_pktmbuf_append(mbufs[i], digest_length); > > + rte_pktmbuf_prepend(mbufs[i], > AES_CBC_CIPHER_IV_LENGTH); > > } > > > > > > > Hi Declan, >=20 > Sorry I missed out copy your name in the TO list. Do we have some > comments on this patch. >=20 > Regards, > Akhil