From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 3D6F12C07 for ; Mon, 18 Jul 2016 11:21:16 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id o80so107099094wme.1 for ; Mon, 18 Jul 2016 02:21:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=kpeG8b4na/kiIZKEEZ4ISi9S73InRbEYaW9IaDmXSQk=; b=ARJyYuUraOv20p/ty9nosiUpt+CCt6nKjrCwb2ybpkV5ECXXi3XQCAHF1omH6/Zae6 O+Gxqn6VU5PMBfySGAa3eHMhX3JYIGLxfLfTOsCfR3QJM6Y1wDp/v5+kl5QP0FnY8p6F 29uj2KE1rCESO+5nHWV7n8rMTv/mOAW1CEeuE30hvFG8sYQ3ck3enLqW3qcKf/wHwy3L KAFFosuYPy9kQHHfsmS66dO0Epj4u7YPdg3H+PeFIuFENsEmqubrLiM8ImzDIP9sIbAE Fbo3fuQXP8WUAmg0Gnqr7u0xxy4MHyuJEgcKt7npdDpYii49FJh+3CK0qyPTHtYpp5oV /Lmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=kpeG8b4na/kiIZKEEZ4ISi9S73InRbEYaW9IaDmXSQk=; b=RTUV0fxui8WFNKUZJ/zmXDbyNc9tHzK4lJrC3PKhZ/+mXNPWOTibJXMWnCGQ+civeC LaiflNFtyKgW+DWeCnvSsu24hlXaub4y99GE3LkdabpAybPBhysMd34eCFxBu6mIN0lc QQAHYrLrwu19zTkpKhDWk0tbFEsWzI1K80UznOTNi5lRdkzP5WJUoh4L/7r/U5L859zs JkqubOnUBtO6B5Oa7JMGydOPzMWVdE4TqN3/z3QORWjtZ6i+ovn25nZwejr4c3r2VC3K Kh/7jAksF7RUIoISiThTcZaaTxiMWYvU7107NRIgj2vdcSw6t4w/eay1U+i/x7eQU7LG FHMg== X-Gm-Message-State: ALyK8tLNbDmwfviRy2v17RldaxNzQ50C/IOvBTRc4gymfE7vpkkJdaDtfwFHNmidAZ3bag16 X-Received: by 10.28.64.193 with SMTP id n184mr8504354wma.37.1468833676013; Mon, 18 Jul 2016 02:21:16 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id v189sm15544261wmv.12.2016.07.18.02.21.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 18 Jul 2016 02:21:15 -0700 (PDT) From: Thomas Monjalon To: Yong Wang Cc: dev@dpdk.org, "Liang, Cunming" , david.marchand@6wind.com Date: Mon, 18 Jul 2016 11:21:14 +0200 Message-ID: <8032858.THXMY6Ofjq@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <578C74D9.1030907@intel.com> References: <1468542971-48198-1-git-send-email-yongwang@vmware.com> <578C74D9.1030907@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: fix rte_intr_dp_is_en() check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2016 09:21:16 -0000 Hi Yong, I think the interrupt management should be simpler. If you want to invest some time to rework this API, you are very welcome. 2016-07-18 14:19, Liang, Cunming: > Hi Yong, > > rte_intr_dp_is_en() returns true when rte_intr_efd_enable() (the way to > enable data-path interrupt) sets a number of event fds. > In this case, "intr_conf.rxq=1" configuration causes "nb_efd=1". The > value comes from RTE_MIN($nb_efd, 1) from data-path, but not from link > event. > Per link event, you shouldn't use rte_intr_dp_is_en() as the indication. > As igb_uio only has a single vector, when the conflict(both intr_rxq and > intr_lsc turn on) happens, the intr_rxq has high priority than intr_lsc > as default PMD behavior. > Reference as PG 3.1.9 note in > http://dpdk.org/doc/guides/prog_guide/env_abstraction_layer.html > > Regards, > Cunming > > On 7/15/2016 8:36 AM, Yong Wang wrote: > > When binding a device to igb_uio with intr_conf.rxq set to 1, nb_efd > > is 1 (for link event) but rte_intr_dp_is_en() will still return true. > > rte_intr_dp_is_en() should also consider intr_handle type in addition > > to nb_efd. > > > > Signed-off-by: Yong Wang