From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62C2D45C22; Fri, 1 Nov 2024 03:46:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C6DA43283; Fri, 1 Nov 2024 03:46:01 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2062.outbound.protection.outlook.com [40.107.101.62]) by mails.dpdk.org (Postfix) with ESMTP id 5DCCC40265 for ; Fri, 1 Nov 2024 03:46:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Tc5dfICTmwb2U6s8CftsS+lSv6srfZWAzhhLQm/Qtlmnj0R7fFxbcCIS8gyFGTD02rN4px/PptoXIZWuoxJaONWgN9EakvzMOKZpUP+eMN3Q2pFylTw7R8zb4O0i8TZUi0SsDT+Ulk4RssD1wU7V/LUqDWOGrUzI1QAXu8b3BqIhHaLaJ7TghX9WNxrKkXGwS86mKDBlTonq5vpSUMyzXKzOVwIhGG0uco0P2D4e9JFjxJYFxmLrDOzNthoqHn/woJa4erLi/c2xkFA2ihY3BjGcVLrZUNADPs98wNFfC9qVaeJ7W2e/kX6xmGnpngcgfXV/UUbTMD/ubrwJIKBo4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F7b0+DUT2mzqMKpPuXldUnb1QkO4ezNx9QDHoes/XzY=; b=S8tM6yYGs6ZFjfWIo/75xBC18sDx67NLt5fZ87iQokfuYDP398PT/E0YgSMAGx2j0EKF6EwlhkNXChcU+i5Rjd6ywETifCRZSIMZYjNUg1cB3kSXcVeuCPvEoB5K1bnCZiWYhNQ0Y3BPZJJhwgXAoAnpGI9nuwoWumMzX1yVOtX7QCHZ/S7vuc3VzwT5oJoRDyP7J8W0BV8hKrIm31nwUfDoFo+vWiDrvjFtT7t6K0Txz5h9k5L/BW1PLxcK3XoyWxmKk8QpY2kPkFoAoM6Jwiaqp6Ao0mNCUz2aCebjnUAUQB4Hpyy5/cT8UyUU+7tH8SIkP8xdDRoFASDCUoHGlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F7b0+DUT2mzqMKpPuXldUnb1QkO4ezNx9QDHoes/XzY=; b=e/EhpW9PHYYiTt6q51AgEqoCBIRdPJxvyCjiQq3hUIuWTPUAzJKaed0KzcytSSV5h1R8AJeSVpm89mEe5RZr3c8Ss1xtustOU7xrR8RZWvraeu/Bk70RzjTSQsci71OkrL3QGuxcsw7+fpHg+ropUN7WpImgfaDwR/FLVFGneZg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by DS0PR12MB8296.namprd12.prod.outlook.com (2603:10b6:8:f7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.20; Fri, 1 Nov 2024 02:45:58 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%4]) with mapi id 15.20.8093.024; Fri, 1 Nov 2024 02:45:57 +0000 Message-ID: <8039e56a-a73f-4f7e-ae2a-366ce79071ef@amd.com> Date: Fri, 1 Nov 2024 02:45:52 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 07/13] net/txgbe: add Tx descriptor error statistics To: Jiawen Wu , dev@dpdk.org References: <20241023064836.2017879-1-jiawenwu@trustnetic.com> <20241028023147.60157-1-jiawenwu@trustnetic.com> <20241028023147.60157-8-jiawenwu@trustnetic.com> <03d001db2c02$ba5ac830$2f105890$@trustnetic.com> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <03d001db2c02$ba5ac830$2f105890$@trustnetic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0326.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a4::26) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|DS0PR12MB8296:EE_ X-MS-Office365-Filtering-Correlation-Id: 384b3bea-44d2-480d-671d-08dcfa1f5034 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?SW5DWHd4V25ObmNuZmhSV2VpREczU0FOMTZyZDRING9zRVlnaW1yZVRwWStO?= =?utf-8?B?UFlnYWxsTUpURFBXc2t1RHBMK2diOGc2endvSUNoNk9FcGdCZC9ZaWhmMjU3?= =?utf-8?B?ODZ3WEluNHd6bVlkdXZFdGhpQkpnVFgyWTYrNmcyc1ZNOUpQU2dCVlJKODdj?= =?utf-8?B?b3d4RmlYc1RuYjQxM2xaUkpyMk9VUnhlenNSallER1JKS3dsYURNQmVvU0oy?= =?utf-8?B?dzdJY1dyYjRGQys2NWtoRVczNENFUXVaMDNYZGpNRlIwb3lueFIrck9Rd3hz?= =?utf-8?B?R2N6RTd5dzBFenJSS3FhNW4wbDZ4VitBeEVFVWxsdzJqYzhnMk9BY1l4NGt3?= =?utf-8?B?MENOL1IzcXpSVzdwQllQOE9kQTJWT1ZVUGJQRU1Mdlduc0JGM0xObURua0pt?= =?utf-8?B?Q3JIQnpyZ0dKS0UzdGE0ZlFpNnVWbGNDTDVrTkR2QlNIYjFhNnFwV1VNOTlk?= =?utf-8?B?OG5SOUo1QjAyM2RyODdKRHR1TG5IWkMrSmFyNFJjT0RWRGhCUWQzZnJJSDdm?= =?utf-8?B?bWFuM2V6RVN4dlBjS3BWaG9Md3NKQ24wWlJMdUhISGNHUHpheVc1S2ZucUh0?= =?utf-8?B?ZVlxR1E4VVQyOXkrdms4cUVsT3kyTUFXVUdWM01tck1NQzdaRUgzVWl5NXJF?= =?utf-8?B?RzE0Zmt4blo1cjk2MEljS0NIeWpZQ2JYRm11UUZSRkVvTWZydEgyME1KdFpy?= =?utf-8?B?UzlaRnB3N3J2bUhvKzFQK1ZnWjZXQTdpeExROW95Rk5DU2VWbWRXMm1WNE9o?= =?utf-8?B?UU1SaHV6TjI2R0ZEM0FNTXVnWHdCcERLbnJHUEFpMW5tMEUzK2NtWUNyOEE4?= =?utf-8?B?aDhwYXQ5V0czbzkwTFM2TDlUY1FaT2V0SXcrUWY2c1p0OERXeFVOR0VnT2dQ?= =?utf-8?B?TzN4bkN3VEY4N2FCSzREcXlEVS9QMk5kK0JoMzJ3bHBjS29oTHY5MVRnVXJZ?= =?utf-8?B?Z3hYaklFcFU2SmFoL1EvbVpEWGFiUVRhemRObUhUODNyYmdjakcrZkM4T2Ru?= =?utf-8?B?ZHc5ajRBN2pmZTV0VjNWcmpFcUViTEd5M2VMK2pPVjZ1d2NqYVRjcWxLSkk1?= =?utf-8?B?R2I5K0VYU2hyejF6SzB4Uld2VWc0RVh6eVRKQVpLSUZJMmw2UjFFTzlnc29n?= =?utf-8?B?VGZmMkpqZndQM1QwSHkxQWhQQ1h5dlViYXcyTFNEdHhEWTJxUWNRMDUvNG5y?= =?utf-8?B?dGloamFpa2Y1M3Y4UEFMdzdMY29uNE9YTCtqS2VJWFFpdUNELzhlN2ZSUWor?= =?utf-8?B?c1hHcnpwOFB4N3BJTVlDbFdqR1RIR2k4VFpyaWZZUnROR3gzanM4am9ZUnJy?= =?utf-8?B?R0liZks3VjkyTXJIUUdldkgvMm56di9oQ2NtTTFTZWx4UFArQWRta3FObkU3?= =?utf-8?B?cjhBSG5JU3RRbjR3UFFnZnNKeHJWcUdycTkvcWxoa0M2eUdBdXh1Smx0QVJY?= =?utf-8?B?WTQ3UzhGV1NIS2RvdUlVYVVRL3ByNmNPeDMvMGFkRWkxak9FbFZ1ckp5RXRw?= =?utf-8?B?TW1SYjFMT2N1TEFwTlJ3M1hjdVhaMmQxS09YblY0WEJKT2l0ei9ZWTkxVmcy?= =?utf-8?B?aGRCRG5XTEFwTnpQNHZEQURmdjZJUms4akZMME9IYi9BK1AyN0g2QVJhSG9r?= =?utf-8?B?Q1JhY1VPTDJ1WExIaTZybnJ4N1ZTT0hOa2VPZUkvNEd4djluYWE5YWp0NENl?= =?utf-8?B?N2EydEN2Nm8vWGZRQUlBdElrcm9iV1pvUTVsR3RkOGZuZVdMclN4M1daWXg2?= =?utf-8?Q?t/dDDWUQdqWPaxdNFY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L0Z2S21lb3VxSEdNNmc4Mk1acGJuaW5WdHlFNmpSNnlwUUdxQTRBc1liZkd4?= =?utf-8?B?TC9SVldiN0Zkb3l3bWIvSjlGbU83Q3JuSmpBUmUza21CZmJPNlhyT1QvclhU?= =?utf-8?B?VFJXL3U1S3FGWGllZERYdzhXTE9xTWNzYUdUdGQxcmN3V1E5c1JMcVNISDZv?= =?utf-8?B?dHoyUEFINjJXY2lmSnFHTytjRWhCaGJMb2hsZW5RdGt3ZHBTWHNMZ0Vod3J4?= =?utf-8?B?VHdqUG91QS9IT2hmMlFqSTJOd080TjA2Y0RhNVZ3emN5bnpkSUx0cEJpdUhm?= =?utf-8?B?SzFzcExxUW5qZTR2OFNHNytoSTdlUkljVXh0YkJETDRwbWh5OXVOMDZzK0J0?= =?utf-8?B?SmJGVUdpeDJpWEw4WjdzZnlzSVVkUDNGbEQ4NVRHTDVUdkcwM1Z6R2JNemY3?= =?utf-8?B?YlBZdUN3VzVadzZkMkhhcUZZVDA5SU4ySjZDWHJvTGlFOWFvL2FjY2dIbUs1?= =?utf-8?B?SFhxbzAyK09peUJXZGNoQkJQMlhENmRna0ppMXhITjNMU3hzWlpBL3ArRWE0?= =?utf-8?B?Z1RSSXNNUVBuWmxhVWV6UitRZTlvQWZ6dXBneWdSOXlzdFlhQzdXd2Vod2Fu?= =?utf-8?B?MUkya2Rqb0kzYWh1SHFFUFFIUWpJSnJlZ0I5ek9yVnVQRndmU2pBR25VVUJV?= =?utf-8?B?cmd0T2Z3UXJ4MEErdjFzNDlIYmgxc291ZGJnTjRHV0VLQnBRWkUwcjgwdGwz?= =?utf-8?B?bUhzNUtlb1FVU2JoNUNmWk8zclVvR0tyeTZUMVAvQkxGZ2FPdWhqZnJraHRB?= =?utf-8?B?bll1cUFDVXdRVlI5R1YyRU03VVlWd09BZ25rL05sQzJ5ZEdtbURIVzREdDBE?= =?utf-8?B?cDlxcXBLeVdEUkw3UHc4b3liZS8yeHF0cy9kTEdEaXlXejdjY0xjOHFXamFm?= =?utf-8?B?aHdJb05DVnVsMVBtNzJ6VFpMTFhlYzY4Sm5DT0J0OVBpNjJBUUh0U2xrZGkx?= =?utf-8?B?a1MxaVFtVWU3Vys3dG1DaVYxZE0ySkdGbjVVcTdmYnE2T0RoakV0cGZlTnhh?= =?utf-8?B?OExQdUVBQUN1YzZEb3hpNDF1NDlmazFLaTdhbGkvWmlxSm1xRHpEbis4R1cy?= =?utf-8?B?cERFd1p2emNYZ3FtUHFzRzY0d0hCbW8vQXROTTRiRVVYRHB3REtJdGVPOUQ0?= =?utf-8?B?WlFvTDJ6K29oWis4TmRWcEFpeDEyNUU5TDVpUlBuZlBXNGpyMUFCM1MzeDBW?= =?utf-8?B?L1JrQjdkd1owS2lSVHEzdUdYU3NGV3pvU1phWjlVV2krdmY5MHQ0WE5BWiti?= =?utf-8?B?Rm0zcjZHL2NHMDJOSC9zOWNvNmR3bmZNUTIzK3d3SmdPcHhtV3ZrREU3NVdM?= =?utf-8?B?ZFhHVzQyVm5QMGkvMW5BZkVaUkFwaThORUZlZ3hLL3BhcE9Nc0RYRU9rTWtD?= =?utf-8?B?enVCdVBXeGw2bHlxWmh6STlHMDBiZkFoZ2ZwcVdIMUZCa2Mzbm5hbCs5RFpw?= =?utf-8?B?NjVMTis1S0xiVmFGVmptUVhRM21EZEVaRHo0RzJaVzJMMHRMTUxvQXVnY2lw?= =?utf-8?B?N0xBYm5CSFh4MG0wU1hmWDZDNUx0SEVLUWZ6b25ibDZqQnBJZytHbzZiWlBh?= =?utf-8?B?SFhCVkMrWE01bDFSeWFvTUEzQ21RaVppNklSQksyOXlwajZjaUxIVzhhNVBp?= =?utf-8?B?dVpKRjZ3eWxQVGJLL3g4dS95SmVqM2Z1REdpQ3QrMmVKVzcrNXVlWm5zNXd4?= =?utf-8?B?NUVXK0dKV1orVmE2L1BXblkvejBsNFhPUm5xNFRlVkVPUDdld1U5UUI3cm9Z?= =?utf-8?B?aUV1aFhVQVR3UVRINXZCVFdmazg5di9mR2ZQRmloY29KR09XYzZjQlY3Wnhz?= =?utf-8?B?M0NuUzE3QmRTejkwRlR4T3FsRDNqZ0doSmpUR0NmbUtJeUhHcktUZE9YS29z?= =?utf-8?B?T1A0Z3V1Tk5ZOWpQQk1QSXJ1MWwyRGJaeVNlT1VYVXZ1dmJ4eEQyZWsrdnRU?= =?utf-8?B?NDhqZFBNNkozMjg2eTVyNW5ETXFnQmZuWjJKWXlJSCs2L2NadVNXZG5iZU9u?= =?utf-8?B?SlRHRnoxRmhyTkwyRHZld0c4cXpRMzRhTlVSTkM1dWd1c0J4Y042OWhBRmNP?= =?utf-8?B?VUJOWUpZTHdncy9DMkY4YnFoZGNUQ1l6SFgrazVyN0Y3VkdlOVRMc3pLcGVY?= =?utf-8?Q?w4O0jiuX8csbrnmqHb5ZptFtZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 384b3bea-44d2-480d-671d-08dcfa1f5034 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2024 02:45:57.8671 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vI+leyysL/WiLfmnRmc2+kXPmsdoslBBM9tB8ekaz9TABUwD/GHAOosvtHIzyYhA X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8296 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/1/2024 2:06 AM, Jiawen Wu wrote: >>> @@ -4980,6 +4982,7 @@ txgbe_tx_queue_clear_error(void *param) >>> if (!txq->resetting) >>> continue; >>> >>> + txq->desc_error++; >>> >> >> Why error value is increased in this function, which resets the Tx queue? >> Is the intention to reset the error value here? > > When there is a desc error to cause Tx ring hang, the interrupt directs to > reset of the queue. So we increase the error count in the specific queue > reset function. The queue is reset, but the error that led to the resetting > is recorded. The error count is only reset at the setup function. > Got it. But this variable counts number of bad packets. Increasing it when Tx ring hang too may be confusing as there are two different reasons to increase the counter. Btw, .stats_reset() needs to reset this error stat.