DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/atlantic: get rid of double declaration of dev info get
@ 2019-09-01 14:36 Andrew Rybchenko
  2019-09-02 10:32 ` Igor Russkikh
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Rybchenko @ 2019-09-01 14:36 UTC (permalink / raw)
  To: Igor Russkikh, Pavel Belous; +Cc: dev, Ivan Ilchenko, stable

From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>

atl_dev_info_get() is declared twice in atl_ethdev.c.
Delete one of these declararions.

Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop")
Cc: stable@dpdk.org

Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
 drivers/net/atlantic/atl_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c
index 3c1b349..4a99699 100644
--- a/drivers/net/atlantic/atl_ethdev.c
+++ b/drivers/net/atlantic/atl_ethdev.c
@@ -45,9 +45,6 @@ static int atl_dev_xstats_get(struct rte_eth_dev *dev,
 static int atl_fw_version_get(struct rte_eth_dev *dev, char *fw_version,
 			      size_t fw_size);
 
-static void atl_dev_info_get(struct rte_eth_dev *dev,
-			       struct rte_eth_dev_info *dev_info);
-
 static const uint32_t *atl_dev_supported_ptypes_get(struct rte_eth_dev *dev);
 
 static int atl_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] net/atlantic: get rid of double declaration of dev info get
  2019-09-01 14:36 [dpdk-dev] [PATCH] net/atlantic: get rid of double declaration of dev info get Andrew Rybchenko
@ 2019-09-02 10:32 ` Igor Russkikh
  2019-09-02 16:20   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
  0 siblings, 1 reply; 3+ messages in thread
From: Igor Russkikh @ 2019-09-02 10:32 UTC (permalink / raw)
  To: Andrew Rybchenko, Pavel Belous; +Cc: dev, Ivan Ilchenko, stable



On 01.09.2019 17:36, Andrew Rybchenko wrote:
> From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
> 
> atl_dev_info_get() is declared twice in atl_ethdev.c.
> Delete one of these declararions.
> 
> Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

Thanks for noticing Andrew, Ivan.

Ack.

Regards,
  Igor

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [dpdk-stable] [PATCH] net/atlantic: get rid of double declaration of dev info get
  2019-09-02 10:32 ` Igor Russkikh
@ 2019-09-02 16:20   ` Ferruh Yigit
  0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2019-09-02 16:20 UTC (permalink / raw)
  To: Igor Russkikh, Andrew Rybchenko, Pavel Belous; +Cc: dev, Ivan Ilchenko, stable

On 9/2/2019 11:32 AM, Igor Russkikh wrote:
> 
> 
> On 01.09.2019 17:36, Andrew Rybchenko wrote:
>> From: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
>>
>> atl_dev_info_get() is declared twice in atl_ethdev.c.
>> Delete one of these declararions.
>>
>> Fixes: bb42aa9ffe4e ("net/atlantic: configure device start/stop")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ivan Ilchenko <Ivan.Ilchenko@oktetlabs.ru>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> Thanks for noticing Andrew, Ivan.
> 
> Ack.
> 
> Regards,
>   Igor
> 

Applied to dpdk-next-net/master, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-02 16:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-01 14:36 [dpdk-dev] [PATCH] net/atlantic: get rid of double declaration of dev info get Andrew Rybchenko
2019-09-02 10:32 ` Igor Russkikh
2019-09-02 16:20   ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).