From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74D61A04F0; Mon, 13 Jan 2020 00:09:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D1251D580; Mon, 13 Jan 2020 00:08:56 +0100 (CET) Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by dpdk.org (Postfix) with ESMTP id 6B8E11D57D for ; Mon, 13 Jan 2020 00:08:54 +0100 (CET) Received: by mail-qt1-f196.google.com with SMTP id k40so7575274qtk.8 for ; Sun, 12 Jan 2020 15:08:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:in-reply-to:references:in-reply-to :references; bh=XAC/kZ55ld1yOyyrNzC6Rx57A+9yqFz5fBnGymRzz+0=; b=RzDUdzDIeYJvD3OKCbW55RjrjLswDtzYT+BzNRxb/6jz25EusHZvVRPpQ09eI3Um6I zTa+kcxwu9if6pgnsBOaGU1f+tIV5GgscchEKkj87ChOTX3kObOiyh+DGIvAV9bKiYoT eC55GDfwJT+znth7S1llQlfBvHcznVGxwTRYvpXRhRpazU2T9iHRmtsxm8n6IFfRGhnM Dhrarf91TLFhwYYpcX7ozcm+bI3oP991D2m8eGzXmVUe6SlLa/T/I4SF9SPFPtmJNVU8 YYgjDKvgf9ThRS60YcP7vcwCtAIgrC+VKpACTzcpqOrb9tbgu+lCqs3fhpaKe/Xniu5k IJTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=XAC/kZ55ld1yOyyrNzC6Rx57A+9yqFz5fBnGymRzz+0=; b=fIc1DtQP9rpQCoImid3JmJIv6vVEG4MeOaTtyIRYHUk1nwrCpxZY+QaUaCsjlwVrpJ +37fmbwIFipcPEHVVMcqvL6RKJh2uX3kehgwGeAbqSVXzm3rkVK/4T7ki+zPPTbo+XWu CpMrYhyN0EU8ypMcP6yVT5H/pNy0ZgYhYv5DA00mjgyHOYnFv+JWOLwKHUnmdoHMEAOC B11C7ApSDigpTd6PSLz9+WWk/MkkL8cCJelpZ91F+F67qYZK547rU/RJsS7MAPnuQL7E 4u9W9pmN6sKWloAgJxw5Yd6Xzhq/bTTTyAtQJSiKVPQjXqD4gSPHrEWvymFdvf7mfak6 FINQ== X-Gm-Message-State: APjAAAWtKE4KCxEceLjccOHIW4X5ewRmJLduihBrhO49BrkRg5Ze6kYd 01xgcEG9lzSds+XHCvfZ17s= X-Google-Smtp-Source: APXvYqw7GtJb6DVHwrxT1B++D35ARr1au8Qn5pLeuzgNxEkoBRt9Aj9HlaHIdRhoDdsTtW7fPYyUcw== X-Received: by 2002:ac8:1730:: with SMTP id w45mr8395049qtj.297.1578870533601; Sun, 12 Jan 2020 15:08:53 -0800 (PST) Received: from sovaradhvm.ojp4suxva1celnnpiyhedynfde.bx.internal.cloudapp.net ([104.211.12.148]) by smtp.gmail.com with ESMTPSA id i23sm4174549qka.113.2020.01.12.15.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jan 2020 15:08:52 -0800 (PST) From: Sowmini Varadhan To: sowmini05@gmail.com, dev@dpdk.org Date: Sun, 12 Jan 2020 23:08:38 +0000 Message-Id: <80429899738d7ae51fce53a340637c6a77ba0bd9.1578787797.git.sowmini.varadhan@microsoft.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH RFC 1/2] Hooks to allow the setting of filters on tcp flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The rte_eth_ntuple_filter allows tcp_flags which can check for things like #define RTE_TCP_CWR_FLAG 0x80 /**< Congestion Window Reduced */ #define RTE_TCP_ECE_FLAG 0x40 /**< ECN-Echo */ #define RTE_TCP_URG_FLAG 0x20 /**< Urgent Pointer field significant */ #define RTE_TCP_ACK_FLAG 0x10 /**< Acknowledgment field significant */ #define RTE_TCP_PSH_FLAG 0x08 /**< Push Function */ #define RTE_TCP_RST_FLAG 0x04 /**< Reset the connection */ #define RTE_TCP_SYN_FLAG 0x02 /**< Synchronize sequence numbers */ #define RTE_TCP_FIN_FLAG 0x01 /**< No more data from sender */ but there are no existing examples that demonstrate how to use this feature. This patch extends the exisiting classification support to allow an optional flags in the input file. The flags string can be any concatenation of characters from {C, E, U, A, P, R, S, F} and "*" indicates "dont care". These flags are set in the ntuple_filter and are used to construct the tcp_spec and tcp_mask sent to the driver The rte_acl_field_def is updated to use the (u8) tcp flag as lookup key. Note that, as per https://doc.dpdk.org/guides/prog_guide/packet_classif_access_ctrl.html this field MUST be allocated fo4 4 bytes, thus it has sizeof(uint32_t). However, also note the XXX in this commit: additional updates are needed to the rte_flow_classify_table_entry_add() so that it does not ignore any key fields other than the 5-tuple. Signed-off-by: Sowmini Varadhan --- examples/flow_classify/flow_classify.c | 88 ++++++++++++++++++++-- examples/flow_classify/ipv4_rules_file.txt | 22 +++--- 2 files changed, 91 insertions(+), 19 deletions(-) diff --git a/examples/flow_classify/flow_classify.c b/examples/flow_classify/flow_classify.c index 1c12bbb2f..e74a53be7 100644 --- a/examples/flow_classify/flow_classify.c +++ b/examples/flow_classify/flow_classify.c @@ -51,6 +51,7 @@ enum { CB_FLD_DST_PORT_MASK, CB_FLD_PROTO, CB_FLD_PRIORITY, + CB_FLD_TCP_FLAGS, CB_FLD_NUM, }; @@ -81,6 +82,7 @@ enum { DST_FIELD_IPV4, SRCP_FIELD_IPV4, DSTP_FIELD_IPV4, + TCP_FLAGS_FIELD, NUM_FIELDS_IPV4 }; @@ -88,7 +90,8 @@ enum { PROTO_INPUT_IPV4, SRC_INPUT_IPV4, DST_INPUT_IPV4, - SRCP_DESTP_INPUT_IPV4 + SRCP_DESTP_INPUT_IPV4, + TCP_FLAGS_INDEX, }; static struct rte_acl_field_def ipv4_defs[NUM_FIELDS_IPV4] = { @@ -145,6 +148,17 @@ static struct rte_acl_field_def ipv4_defs[NUM_FIELDS_IPV4] = { sizeof(struct rte_ipv4_hdr) + offsetof(struct rte_tcp_hdr, dst_port), }, + /* next field must be 4 bytes, even though flags is only 1 byte */ + { + /* rte_flags */ + .type = RTE_ACL_FIELD_TYPE_BITMASK, + .size = sizeof(uint32_t), + .field_index = TCP_FLAGS_FIELD, + .input_index = TCP_FLAGS_INDEX, + .offset = sizeof(struct rte_ether_hdr) + + sizeof(struct rte_ipv4_hdr) + + offsetof(struct rte_tcp_hdr, tcp_flags), + }, }; /* flow classify data */ @@ -272,12 +286,14 @@ lcore_main(struct flow_classifier *cls_app) int ret; int i = 0; - ret = rte_flow_classify_table_entry_delete(cls_app->cls, - rules[7]); - if (ret) - printf("table_entry_delete failed [7] %d\n\n", ret); - else - printf("table_entry_delete succeeded [7]\n\n"); + if (rules[7]) { + ret = rte_flow_classify_table_entry_delete(cls_app->cls, + rules[7]); + if (ret) + printf("table_entry_delete failed [7] %d\n\n", ret); + else + printf("table_entry_delete succeeded [7]\n\n"); + } /* * Check that the port is on the same NUMA node as the polling thread @@ -395,6 +411,53 @@ parse_ipv4_net(char *in, uint32_t *addr, uint32_t *mask_len) return 0; } +static int +get_tcp_flags(char *in, struct rte_eth_ntuple_filter *ntuple_filter) +{ + int len = strlen(in); + int i; + uint8_t flags = 0; + + if (strcmp(in, "*") == 0) { + ntuple_filter->tcp_flags = 0; + return 0; + } + + for (i = 0; i < len; i++) { + switch (in[i]) { + case 'S': + flags |= RTE_TCP_SYN_FLAG; + break; + case 'F': + flags |= RTE_TCP_FIN_FLAG; + break; + case 'R': + flags |= RTE_TCP_RST_FLAG; + break; + case 'P': + flags |= RTE_TCP_PSH_FLAG; + break; + case 'A': + flags |= RTE_TCP_ACK_FLAG; + break; + case 'U': + flags |= RTE_TCP_URG_FLAG; + break; + case 'E': + flags |= RTE_TCP_ECE_FLAG; + break; + case 'C': + flags |= RTE_TCP_CWR_FLAG; + break; + default: + fprintf(stderr, "unknown flag %c\n", in[i]); + return -1; + } + } + ntuple_filter->tcp_flags = flags; + return 0; +} + static int parse_ipv4_5tuple_rule(char *str, struct rte_eth_ntuple_filter *ntuple_filter) { @@ -424,7 +487,7 @@ parse_ipv4_5tuple_rule(char *str, struct rte_eth_ntuple_filter *ntuple_filter) &ntuple_filter->dst_ip, &ntuple_filter->dst_ip_mask); if (ret != 0) { - flow_classify_log("failed to read source address/mask: %s\n", + flow_classify_log("failed to read ssourceource address/mask: %s\n", in[CB_FLD_DST_ADDR]); return ret; } @@ -466,6 +529,8 @@ parse_ipv4_5tuple_rule(char *str, struct rte_eth_ntuple_filter *ntuple_filter) ntuple_filter->priority = (uint16_t)temp; if (ntuple_filter->priority > FLOW_CLASSIFY_MAX_PRIORITY) ret = -EINVAL; + if (get_tcp_flags(in[CB_FLD_TCP_FLAGS], ntuple_filter)) + return -EINVAL; return ret; } @@ -582,10 +647,13 @@ add_classify_rule(struct rte_eth_ntuple_filter *ntuple_filter, memset(&tcp_spec, 0, sizeof(tcp_spec)); tcp_spec.hdr.src_port = ntuple_filter->src_port; tcp_spec.hdr.dst_port = ntuple_filter->dst_port; + tcp_spec.hdr.tcp_flags = ntuple_filter->tcp_flags; memset(&tcp_mask, 0, sizeof(tcp_mask)); tcp_mask.hdr.src_port = ntuple_filter->src_port_mask; tcp_mask.hdr.dst_port = ntuple_filter->dst_port_mask; + if (tcp_spec.hdr.tcp_flags != 0) + tcp_mask.hdr.tcp_flags = 0xff; tcp_item.type = RTE_FLOW_ITEM_TYPE_TCP; tcp_item.spec = &tcp_spec; @@ -640,6 +708,10 @@ add_classify_rule(struct rte_eth_ntuple_filter *ntuple_filter, return ret; } + /* XXX but this only adds table_type of RTE_FLOW_CLASSIFY_TABLE_ACL_IP4_5TUPLE + * i.e., it only ever does allocate_acl_ipv4_5tuple_rule() so the tcp_flags is + * ignored! + */ rule = rte_flow_classify_table_entry_add( cls_app->cls, &attr, pattern_ipv4_5tuple, actions, &key_found, &error); diff --git a/examples/flow_classify/ipv4_rules_file.txt b/examples/flow_classify/ipv4_rules_file.txt index dfa0631fc..415573732 100644 --- a/examples/flow_classify/ipv4_rules_file.txt +++ b/examples/flow_classify/ipv4_rules_file.txt @@ -1,14 +1,14 @@ #file format: -#src_ip/masklen dst_ip/masklen src_port : mask dst_port : mask proto/mask priority +#src_ip/masklen dst_ip/masklen src_port : mask dst_port : mask proto/mask priority tcp_flags # -2.2.2.3/24 2.2.2.7/24 32 : 0xffff 33 : 0xffff 17/0xff 0 -9.9.9.3/24 9.9.9.7/24 32 : 0xffff 33 : 0xffff 17/0xff 1 -9.9.9.3/24 9.9.9.7/24 32 : 0xffff 33 : 0xffff 6/0xff 2 -9.9.8.3/24 9.9.8.7/24 32 : 0xffff 33 : 0xffff 6/0xff 3 -6.7.8.9/24 2.3.4.5/24 32 : 0x0000 33 : 0x0000 132/0xff 4 -6.7.8.9/32 192.168.0.36/32 10 : 0xffff 11 : 0xffff 6/0xfe 5 -6.7.8.9/24 192.168.0.36/24 10 : 0xffff 11 : 0xffff 6/0xfe 6 -6.7.8.9/16 192.168.0.36/16 10 : 0xffff 11 : 0xffff 6/0xfe 7 -6.7.8.9/8 192.168.0.36/8 10 : 0xffff 11 : 0xffff 6/0xfe 8 +2.2.2.3/24 2.2.2.7/24 32 : 0xffff 33 : 0xffff 17/0xff 0 * +9.9.9.3/24 9.9.9.7/24 32 : 0xffff 33 : 0xffff 17/0xff 1 * +9.9.9.3/24 9.9.9.7/24 32 : 0xffff 33 : 0xffff 6/0xff 2 * +9.9.8.3/24 9.9.8.7/24 32 : 0xffff 33 : 0xffff 6/0xff 3 * +6.7.8.9/24 2.3.4.5/24 32 : 0x0000 33 : 0x0000 132/0xff 4 * +6.7.8.9/32 192.168.0.36/32 10 : 0xffff 11 : 0xffff 6/0xfe 5 * +6.7.8.9/24 192.168.0.36/24 10 : 0xffff 11 : 0xffff 6/0xfe 6 * +6.7.8.9/16 192.168.0.36/16 10 : 0xffff 11 : 0xffff 6/0xfe 7 * +6.7.8.9/8 192.168.0.36/8 10 : 0xffff 11 : 0xffff 6/0xfe 8 * #error rules -#9.8.7.6/8 192.168.0.36/8 10 : 0xffff 11 : 0xffff 6/0xfe 9 \ No newline at end of file +#9.8.7.6/8 192.168.0.36/8 10 : 0xffff 11 : 0xffff 6/0xfe 9 * -- 2.20.1