Re: [dpdk-dev] [PATCH v2 5/6] usertools/setup: fix loading vfio module

[Thomas Monjalon <thomas@monjalon.net>]

27/11/2020 10:55, Ferruh Yigit:
> On 11/26/2020 6:31 PM, David Marchand wrote:
> > On Thu, Nov 26, 2020 at 3:20 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> >>
> >> script is checking the existing of the kernel module file, but in some
> >> distros kernel modules are stored compressed, like as 'vfio-pci.ko.xz'.
> > 
> > Since this script expects modprobe to be installed (coming with kmod
> > tools), it means modinfo is available.
> > Checking for module availability should be "modinfo vfio-pci".
> > 
> 
> +1, that is definitely better.
> 
> I can send a new version with it if we decide to keep the script.

It is too late to improve this old script.
We should let it die and rest in peace.

> Mainly we are tying to decide to remove the script or keep with the changes in 
> this set.

I appreciate your effort Ferruh.
It shows that almost nothing is worth to keep in this script.

> There aren't still much comment on it, only comment by you in favor of removal, 
> I haven't seen any comment to keep the script.
> 
> Added more folks for comment, also techboard comments are welcome.

My opinion is that we should follow the deprecation notice
and remove the script in 20.11.
If someone wants to keep the same VFIO manipulations,
it is possible to copy/paste from old versions.