From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBCFBA053D; Wed, 5 Aug 2020 18:26:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95BB02BF2; Wed, 5 Aug 2020 18:26:59 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id 34799E07 for ; Wed, 5 Aug 2020 18:26:58 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 489C95800CF; Wed, 5 Aug 2020 12:26:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 05 Aug 2020 12:26:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= vKt8xAGpHvhXIvXOI+RFzsHEM8SSxvm7d4zE3QTcs/U=; b=Tcm9/m38N7nd5DB3 RIvoEhNTinOrswI/x271no6dYQ9H2pHEYYslXT7JkOG4Mrt2wpURp9xWqoeNNYuw WRFcepCWIPe+BiUG4RUn79OgszCK4T3gq8IqgjWbf4fWMFoMD81qjW9OZ/SKH5kd caOQ3MwnBZby3Yx4Hcogwy8KKqJXrX2OTFSgUGzO/8ef7jGFbXkhWsbLgXjL2lOV HX95U594a4ziy7FeZAgNMsfLOS1X7fTbizv+hCsUkzS74TNMxOFchJ5uvm5JwPdI tQwp0tC5urVlRn33yeM7i2q5nYRBGmEkm4/qGPzMLkfbHXrBtndL0+gVJafqm8f/ JKwk2g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=vKt8xAGpHvhXIvXOI+RFzsHEM8SSxvm7d4zE3QTcs /U=; b=TRgmF8Gmp2T4yzN75pMTfJ8h8Pit9l4R9An7SRhWjF3WTcN4B95yipJjF pygRRri7E1SlNWEJbW/2Xw70oRfCllHWIt2LYTSPHUFW/9guLf4P1LSR4Q6xQuMQ ZguozHsQfd8zmLsjMXbCV3ANrmRJCCadqQBLKjKZl4WAHobpVQ7EH7buMyAMVU/D BQbBRanZC9eIKLng9/EyKXOSsKpPR6s6wM5VAUe0xOwE0uCb9l75K0W7007a38mR FS6BVVFe+Bx5pahZZn8OUYKoBVNE0IDPsjavup6hIZKeROUOYlCwyfKCCnMQlu4V uSRgRG7NONIAwsCle1IpTDex3x3HA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrjeekgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 76881328005A; Wed, 5 Aug 2020 12:26:53 -0400 (EDT) From: Thomas Monjalon To: Ferruh Yigit Cc: dev@dpdk.org, david.marchand@redhat.com, arybchenko@solarflare.com, bruce.richardson@intel.com, stephen@networkplumber.org, ajit.khaparde@broadcom.com, jerinj@marvell.com, maxime.coquelin@redhat.com, akhil.goyal@nxp.com, bluca@debian.org, ktraynor@redhat.com, honnappa.nagarahalli@arm.com Date: Wed, 05 Aug 2020 18:26:52 +0200 Message-ID: <8050069.tTueApQPhr@thomas> In-Reply-To: <4a9e1a7e-a637-e601-487f-793fc68bb095@intel.com> References: <20200804102643.3345674-1-thomas@monjalon.net> <4a9e1a7e-a637-e601-487f-793fc68bb095@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] doc: announce removal of interactive setup script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/08/2020 18:19, Ferruh Yigit: > On 8/4/2020 11:26 AM, Thomas Monjalon wrote: > > Environment configuration is the responsibility of distributions > > or upper-level frameworks. > > DPDK focus on documenting the requirements and some recommendations. > > > > Maintaining a good adaptative deployment setup is a project by itself. > > Anyway this script was interactive, useful only for experimenters. > > > > Signed-off-by: Thomas Monjalon > > --- > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index ea4cfa7a48..7ce9fc3e4f 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -151,3 +151,7 @@ Deprecation Notices > > Python 2 support will be completely removed in 20.11. > > In 20.08, explicit deprecation warnings will be displayed when running > > scripts with Python 2. > > + > > +* dpdk-setup.sh: This old script relies on deprecated stuff, and especially > > + ``make``. Given environments are too much variables for such a simple script, > > + it will be removed in DPDK 20.11. > > > > Personally I use script as a shortcut to allocate hugemaps, and find that bit > useful. > > Agree that the environment configuration or deployment script is something else, > and not sure if this script ever claimed to be one, it is more a user helper > script I think. > > What do you think remove the build part, which depends to Make build system as > mentioned above, and keep the rest as a helper script (and perhaps rename to > highlight the intention), so basically keep only below part: > > ---------------------------------------------------------- > Step 2: Setup linux environment > ---------------------------------------------------------- > [45] Insert IGB UIO module > [46] Insert VFIO module It does not cover other kernel modules. > [47] Insert KNI module > [48] Setup hugepage mappings for non-NUMA systems > [49] Setup hugepage mappings for NUMA systems It does not use the standard hugepage directory. > [50] Display current Ethernet/Baseband/Crypto device settings > [51] Bind Ethernet/Baseband/Crypto device to IGB UIO module > [52] Bind Ethernet/Baseband/Crypto device to VFIO module These are just calling another script in usertools. > [53] Setup VFIO permissions > > ---------------------------------------------------------- > Step 4: Other tools > ---------------------------------------------------------- > [56] List hugepage info from /proc/meminfo > > ---------------------------------------------------------- > Step 5: Uninstall and system cleanup > ---------------------------------------------------------- > [57] Unbind devices from IGB UIO or VFIO driver > [58] Remove IGB UIO module > [59] Remove VFIO module > [60] Remove KNI module > [61] Remove hugepage mappings This script has bad quality and is very partial. Are we sure we want to keep above parts? What about adding separate scripts for VFIO permissions or hugepage mapping and info?