From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DB88A09D9; Wed, 11 Nov 2020 16:03:57 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D4BC137D; Wed, 11 Nov 2020 16:03:56 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id DAFC4F90 for ; Wed, 11 Nov 2020 16:03:53 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id 33so2830943wrl.7 for ; Wed, 11 Nov 2020 07:03:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=ddNpkrz1GYfAR06N919TTT0WpDfagSfd1Ky2lPqA2js=; b=pK8A86uolaWU+IE5wO148eRHy1/a/hA6NVBNo8HgN7YbuAQk2aC5Ljs6qIjE2CLOsD rHVir6UNj/BfU+KJPHbk3TauUPEX45AbsEmQu7eoTy37z6ipVOUKA6O10j0D6KMgNnon FFXolQlfnN4frr2EtpBt6mUD+lkUVNSmIVO7bVwcbLnyrivYnPnG6fHYWBFTAQXtJgen X/7drBhGfZIDuCX6NzYvYjP43B62I+uNdFjfOY652hS06fFzU+dubi+3APUdwk2zX7Os RsFFcPC0bHcg2UllcsrkVrYSSah8ysrb0SZm/4bLTrrgJxrqfgJRVqMbZe2f0giweJ3w LqMA== X-Gm-Message-State: AOAM531uJnVtRqXtdtPk9hDhXfAnoyYMEFhqJqOO8ZCRbomynFCcygEM 2YQiN0Kb1DtURpyhZob7D14= X-Google-Smtp-Source: ABdhPJyGNDaiOH/SFsYUCaIAtoo/+kQXD1+zN/GI4+d4qJ8tryMA7FmzXsh23n/60y21WaNlZYflWg== X-Received: by 2002:adf:f40a:: with SMTP id g10mr32330046wro.58.1605107033613; Wed, 11 Nov 2020 07:03:53 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id w1sm2534351wmi.24.2020.11.11.07.03.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 07:03:52 -0800 (PST) Message-ID: <805419dbc589b31f01e8864004a5c2a59dfd6e78.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon , Dmitry Kozlyuk Cc: dev@dpdk.org, Narcisa Ana Maria Vasile , John Alexander Date: Wed, 11 Nov 2020 15:03:52 +0000 In-Reply-To: <3042169.36grohAEOo@thomas> References: <20201029225505.30093-1-dmitry.kozliuk@gmail.com> <3042169.36grohAEOo@thomas> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [kmods PATCH] windows: normalize line-endings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2020-11-11 at 16:02 +0100, Thomas Monjalon wrote: > 29/10/2020 23:55, Dmitry Kozlyuk: > > MSBuild XML files have to use CRLF line-endings, otherwise any change > > results in the whole file being rewritten with CRLF line-endings by > > Visual Studio. However, it's inconvenient to have such files checked-ou= t > > with CLRF in Unix environments. > >=20 > > Add suggested git configuration to top-level README, so that Unix > > developers don't miss it. Remove .gitattributes, because core.autocrlf > > overrides eol=3D attribute. Convert line-endings of the existing files = in > > the repository. >=20 > It is converted to what? > You mean all files should have LF endings in the repo? >=20 > [...] > > windows/virt2phys/virt2phys.sln | 54 ++-- > > windows/virt2phys/virt2phys.vcxproj | 454 ++++++++++++++-------------- > > 4 files changed, 259 insertions(+), 258 deletions(-) >=20 > The file windows/virt2phys/virt2phys.vcxproj.filters is not converted. > And I see other stuff to fix, see below. >=20 > > +Some Windows files use have to use CRLF line-endings. >=20 > "use have to use" -> "have to use" ? >=20 > Isn't it automatic to have CRLF on Windows git working tree? >=20 > > +Unix developers can configure git to get only LF on checkout: > > + > > + git config core.autocrlf input >=20 > Isn't it the default? > If all files have LF, there is nothing to do on Unix. >=20 >=20 > I think more fixes are required as below: <..> Yes, I second that - those changes are needed too. --=20 Kind regards, Luca Boccassi