DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org, bruce.richardson@intel.com,
	Qi Zhang <qi.z.zhang@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal: initialize alarms early
Date: Tue, 02 Apr 2019 15:01:14 +0200	[thread overview]
Message-ID: <8055087.Rpa7nGxINI@xps> (raw)
In-Reply-To: <20190401141814.8096-1-dariusz.stojaczyk@intel.com>

01/04/2019 16:18, Darek Stojaczyk:
> On linux, we currently initialize rte_alarms after
> starting to listen for IPC hotplug requests, which gives
> us a data race window. Upon receiving such hotplug
> request we always try to set an alarm and this obviously
> doesn't work if the alarms weren't initialized yet.
> 
> To fix it, we initialize alarms before starting to
> listen for IPC hotplug messages. Specifically, we move
> rte_eal_alarm_init() right after rte_eal_intr_init() as
> it makes some sense to keep those two close to each other.
> 
> We update the bsd code as well to keep the initialization
> order the same in both eal implementations.
> 
> Fixes: 244d5130719c ("eal: enable hotplug on multi-process")
> Cc: Qi Zhang <qi.z.zhang@intel.com>
> Cc: Anatoly Burakov <anatoly.burakov@intel.com>
> Cc: stable@dpdk.org
> 
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> ---
> v2:
>  - updated the bsd code as well (Thomas)

Applied, thanks

  parent reply	other threads:[~2019-04-02 13:01 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-26 18:43 [dpdk-dev] [PATCH] " Darek Stojaczyk
2019-03-26 18:43 ` Darek Stojaczyk
2019-03-27 18:11 ` Thomas Monjalon
2019-03-27 18:11   ` Thomas Monjalon
2019-03-27 20:33   ` Stojaczyk, Dariusz
2019-03-27 20:33     ` Stojaczyk, Dariusz
2019-03-27 22:42     ` Thomas Monjalon
2019-03-27 22:42       ` Thomas Monjalon
2019-03-28 10:43       ` Bruce Richardson
2019-03-28 10:43         ` Bruce Richardson
2019-03-28 10:46         ` Thomas Monjalon
2019-03-28 10:46           ` Thomas Monjalon
2019-03-28 13:14           ` Burakov, Anatoly
2019-03-28 13:14             ` Burakov, Anatoly
2019-04-01 14:22     ` Stojaczyk, Dariusz
2019-04-01 14:22       ` Stojaczyk, Dariusz
2019-04-01 14:18 ` [dpdk-dev] [PATCH v2] " Darek Stojaczyk
2019-04-01 14:18   ` Darek Stojaczyk
2019-04-02 13:01   ` Thomas Monjalon [this message]
2019-04-02 13:01     ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8055087.Rpa7nGxINI@xps \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dariusz.stojaczyk@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).