From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 0F0792C36; Tue, 2 Apr 2019 15:01:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A6F15222B2; Tue, 2 Apr 2019 09:01:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 09:01:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Kxn6shYrK4sSpb9lsTVzsFcNfaciU38r3O0+pp9xJAQ=; b=fvz9EiYiNm3P WFhUzU6K5ZfyXbOdRG36+tbPL+QSrtLSvdM01X1fG9GRzaKYuzFbocilTqzqcnJ5 GpCf4rCTxq08norayS61iuAFZDhHwL3TQpVAYgshDqwNmGgHmcEZK03NDsyTsF9F taswNunrj5xe7o04XaDjMv8cx069QzA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Kxn6shYrK4sSpb9lsTVzsFcNfaciU38r3O0+pp9xJ AQ=; b=LC40zKVUz3eh6ZxgUddiTg2WwU8DHdM1VYilikNR0UnsBACOaI3FxfJF1 /C54OIsy48JOVENZQNi6MaI4kNIFT9cvzzgWNvgfXRJrjUBivdFq/mW+L4q+eGvN qmEajn0OIlLFF0ASg0hzd9Kwd3xiYuKrc7FwxjwX9m7xpVVEtJ2io7L5bXHfJK3a vNRFkcFSBP68ZYCOTpRldOsCoZr5ZAJsK+sX+/FnQi0bJm7YwvYMud6ruflEBOn5 Kq0JksqQv6FHUY8K54TlXrkRsZNdfMmR1GpcHCQozx4TbZcsTfH9XIj2mTt70LBx U4ShDmzY40msPcSjrr9lQS6QxRFeQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgdefleculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 69655E4807; Tue, 2 Apr 2019 09:01:16 -0400 (EDT) From: Thomas Monjalon To: Darek Stojaczyk Cc: stable@dpdk.org, dev@dpdk.org, bruce.richardson@intel.com, Qi Zhang , Anatoly Burakov Date: Tue, 02 Apr 2019 15:01:14 +0200 Message-ID: <8055087.Rpa7nGxINI@xps> In-Reply-To: <20190401141814.8096-1-dariusz.stojaczyk@intel.com> References: <20190326184331.13850-1-dariusz.stojaczyk@intel.com> <20190401141814.8096-1-dariusz.stojaczyk@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal: initialize alarms early X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 13:01:19 -0000 01/04/2019 16:18, Darek Stojaczyk: > On linux, we currently initialize rte_alarms after > starting to listen for IPC hotplug requests, which gives > us a data race window. Upon receiving such hotplug > request we always try to set an alarm and this obviously > doesn't work if the alarms weren't initialized yet. > > To fix it, we initialize alarms before starting to > listen for IPC hotplug messages. Specifically, we move > rte_eal_alarm_init() right after rte_eal_intr_init() as > it makes some sense to keep those two close to each other. > > We update the bsd code as well to keep the initialization > order the same in both eal implementations. > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process") > Cc: Qi Zhang > Cc: Anatoly Burakov > Cc: stable@dpdk.org > > Signed-off-by: Darek Stojaczyk > --- > v2: > - updated the bsd code as well (Thomas) Applied, thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D1A70A0679 for ; Tue, 2 Apr 2019 15:01:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 000B5316B; Tue, 2 Apr 2019 15:01:20 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 0F0792C36; Tue, 2 Apr 2019 15:01:19 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A6F15222B2; Tue, 2 Apr 2019 09:01:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 02 Apr 2019 09:01:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Kxn6shYrK4sSpb9lsTVzsFcNfaciU38r3O0+pp9xJAQ=; b=fvz9EiYiNm3P WFhUzU6K5ZfyXbOdRG36+tbPL+QSrtLSvdM01X1fG9GRzaKYuzFbocilTqzqcnJ5 GpCf4rCTxq08norayS61iuAFZDhHwL3TQpVAYgshDqwNmGgHmcEZK03NDsyTsF9F taswNunrj5xe7o04XaDjMv8cx069QzA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=Kxn6shYrK4sSpb9lsTVzsFcNfaciU38r3O0+pp9xJ AQ=; b=LC40zKVUz3eh6ZxgUddiTg2WwU8DHdM1VYilikNR0UnsBACOaI3FxfJF1 /C54OIsy48JOVENZQNi6MaI4kNIFT9cvzzgWNvgfXRJrjUBivdFq/mW+L4q+eGvN qmEajn0OIlLFF0ASg0hzd9Kwd3xiYuKrc7FwxjwX9m7xpVVEtJ2io7L5bXHfJK3a vNRFkcFSBP68ZYCOTpRldOsCoZr5ZAJsK+sX+/FnQi0bJm7YwvYMud6ruflEBOn5 Kq0JksqQv6FHUY8K54TlXrkRsZNdfMmR1GpcHCQozx4TbZcsTfH9XIj2mTt70LBx U4ShDmzY40msPcSjrr9lQS6QxRFeQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtddtgdefleculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgepud X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 69655E4807; Tue, 2 Apr 2019 09:01:16 -0400 (EDT) From: Thomas Monjalon To: Darek Stojaczyk Cc: stable@dpdk.org, dev@dpdk.org, bruce.richardson@intel.com, Qi Zhang , Anatoly Burakov Date: Tue, 02 Apr 2019 15:01:14 +0200 Message-ID: <8055087.Rpa7nGxINI@xps> In-Reply-To: <20190401141814.8096-1-dariusz.stojaczyk@intel.com> References: <20190326184331.13850-1-dariusz.stojaczyk@intel.com> <20190401141814.8096-1-dariusz.stojaczyk@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] eal: initialize alarms early X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402130114.6VvhLU_ufRn_Hy_vg74xLxuZNECiRoyOsvEpfbVAAgs@z> 01/04/2019 16:18, Darek Stojaczyk: > On linux, we currently initialize rte_alarms after > starting to listen for IPC hotplug requests, which gives > us a data race window. Upon receiving such hotplug > request we always try to set an alarm and this obviously > doesn't work if the alarms weren't initialized yet. > > To fix it, we initialize alarms before starting to > listen for IPC hotplug messages. Specifically, we move > rte_eal_alarm_init() right after rte_eal_intr_init() as > it makes some sense to keep those two close to each other. > > We update the bsd code as well to keep the initialization > order the same in both eal implementations. > > Fixes: 244d5130719c ("eal: enable hotplug on multi-process") > Cc: Qi Zhang > Cc: Anatoly Burakov > Cc: stable@dpdk.org > > Signed-off-by: Darek Stojaczyk > --- > v2: > - updated the bsd code as well (Thomas) Applied, thanks