From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 52AA71396 for ; Tue, 21 Mar 2017 15:53:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490108013; x=1521644013; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=TMjYaJ+AaA/ruN4xnS3MCfXLV7QNawXwryPJ9IK43Zk=; b=c7ZFBMdLcpfi2zf89ChXL725I1/0+F13nCqy6kbnpERGd52w+fS4zxJj tAaw1NLUEDVpinXCSL69Efd8QQtpbQ==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Mar 2017 07:53:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,198,1486454400"; d="scan'208";a="79428235" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 21 Mar 2017 07:53:29 -0700 To: Jerin Jacob References: <1490019040-6268-1-git-send-email-jerin.jacob@caviumnetworks.com> <20170321143832.swnf7xetxlxc3k5w@localhost.localdomain> Cc: dev@dpdk.org From: Ferruh Yigit Message-ID: <8059571c-9747-ca33-0d61-f453e43afa48@intel.com> Date: Tue, 21 Mar 2017 14:53:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170321143832.swnf7xetxlxc3k5w@localhost.localdomain> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/thunderx: sync mailbox definitions with Linux PF driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Mar 2017 14:53:33 -0000 On 3/21/2017 2:38 PM, Jerin Jacob wrote: > On Tue, Mar 21, 2017 at 02:31:41PM +0000, Ferruh Yigit wrote: >> On 3/20/2017 2:10 PM, Jerin Jacob wrote: >>> - bgx_link_status mbox definition was changed in Linux >>> commit 1cc702591bae ("net: thunderx: Add ethtool support") >>> - NIC_MBOX_MSG_RES_BIT related changes were never part of Linux PF driver >>> >>> Signed-off-by: Jerin Jacob >> >> <...> >> >>> @@ -157,6 +151,7 @@ struct rss_cfg_msg { >>> /* Physical interface link status */ >>> struct bgx_link_status { >>> uint8_t msg; >>> + uint8_t mac_type; >> >> Hi Jerin, >> >> Is this modification related to this patch? > > Yes Ferruh. > > This was related to the following section in git log comment. > ---- > - bgx_link_status mbox definition was changed in Linux > commit 1cc702591bae ("net: thunderx: Add ethtool support") > --- I see now, thanks. Since this is to sync with Linux PF, shouldn't it be used in driver, perhaps something like in Linux driver: "nic->mac_type = mbx.link_status.mac_type" What is the point of just adding definition without using it? > > >> >>> uint8_t link_up; >>> uint8_t duplex; >>> uint32_t speed; >>> >>