From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B3FAAA04F3;
	Fri,  3 Jan 2020 09:22:26 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id E3CCC1C2A5;
	Fri,  3 Jan 2020 09:22:25 +0100 (CET)
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com
 [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 7999F1C2A3
 for <dev@dpdk.org>; Fri,  3 Jan 2020 09:22:24 +0100 (CET)
Received: by mail-wr1-f67.google.com with SMTP id z3so41656395wru.3
 for <dev@dpdk.org>; Fri, 03 Jan 2020 00:22:24 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc
 :content-transfer-encoding:message-id:references:to;
 bh=vaVkKxZry6/LLRvxGGSuWiKnbkuHAxq1RYtehmuck0A=;
 b=OpQzVtkrCMQZNieB+DB1MeCm9eQBE5+ZQ5RwlxW0R+BxoM23MC9W7hWubqF+wQbtss
 DSYhl6mxZAnAqgN6e2WVKgCxS6CSUjs52g/JtF6mTc8MnGKiKVKVlQQ3i0DE3LitJPnd
 AzDvBAoSoI3//nuJUxw5bRYMK1UIJXdN8pEJxYaSWp33vbSfd8k54dxbQbjCAkA9GB3Z
 Ha17Ec+fSIIDHfbqLXMRJYpT1aQm/aTE/ewKQuNwSGou6dNZAvQXc5+QklslOdUCTWgP
 +66aoz5kOzJBRIJZxgVRwNinydkY4jt99QKlJ9NBYaQ82GFJAwSBWHhtPoso4gme3nSM
 srWw==
X-Gm-Message-State: APjAAAUkoQm6htirLO610HOyYqRyRhw0TZGMMb1XPTne4kDL4RCVXYXH
 L34U2q69M9Q2ZxR79j6DU3vl59CE
X-Google-Smtp-Source: APXvYqyJESXYBUSw3Lo5kv6JCbOlyp9YJa2ilmWppnsZ6B+GMFeK+MT4UurdVlqnffffU0dHaPiOOg==
X-Received: by 2002:adf:b60f:: with SMTP id f15mr82032036wre.372.1578039744150; 
 Fri, 03 Jan 2020 00:22:24 -0800 (PST)
Received: from [192.168.1.108] ([94.164.189.169])
 by smtp.gmail.com with ESMTPSA id 2sm61123890wrq.31.2020.01.03.00.22.22
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 03 Jan 2020 00:22:23 -0800 (PST)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.40.2.2.4\))
From: Alfredo Cardigliano <cardigliano@ntop.org>
In-Reply-To: <20191219161645.7309a690@hermes.lan>
Date: Fri, 3 Jan 2020 09:22:20 +0100
Cc: dev@dpdk.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <805A07B7-E29C-4451-9EE6-2DDD6F56AC2D@ntop.org>
References: <20191219221847.29989-1-cardigliano@ntop.org>
 <20191219221847.29989-3-cardigliano@ntop.org>
 <20191219161645.7309a690@hermes.lan>
To: Stephen Hemminger <stephen@networkplumber.org>
X-Mailer: Apple Mail (2.3608.40.2.2.4)
Subject: Re: [dpdk-dev] [PATCH v4 02/17] net/ionic: add hardware structures
 definitions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


> On 20 Dec 2019, at 01:16, Stephen Hemminger =
<stephen@networkplumber.org> wrote:
>=20
> On Thu, 19 Dec 2019 23:18:32 +0100
> Alfredo Cardigliano <cardigliano@ntop.org> wrote:
>=20
>> +
>> +#pragma pack(push, 1)
>> +
>=20
> Really, packing leads to unaligned data structures and is generally
> a bad idea.


This specific file defines data structures shared with the adapter (and =
other OS drivers)
thus any additional padding should be avoided. Actually the pragma is =
unnecessary=20
here, as who wrote this file worked pretty hard tweaking the structs by =
hand to be sure
that they are all formed such that the fields are on their appropriate =
byte boundaries=20
and all field padding is explicitly defined.

Alfredo=