From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C99C2A034F; Mon, 22 Feb 2021 10:56:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 54AF340041; Mon, 22 Feb 2021 10:56:31 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 7D54B4003C; Mon, 22 Feb 2021 10:56:29 +0100 (CET) IronPort-SDR: iPsK1WBmU+7rlrvCO80kM2C43EBfXPNL6tdJJyLHxtN/OlGdi5/nv0ifyyjmBLuBAlhKMxDF3Q WBDrq7VhZr0w== X-IronPort-AV: E=McAfee;i="6000,8403,9902"; a="171528130" X-IronPort-AV: E=Sophos;i="5.81,196,1610438400"; d="scan'208";a="171528130" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2021 01:56:28 -0800 IronPort-SDR: cO3MXXoV37j5G82ijf3hzWxDLNKLF9gb3MaFiKqqN19WA72Mf57N7rlI9MEtxZnS8QP/xgzqXu tsvsLai589IQ== X-IronPort-AV: E=Sophos;i="5.81,196,1610438400"; d="scan'208";a="402512763" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.232.118]) ([10.213.232.118]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2021 01:56:26 -0800 To: David Hunt , dev@dpdk.org Cc: stable@dpdk.org, Bruce Richardson , Anatoly Burakov , David Marchand , Thomas Monjalon References: <20210120135556.33763-2-david.hunt@intel.com> <20210121172201.22582-1-david.hunt@intel.com> <20210121172201.22582-4-david.hunt@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <8069b0fd-ec8f-4d80-4053-9a230725cdba@intel.com> Date: Mon, 22 Feb 2021 09:56:25 +0000 MIME-Version: 1.0 In-Reply-To: <20210121172201.22582-4-david.hunt@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4 3/6] power: rename public structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/21/2021 5:21 PM, David Hunt wrote: > From: Bruce Richardson > > rename the public structs to have an rte_power_ prefix and > add them to version.map in experimental section. > > Fixes: 210c383e247b ("power: packet format for vm power management") > Fixes: cd0d5547e873 ("power: vm communication channels in guest") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson > Signed-off-by: David Hunt > <...> > diff --git a/lib/librte_power/version.map b/lib/librte_power/version.map > index 69ca9af61..13f0af3b2 100644 > --- a/lib/librte_power/version.map > +++ b/lib/librte_power/version.map > @@ -34,4 +34,8 @@ EXPERIMENTAL { > rte_power_guest_channel_receive_msg; > rte_power_poll_stat_fetch; > rte_power_poll_stat_update; > + > + # added in 21.02 > + rte_power_guest_channel_receive_msg; > + rte_power_guest_channel_send_msg; > }; These two new symbols are already in the .map file, which is causing a build error [1], need to remove the duplicate. And one of the above symbols is already in the non-experimental section, I guess that was a mistake but just to double check, we are not downgrading an existing mature API to experimental API, right? [1] https://travis-ci.com/github/ovsrobot/dpdk/jobs/484119344