Re: [dpdk-dev] [PATCH v2] ifpga/base/meson: fix looking for librt

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 7/22/2021 9:16 AM, mohamad.noor.alim.hussin@intel.com wrote:
> From: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>
> 
> Finding with "librt" keyword would give the output with full path of librt such
> as /usr/lib/gcc/x86_64-linux-gnu/7/../../../x86_64-linux-gnu/librt.so
> instead of -lrt in libdpdk.pc pkg-config file.
> 
> Assume find_library() will prepend "lib", thus remove "lib" from "librt"
> keyword. The output will shows as -lrt.
> 
> This will cause an issue when compile DPDK app with static library as the
> path of librt has been hard-coded in the libdpdk.pc file.
> 
> Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in multi-process")
> Cc: tianfei.zhang@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Mohamad Noor Alim Hussin <mohamad.noor.alim.hussin@intel.com>

This patch is resent, because original patch was not in the patchwork as David
reminded.

But first patch already has acks, I am moving them here:

Acked-by: Tianfei Zhang <tianfei.zhang@intel.com>
(converted email address to all lowercase)

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Also I can produce the same, and patch looks good to me.


But it fails to apply clearly because of the white-space differences, and this
prevents CI running.

@Mohamad, can you please send a new version rebasing on top of latest code?
Please keep the acks above in the next version commit log, since the change will
be only white-space.

Thanks,
ferruh