From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id CDED8326B for ; Tue, 4 Apr 2017 16:50:03 +0200 (CEST) Received: by mail-wr0-f173.google.com with SMTP id w43so216447674wrb.0 for ; Tue, 04 Apr 2017 07:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=PfvtHY8VMbEKd+yS4nYJ/w1stdvpbH63Kz3YV8Q79HY=; b=sfZmzFlUdsFCG1pKg9XS4+p1uwiiJHm04gsQpp8hIhCo3GL5//1qWxvEb4Yf0A+FQG sPKyT7FVNRlbHQSzHUIaQ8ES3gf/fVrejMqth/hiweuPPJP/j+WT0XrJS+5onrEDiAIM lnbLqNCNiA1iwqVAHzDfytPXCceFWXl+zTsF7FTY5S87YjU5hLZoHq9dwgI9jaPVi0RG yV4AOZJgyfq+ZMcOM8H9KlgJEPKQutYotJ+VfLG00XOl7AV8sf/LmnzhtE8/wu2G7Xc+ bMRMm52kG4AnnxPS9PcOPPdJL1T3CMu6+6KEOHfd9yQqBNiySaFitU1XZzdq3yhPAslz WxAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=PfvtHY8VMbEKd+yS4nYJ/w1stdvpbH63Kz3YV8Q79HY=; b=Jn/zE5oebXszRmcquxEvpRPrYn/3f/9EhYd9JSrVorVqol4vtt6KD8msMUxZCX3XtI U4FSsKVjwYpfJRIzqHR/NCrIFygzotk3hNjgS16/tQfCXszlSCTFCS1zouo5GcX/IXOQ HNn12zF2CQD7/TF8W4PttQ0jWeVnyl7Oub4HZhp8mAQMQxvkMCIurSnzQF1g9tJ3tyBA 41yOoGvkpK/MZ9nGz0aTwZT9OiVSVPhNKt1bf+hcytDO17RGXySI+BbUJlm5IviiVqrF emWSrUUUk4HCjw3l9h8X0Z4Pp94mEYgSD+l3K95mGFyAK3G26IEaf9jcA8p9KFwEXabm g+kg== X-Gm-Message-State: AFeK/H0gzHCqL5X4okCpt/yDgANXahfLkcB7i8CBsLIh00eTYxwKuU/7IYOxccnh5/NyDB9p X-Received: by 10.223.151.217 with SMTP id t25mr21345078wrb.105.1491317403359; Tue, 04 Apr 2017 07:50:03 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id y43sm4633548wrd.62.2017.04.04.07.50.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 07:50:02 -0700 (PDT) From: Thomas Monjalon To: Qi Zhang Cc: dev@dpdk.org Date: Tue, 04 Apr 2017 16:50:01 +0200 Message-ID: <8091532.IGg7nCNBxL@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170404222732.981-1-qi.z.zhang@intel.com> References: <20170404212125.32114-1-qi.z.zhang@intel.com> <20170404222732.981-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 0/2] clean up interrupt handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 14:50:04 -0000 2017-04-05 06:27, Qi Zhang: > It seems its not necessary to register an intr_handle for interrupt callback > function. "void* cb_arg" shows enough when be used to pass the object that > contain the information be required to handle the interrupt event( A typical > way which is implemented by almost all driver is by passing a rte_ethdev > instance). > The patch change the prototype of rte_intr_callback_fn by removing > the uncessary intr_handle paramter. > > v5: > > - Update mlx4 driver which is missed in previous version. > > v4: > > - Update mlx5 driver which is missed in v1, v2, v3. > - Add back patch 1 of v2 to make this complete though it already be applied. > - Remove patch 3 which is not necessary with latest master. Why have you removed patch 3? There is this error now: test/test/test_interrupts.c:217:4: fatal error: incompatible pointer types passing 'void (struct rte_intr_handle *, void *)' to parameter of type 'rte_intr_callback_fn' (aka 'void (*)(void *)') [-Wincompatible-pointer-types] test_interrupt_callback, arg) >= 0) {