From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 72C11A034C; Thu, 1 Sep 2022 19:20:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 678C240C35; Thu, 1 Sep 2022 19:20:46 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2044.outbound.protection.outlook.com [40.107.220.44]) by mails.dpdk.org (Postfix) with ESMTP id 5C90640C35 for ; Thu, 1 Sep 2022 19:20:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DeRFrWndr166+xQbsrnPLODLtRPKOxusO/Nhkxc6VP6owqcsqFiV7MqtC6xK+aQjYP6HytB7SBDd9qLGL1Bhzr5ZPNBftiTRtG1NJogxRGVAgD5nFBTHxkBJTMYzsacVZKjBeJu+YbxYl6CtUXjFB8KWOnw0OwsQ5C85SDhlHVwOwPvTD54fFPvUWdNrtWOn0dYSkW8z2SdxkuIqKCILNZDbgaD0EoxoEoDFXrV5sGWi3PA3h2ibw0VL+oy+gHafoix+NPOacAb7d1Bp1oaNmehKkljbf0O/XL7AldGPGtK/8ZHxGy0DnB8H7ThxLnHFcNGCqrM3UsyPbpUuC0gA2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rUP1IDIvkR++0Myewfonntw1xWHb8+eVrxaWXhGnxn0=; b=K/jJmHKUl0Y+9Swe0tTqgp7JIhqbQok+cqauEnK9pGss7pFDlg27KSBaNKwfVzn78XnEFYcIuvOCSttFAhVZfkcas1CZ8irck7T6BdifbTS0ae06nwwMBOWeDVVbsOgf0xOLP4xvM1+IY5m3hV7iQFHU+QZV06t+En1qhZxbUKayidQFvl7IUr/ldiV0EQsZ7YkRZW+CM4u4HgJlDgle/Hb8lWFcq/46m3GLyUk57aRnkAy6R4VABccPcEDrLy3SYcEV69i95CyRTEObkQ8LiougG32ZaKvQ5uMoNVREU5i+ursDsGty3iY/2xdNnUGDYOwBgTdpg/sH6PQIudZpag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=intel.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rUP1IDIvkR++0Myewfonntw1xWHb8+eVrxaWXhGnxn0=; b=EkdmxIQ+tQQRwxYNR2VY5CthQ75teaCkNW+46mslMd8U4DCoGuo/HPIzMWXwyV0+fK8urEQZaqgRyZpHxhottL87rEzi08MozFUVQjp+p7GRanbVZKtjm/+Git17hwXOpeaeNkv9q15CQtyLFKF9hvuXQDQyVkzocwWehmd6ljg= Received: from SA9PR13CA0112.namprd13.prod.outlook.com (2603:10b6:806:24::27) by BN6PR02MB2419.namprd02.prod.outlook.com (2603:10b6:404:55::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.21; Thu, 1 Sep 2022 17:20:42 +0000 Received: from SN1NAM02FT0016.eop-nam02.prod.protection.outlook.com (2603:10b6:806:24:cafe::ea) by SA9PR13CA0112.outlook.office365.com (2603:10b6:806:24::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.6 via Frontend Transport; Thu, 1 Sep 2022 17:20:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by SN1NAM02FT0016.mail.protection.outlook.com (10.97.4.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Thu, 1 Sep 2022 17:20:42 +0000 Received: from xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 1 Sep 2022 18:20:41 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Thu, 1 Sep 2022 18:20:41 +0100 Envelope-to: junfeng.guo@intel.com, qi.z.zhang@intel.com, jingjing.wu@intel.com, dev@dpdk.org, xiaoyun.li@intel.com, awogbemila@google.com, bruce.richardson@intel.com, haiyue.wang@intel.com Received: from [10.71.194.74] (port=42357) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oTnrs-0008I6-Et; Thu, 01 Sep 2022 18:20:40 +0100 Message-ID: <809cd2ff-56d6-72e3-e689-30b512283ab9@xilinx.com> Date: Thu, 1 Sep 2022 18:20:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 02/10] net/gve: add logs and OS specific implementation Content-Language: en-US To: Junfeng Guo , , CC: , , , , Haiyue Wang References: <20220729193042.2764633-2-xiaoyun.li@intel.com> <20220829084127.934183-1-junfeng.guo@intel.com> <20220829084127.934183-3-junfeng.guo@intel.com> From: Ferruh Yigit In-Reply-To: <20220829084127.934183-3-junfeng.guo@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73ca5e5f-6b9d-4480-9991-08da8c3e4c79 X-MS-TrafficTypeDiagnostic: BN6PR02MB2419:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wJH5GZnIF3pbN0aO9hK6BQZW8Jc+7fqJllaUbmNUSSgarrY2egRpH08FjJZeVQXz7lEAJ23ijcb4Kt9ZZuzBl0TdNhsSoMkIVt0hkwo9dSfxYayiKeuApwF8TwOJex9Wxy5iz8h7gfPwKWUfy6amr7lnuXreDmiloHRtuf9BBJI39rG8e9XKEuhmktz5wp+WgTr8ZPkjtL2HHpGIkH/hRdYdjKF7wLVbk0ZtVaQnvuU5z1aypHQ3EcnPpuE1CsCNRnuroxDrrziAXL5UNOjDT8JISvCdJT/DFBf8ODVwmNPimsHqUoFIxtqJZi5s5JS+dyPJ/T2ScsEf1Cf3DgXYbqQjXpg/YOP17MiLFDI2Wp+F9zcPc/NlOPM5kyr8tCI6ZiPaRYjL9dvznYCOO9DHyNh3Lu+ukGOc0VS2BA17cksumeXiMSg53n62H01MNj4YCpiqCqKHgGv3zIq7mkEvYtbqMc0hYc5cHPe6LznCPjoDFIzbpCRdpeHN4yS9H/7Eh+lWhhfFZ7mdhylj/eu4nVZU86RO4v+Hn+OgB/4GOYVgPuzBlw6sFX9/IdVjEqICZQuXxXeXIcdkApbXia27gLmCxWxvFdiJmx6hgdVlCzKf4kmUEkr3H7NOAx4l1TC0YHwEwnV6BkwBWZRGkB0i7VhQUvRectRBZhsnFzgIEg0KpbAHrXhdjI1Ofq9QlToettSzt7ibttOaD1zQzHpuhZ1bUZYH7AaQSTyG52Sp4FGKOGldVbMAW/eYKei2329BFjXZCO2/GFOXqsZrMY0oyhAkZZh/B+w2t9+fL14+W8PUtnKQOoOulT8e4/WALp5Z X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(136003)(39860400002)(376002)(396003)(346002)(40470700004)(46966006)(36840700001)(31696002)(53546011)(36756003)(31686004)(336012)(36860700001)(2616005)(41300700001)(426003)(26005)(47076005)(186003)(110136005)(316002)(54906003)(40480700001)(82310400005)(70586007)(478600001)(70206006)(8676002)(40460700003)(9786002)(44832011)(7636003)(5660300002)(82740400003)(4326008)(356005)(2906002)(8936002)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 17:20:42.2901 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 73ca5e5f-6b9d-4480-9991-08da8c3e4c79 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT0016.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB2419 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/29/2022 9:41 AM, Junfeng Guo wrote: > > Add GVE PMD logs. > Add some MACRO definitions and memory operations which are specific > for DPDK. > > Signed-off-by: Haiyue Wang > Signed-off-by: Xiaoyun Li > Signed-off-by: Junfeng Guo <...> > diff --git a/drivers/net/gve/gve_logs.h b/drivers/net/gve/gve_logs.h > new file mode 100644 > index 0000000000..a050253f59 > --- /dev/null > +++ b/drivers/net/gve/gve_logs.h > @@ -0,0 +1,22 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(C) 2022 Intel Corporation > + */ > + > +#ifndef _GVE_LOGS_H_ > +#define _GVE_LOGS_H_ > + > +extern int gve_logtype_init; > +extern int gve_logtype_driver; > + > +#define PMD_INIT_LOG(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, gve_logtype_init, "%s(): " fmt "\n", \ > + __func__, ##args) > + > +#define PMD_DRV_LOG_RAW(level, fmt, args...) \ > + rte_log(RTE_LOG_ ## level, gve_logtype_driver, "%s(): " fmt, \ > + __func__, ## args) > + > +#define PMD_DRV_LOG(level, fmt, args...) \ > + PMD_DRV_LOG_RAW(level, fmt "\n", ## args) > + Why 'PMD_DRV_LOG_RAW' is needed, why not directly use 'PMD_DRV_LOG'? Do you really need two different log types? How do you differentiate 'init' & 'driver' types? As far as I can see there is mixed usage of them.