From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32E6342DE1; Thu, 6 Jul 2023 04:48:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 095A340144; Thu, 6 Jul 2023 04:48:29 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id D6D6B400D5 for ; Thu, 6 Jul 2023 04:48:26 +0200 (CEST) Received: from kwepemm600004.china.huawei.com (unknown [172.30.72.53]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4QxLWQ5pWzzPjwZ; Thu, 6 Jul 2023 10:46:10 +0800 (CST) Received: from [10.67.103.231] (10.67.103.231) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Thu, 6 Jul 2023 10:48:23 +0800 Message-ID: <80b5aa09-21a5-76ae-de86-c92bbbf31283@huawei.com> Date: Thu, 6 Jul 2023 10:48:23 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2] app/testpmd: fix invalid queue ID when start port To: Ferruh Yigit , Jie Hai CC: , , , "Mcnamara, John" , Qi Z Zhang , Yuying Zhang , Thomas Monjalon , Shiyang He , Aman Singh , "Jiale, SongX" , David Marchand , References: <20230703110232.28494-1-haijie1@huawei.com> <20230704084507.12788-1-haijie1@huawei.com> <29d89a6b-49e0-8789-411f-6a89db177b91@amd.com> <74fb4fc2-6497-0ba9-e95d-71da03afd76e@amd.com> <27022343-946b-ec7e-9beb-4ad9e74e38f8@huawei.com> <51296191-547c-652e-3945-d86a89e2c3d9@amd.com> From: "lihuisong (C)" In-Reply-To: <51296191-547c-652e-3945-d86a89e2c3d9@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.231] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600004.china.huawei.com (7.193.23.242) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2023/7/5 19:41, Ferruh Yigit 写道: > On 7/5/2023 10:40 AM, lihuisong (C) wrote: >> 在 2023/7/5 16:02, Ferruh Yigit 写道: >>> On 7/5/2023 4:16 AM, lihuisong (C) wrote: >>>> 在 2023/7/4 18:59, Ferruh Yigit 写道: >>>>> On 7/4/2023 9:45 AM, Jie Hai wrote: >>>>>> Function update_queue_state updates queue state of all queues >>>>>> of all ports, using the queue num nb_rxq|nb_txq stored locally >>>>>> by testpmd. An error on the invalid queue ID occurs if we run >>>>>> testpmd with two ports and detach-attach one of them and start >>>>>> the other port first. This is because the attached port has not >>>>>> been configured and has no queues, which differs from nb_rxq|nb_txq. >>>>>> The similar error happens in multi-process senoris if secondary >>>>>> process attaches a port and starts it. >>>>>> >>>>>> This patch updates queue state of the specified port, which has >>>>>> been configured by primary process. As the secondary process >>>>>> cannot configure the ports, make sure that the secondary process >>>>>> starts the port only after the primary process has done so. >>>> Now look good to me. >>>> Acked-by: Huisong Li >>>>>> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling >>>>>> all queues") >>>>>> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet >>>>>> forwarding") >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Jie Hai >>>>>> >>>>> The problem description and solution looks reasonable to me, but Intel >>>>> testing still reporting the issue. >>>>> >>>>> There is a chance that the issue Intel side observing is different, >>>>> waiting for more information from Intel test team. >>>>> >>>>> . >>> Hi Song, >>> >>> As far as I understand this patch works with an update from ixgbevf >>> driver, can you please confirm? >>> And can we have the ixgbevf fix soon, to not block the -rc3? >>> >> Hi Ferruh, >> >> Yes, ixgbe is not setting queue status correctly. >> Whether tesptmd polls the queue depends on the queue status >> (dev->data->rx_queue_state[queue_id]). >> But some drivers (not just ixgbe) do not set the status correctly. >> Jie is doing this. will be sent ASAP. >> > Hi Huisong, Jie > > As you said some drivers don't do it right, and my concern is: > a) if we have a side effect from last minute changes from drivers, > b) if there are more drivers impacted but not recognized yet > > That is why my proposal is to revert Jie's fix for this release, record > known issue, and merge it back early next release to give more time to > drivers adjust. What do you think? Agreed. And we can also take a look at Jie's fix for other drivers later.