From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.hunt@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 9B4C0569B
 for <dev@dpdk.org>; Mon,  1 Oct 2018 13:03:30 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
 by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 01 Oct 2018 04:03:29 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,327,1534834800"; d="scan'208";a="91071956"
Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.221.37])
 ([10.237.221.37])
 by fmsmga002.fm.intel.com with ESMTP; 01 Oct 2018 04:03:29 -0700
To: "Yao, Lei A" <lei.a.yao@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Mcnamara, John" <john.mcnamara@intel.com>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "Burakov, Anatoly" <anatoly.burakov@intel.com>
References: <20180926134037.43606-1-david.hunt@intel.com>
 <20180926163727.47337-1-david.hunt@intel.com>
 <20180926163727.47337-8-david.hunt@intel.com>
 <2DBBFF226F7CF64BAFCA79B681719D953A570DDE@shsmsx102.ccr.corp.intel.com>
From: "Hunt, David" <david.hunt@intel.com>
Message-ID: <80ea5e45-e2a8-1d86-a7ed-9d8589f375ed@intel.com>
Date: Mon, 1 Oct 2018 12:03:27 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A570DDE@shsmsx102.ccr.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v5 07/10] examples/power: add json string
	handling
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Oct 2018 11:03:31 -0000

Hi Lei,


On 30/9/2018 2:54 AM, Yao, Lei A wrote:
>> +#ifdef USE_JANSSON
>> +static int
>> +parse_json_to_pkt(json_t *element, struct channel_packet *pkt)
>> +{
>> +	const char *key;
>> +	json_t *value;
>> +	int ret;
>> +
>> +	memset(pkt, 0, sizeof(struct channel_packet));
>> +
>> +	pkt->nb_mac_to_monitor = 0;
>> +	pkt->t_boost_status.tbEnabled = false;
>> +	pkt->workload = LOW;
>> +	pkt->policy_to_use = TIME;
>> +	pkt->command = PKT_POLICY;
>> +	pkt->core_type = CORE_TYPE_PHYSICAL;
>> +
>
> Hi, Dave
>
> For the workload policy ,  it's set to LOW by default,
> but we can't change it again using JSON file channel. Is it
> by design?

It was because the VMs currently only send binary structures. But they
may send JSON data in the future so I should add it now.
I'll upload a new version of the patch set today.

Thanks,
Dave.