From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAC9DA046B for ; Wed, 24 Jul 2019 15:04:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F3E91C1DF; Wed, 24 Jul 2019 15:04:35 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 9E44F1C1DD for ; Wed, 24 Jul 2019 15:04:33 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 3E936980086 for ; Wed, 24 Jul 2019 13:04:32 +0000 (UTC) Received: from [192.168.1.11] (85.187.13.152) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 24 Jul 2019 14:04:28 +0100 From: Andrew Rybchenko To: References: <1563973146-16577-1-git-send-email-arybchenko@solarflare.com> Message-ID: <81075521-b15c-55ca-5804-5f1c52dc3820@solarflare.com> Date: Wed, 24 Jul 2019 16:04:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1563973146-16577-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [85.187.13.152] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24792.000 X-TM-AS-Result: No-4.604500-8.000000-10 X-TMASE-MatchedRID: csPTYAMX1+HmLzc6AOD8DfHkpkyUphL9BnIRIVcCWN9/Z0SyQdcmELEp pMQFmBm/pxoWnSqnGOJXsCcJh8yzeBHQbVLgwnYM/ccgt/EtX/3r+i+blgZMabjOUXWmQ3OWCh5 FGEJlYgEtqNi96xoVuw1UuEJlsPFUzHTv2iNHI6JH+PTjR9EWkj+k5IvvZ1N/+frbXg+Uc4V4dK bBLM9vyuzofVXMCAVTkZOl7WKIImrvXOvQVlExsFZ0V5tYhzdWxEHRux+uk8hxKpvEGAbTDk/bf Fm39LKOHAyCMVaHOn4dhN8OW+jhUatOp+YVaKFKDo1drR5/epalEBssBtW8CEfSYJ1KIIAUMDfY yjFDr7nTr48qZvdpfkMM+5esrmkv0Z7ILu16DdgP5GVjq7/FJUl/PJTgtLm0 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--4.604500-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24792.000 X-MDID: 1563973472-OfP-wsVT8oQz Subject: Re: [dpdk-dev] [PATCH 0/3] net/sfc: fix power of 2 alignment macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 7/24/19 3:59 PM, Andrew Rybchenko wrote: > P2ROUNDUP() and P2ALIGN() macros are buggy when alignment type is smaller > than type of the value to be aligned. > > IS_P2ALIGNED() has no the problem since it cast its arugments > to uintptr_t inside, but fixed anyway to follow the same approach as > new EFX_P2ROUNDUP() and EFX_P2ALIGN(). > > Patches have checkpatches.sh warnings in base driver since space > is required after sizeof. > > Andrew Rybchenko (3): > net/sfc: fix power of 2 round up when align has smaller type > net/sfc: fix align to power of 2 when align has smaller type > net/sfc: unify power of 2 alignment check macro > > drivers/net/sfc/base/ef10_impl.h | 9 +++--- > drivers/net/sfc/base/ef10_nvram.c | 3 +- > drivers/net/sfc/base/ef10_rx.c | 11 ++++--- > drivers/net/sfc/base/efx.h | 21 ++++++++++--- > drivers/net/sfc/base/efx_mcdi.h | 9 ++++-- > drivers/net/sfc/base/efx_tx.c | 4 +-- > drivers/net/sfc/efsys.h | 51 +++++++++++++++---------------- > drivers/net/sfc/sfc_ethdev.c | 2 +- > drivers/net/sfc/sfc_rx.c | 2 +- > 9 files changed, 64 insertions(+), 48 deletions(-) > Self NACK since the second patch fixes the first one. I'll send v2 shortly.