From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D91CC432EF;
	Fri, 10 Nov 2023 07:21:26 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C9A7740DDB;
	Fri, 10 Nov 2023 07:21:26 +0100 (CET)
Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])
 by mails.dpdk.org (Postfix) with ESMTP id 2599B4026D
 for <dev@dpdk.org>; Fri, 10 Nov 2023 07:21:25 +0100 (CET)
Received: from kwepemd100004.china.huawei.com (unknown [172.30.72.57])
 by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SRTGw3Q4Vzfb9Z;
 Fri, 10 Nov 2023 14:21:12 +0800 (CST)
Received: from [10.67.121.175] (10.67.121.175) by
 kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.2.1258.23; Fri, 10 Nov 2023 14:21:23 +0800
Message-ID: <8107a0ea-016c-088d-edc7-6a619d27da26@huawei.com>
Date: Fri, 10 Nov 2023 14:21:22 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH 0/5] net/hns3: fix and refactor mailbox code
To: Ferruh Yigit <ferruh.yigit@amd.com>, <dev@dpdk.org>
References: <20231108034434.559030-1-haijie1@huawei.com>
 <a466f938-7361-4c2e-9134-ede8da57f2fe@amd.com>
From: Jie Hai <haijie1@huawei.com>
In-Reply-To: <a466f938-7361-4c2e-9134-ede8da57f2fe@amd.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.175]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
 kwepemd100004.china.huawei.com (7.221.188.31)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2023/11/10 2:50, Ferruh Yigit wrote:
> On 11/8/2023 3:44 AM, Jie Hai wrote:
>> This patchset fixes failure on sync mailbox and refactors some codes on mailbox.
>>
>> Dengdui Huang (5):
>>    net/hns3: fix sync mailbox failure forever
>>    net/hns3: refactor VF mailbox message struct
>>    net/hns3: refactor PF mailbox message struct
>>    net/hns3: refactor send mailbox function
>>    net/hns3: refactor handle mailbox function
>>
> 
> Hi Jie,
> 
> Overall patchset looks good with minor issue below [1], but this set has
> high impact and not solving a critical defect etc, but mainly refactoring.
> We are very close to the release, there won't be enough time to fix any
> issue caused by this refactoring.
> 
> My suggestion is to postpone the refactoring to next release, maybe get
> only the first fix patch in this release, what do you think?
> 
I think it's OK.
> 
> 
> [1]
> Can you please fix the checkpatch warning:
> 
>   ### [PATCH] net/hns3: refactor handle mailbox function
> 
>    Warning in drivers/net/hns3/hns3_mbx.c:
>    Using __atomic_xxx/__ATOMIC_XXX built-ins, prefer
> rte_atomic_xxx/rte_memory_order_xxx
> 
Thanks, I'will send V2 with these fixes.
> .