* [dpdk-dev] [PATCH] net/softnic: remove experimental table from API
@ 2021-09-01 12:20 Jasvinder Singh
2021-09-01 13:48 ` Kinsella, Ray
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jasvinder Singh @ 2021-09-01 12:20 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu, mdr
This API was introduced in 18.08, therefore removing
experimental tag to promote it to stable state.
Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
drivers/net/softnic/rte_eth_softnic.h | 1 -
drivers/net/softnic/version.map | 7 +------
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/softnic/rte_eth_softnic.h b/drivers/net/softnic/rte_eth_softnic.h
index 3f01161777..6c11d89ab6 100644
--- a/drivers/net/softnic/rte_eth_softnic.h
+++ b/drivers/net/softnic/rte_eth_softnic.h
@@ -75,7 +75,6 @@ rte_pmd_softnic_run(uint16_t port_id);
* @return
* Zero on success, error code otherwise.
*/
-__rte_experimental
int
rte_pmd_softnic_manage(uint16_t port_id);
diff --git a/drivers/net/softnic/version.map b/drivers/net/softnic/version.map
index 6784318f77..cd5afcf155 100644
--- a/drivers/net/softnic/version.map
+++ b/drivers/net/softnic/version.map
@@ -2,12 +2,7 @@ DPDK_22 {
global:
rte_pmd_softnic_run;
+ rte_pmd_softnic_manage;
local: *;
};
-
-EXPERIMENTAL {
- global:
-
- rte_pmd_softnic_manage;
-};
--
2.26.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API
2021-09-01 12:20 [dpdk-dev] [PATCH] net/softnic: remove experimental table from API Jasvinder Singh
@ 2021-09-01 13:48 ` Kinsella, Ray
2021-09-15 7:33 ` Ferruh Yigit
2021-10-12 20:35 ` Dumitrescu, Cristian
2021-10-13 8:52 ` Kinsella, Ray
2 siblings, 1 reply; 6+ messages in thread
From: Kinsella, Ray @ 2021-09-01 13:48 UTC (permalink / raw)
To: Jasvinder Singh, dev; +Cc: cristian.dumitrescu
On 01/09/2021 13:20, Jasvinder Singh wrote:
> This API was introduced in 18.08, therefore removing
> experimental tag to promote it to stable state.
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> drivers/net/softnic/rte_eth_softnic.h | 1 -
> drivers/net/softnic/version.map | 7 +------
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API
2021-09-01 13:48 ` Kinsella, Ray
@ 2021-09-15 7:33 ` Ferruh Yigit
2021-09-30 15:42 ` David Marchand
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2021-09-15 7:33 UTC (permalink / raw)
To: Kinsella, Ray, Jasvinder Singh, dev; +Cc: cristian.dumitrescu
On 9/1/2021 2:48 PM, Kinsella, Ray wrote:
>
>
> On 01/09/2021 13:20, Jasvinder Singh wrote:
>> This API was introduced in 18.08, therefore removing
>> experimental tag to promote it to stable state.
>>
>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>> ---
>> drivers/net/softnic/rte_eth_softnic.h | 1 -
>> drivers/net/softnic/version.map | 7 +------
>> 2 files changed, 1 insertion(+), 7 deletions(-)
>>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API
2021-09-15 7:33 ` Ferruh Yigit
@ 2021-09-30 15:42 ` David Marchand
0 siblings, 0 replies; 6+ messages in thread
From: David Marchand @ 2021-09-30 15:42 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: Kinsella, Ray, Jasvinder Singh, dev, Cristian Dumitrescu
On Wed, Sep 15, 2021 at 9:33 AM Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 9/1/2021 2:48 PM, Kinsella, Ray wrote:
> >
> >
> > On 01/09/2021 13:20, Jasvinder Singh wrote:
> >> This API was introduced in 18.08, therefore removing
> >> experimental tag to promote it to stable state.
> >>
> >> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> >> ---
> >> drivers/net/softnic/rte_eth_softnic.h | 1 -
> >> drivers/net/softnic/version.map | 7 +------
> >> 2 files changed, 1 insertion(+), 7 deletions(-)
> >>
> > Acked-by: Ray Kinsella <mdr@ashroe.eu>
> >
>
> Applied to dpdk-next-net/main, thanks.
Nit:
diff --git a/drivers/net/softnic/version.map b/drivers/net/softnic/version.map
index cd5afcf155..01e1514276 100644
--- a/drivers/net/softnic/version.map
+++ b/drivers/net/softnic/version.map
@@ -1,8 +1,8 @@
DPDK_22 {
global:
- rte_pmd_softnic_run;
rte_pmd_softnic_manage;
+ rte_pmd_softnic_run;
local: *;
};
When merging patches touching .map, I recommend running:
./devtools/update-abi.sh 22.0
--
David Marchand
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API
2021-09-01 12:20 [dpdk-dev] [PATCH] net/softnic: remove experimental table from API Jasvinder Singh
2021-09-01 13:48 ` Kinsella, Ray
@ 2021-10-12 20:35 ` Dumitrescu, Cristian
2021-10-13 8:52 ` Kinsella, Ray
2 siblings, 0 replies; 6+ messages in thread
From: Dumitrescu, Cristian @ 2021-10-12 20:35 UTC (permalink / raw)
To: Singh, Jasvinder, dev; +Cc: mdr
> -----Original Message-----
> From: Singh, Jasvinder <jasvinder.singh@intel.com>
> Sent: Wednesday, September 1, 2021 1:21 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; mdr@ashroe.eu
> Subject: [PATCH] net/softnic: remove experimental table from API
>
> This API was introduced in 18.08, therefore removing
> experimental tag to promote it to stable state.
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> drivers/net/softnic/rte_eth_softnic.h | 1 -
> drivers/net/softnic/version.map | 7 +------
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/net/softnic/rte_eth_softnic.h
> b/drivers/net/softnic/rte_eth_softnic.h
> index 3f01161777..6c11d89ab6 100644
> --- a/drivers/net/softnic/rte_eth_softnic.h
> +++ b/drivers/net/softnic/rte_eth_softnic.h
> @@ -75,7 +75,6 @@ rte_pmd_softnic_run(uint16_t port_id);
> * @return
> * Zero on success, error code otherwise.
> */
> -__rte_experimental
> int
> rte_pmd_softnic_manage(uint16_t port_id);
>
> diff --git a/drivers/net/softnic/version.map
> b/drivers/net/softnic/version.map
> index 6784318f77..cd5afcf155 100644
> --- a/drivers/net/softnic/version.map
> +++ b/drivers/net/softnic/version.map
> @@ -2,12 +2,7 @@ DPDK_22 {
> global:
>
> rte_pmd_softnic_run;
> + rte_pmd_softnic_manage;
>
> local: *;
> };
> -
> -EXPERIMENTAL {
> - global:
> -
> - rte_pmd_softnic_manage;
> -};
> --
> 2.26.3
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/softnic: remove experimental table from API
2021-09-01 12:20 [dpdk-dev] [PATCH] net/softnic: remove experimental table from API Jasvinder Singh
2021-09-01 13:48 ` Kinsella, Ray
2021-10-12 20:35 ` Dumitrescu, Cristian
@ 2021-10-13 8:52 ` Kinsella, Ray
2 siblings, 0 replies; 6+ messages in thread
From: Kinsella, Ray @ 2021-10-13 8:52 UTC (permalink / raw)
To: Jasvinder Singh, dev; +Cc: cristian.dumitrescu
On 01/09/2021 13:20, Jasvinder Singh wrote:
> This API was introduced in 18.08, therefore removing
> experimental tag to promote it to stable state.
>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
> ---
> drivers/net/softnic/rte_eth_softnic.h | 1 -
> drivers/net/softnic/version.map | 7 +------
> 2 files changed, 1 insertion(+), 7 deletions(-)
>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-13 8:52 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 12:20 [dpdk-dev] [PATCH] net/softnic: remove experimental table from API Jasvinder Singh
2021-09-01 13:48 ` Kinsella, Ray
2021-09-15 7:33 ` Ferruh Yigit
2021-09-30 15:42 ` David Marchand
2021-10-12 20:35 ` Dumitrescu, Cristian
2021-10-13 8:52 ` Kinsella, Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).