From: Thomas Monjalon <thomas@monjalon.net>
To: Rohit Raj <rohit.raj@nxp.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Ray Kinsella <mdr@ashroe.eu>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>,
dev@dpdk.org, nipun.gupta@nxp.com, sachin.saxena@nxp.com,
hemant.agrawal@nxp.com, ferruh.yigit@intel.com,
david.marchand@redhat.com
Subject: Re: [PATCH v5 1/2] eal: add API for bus close
Date: Wed, 19 Jan 2022 11:31:55 +0100 [thread overview]
Message-ID: <8133639.5OynTdThKG@thomas> (raw)
In-Reply-To: <20220110052627.22577-1-rohit.raj@nxp.com>
Hi,
10/01/2022 06:26, rohit.raj@nxp.com:
> From: Rohit Raj <rohit.raj@nxp.com>
>
> As per the current code we have API for bus probe, but the
> bus close API is missing. This breaks the multi process
> scenarios as objects are not cleaned while terminating the
> secondary processes.
>
> This patch adds a new API rte_bus_close() for cleanup of
> bus objects which were acquired during probe.
I don't understand how closing all devices of a bus will help better
than just closing all devices.
As Ferruh already suggested in the past,
we could force closing all devices in rte_eal_cleanup().
And we already have the function rte_dev_remove().
next prev parent reply other threads:[~2022-01-19 10:32 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 8:24 [dpdk-dev] [PATCH v2 1/3] " rohit.raj
2020-08-24 8:24 ` [dpdk-dev] [PATCH v2 2/3] examples/multi_process: cleanup bus objects while terminating app rohit.raj
2020-09-08 5:32 ` Hemant Agrawal
2020-08-24 8:24 ` [dpdk-dev] [PATCH v2 3/3] bus/fslmc: support bus close API rohit.raj
2020-08-24 15:14 ` [dpdk-dev] [PATCH v2 1/3] eal: add API for bus close Stephen Hemminger
2020-08-26 5:52 ` [dpdk-dev] [PATCH v3 " rohit.raj
2020-08-26 5:52 ` [dpdk-dev] [PATCH v3 2/3] examples/multi_process: cleanup bus objects while terminating app rohit.raj
2020-09-08 5:32 ` Hemant Agrawal
2020-08-26 5:52 ` [dpdk-dev] [PATCH v3 3/3] bus/fslmc: support bus close API rohit.raj
2020-09-08 5:35 ` Hemant Agrawal (OSS)
2020-09-17 15:35 ` Kinsella, Ray
2020-09-08 4:46 ` [dpdk-dev] [PATCH v3 1/3] eal: add API for bus close Hemant Agrawal
2020-09-23 23:54 ` Thomas Monjalon
2020-09-17 15:34 ` Kinsella, Ray
2020-09-24 11:39 ` Ferruh Yigit
2020-09-29 4:33 ` Sachin Saxena (OSS)
2020-09-30 11:50 ` Ferruh Yigit
2020-10-08 16:24 ` Ferruh Yigit
2020-10-09 4:53 ` [dpdk-dev] [EXT] " Rohit Raj
2020-10-18 9:25 ` David Marchand
2020-10-08 15:30 ` [dpdk-dev] [PATCH v4 1/5] " rohit.raj
2020-10-08 15:30 ` [dpdk-dev] [PATCH v4 2/5] examples/multi_process: cleanup bus objects while terminating app rohit.raj
2020-10-18 9:25 ` David Marchand
2021-01-25 11:07 ` oulijun
2021-02-04 12:53 ` David Marchand
2023-07-05 23:35 ` Stephen Hemminger
2020-10-08 15:30 ` [dpdk-dev] [PATCH v4 3/5] bus/fslmc: support bus close API rohit.raj
2020-10-08 15:30 ` [dpdk-dev] [PATCH v4 4/5] eal/freebsd: added support for rte_bus_close API rohit.raj
2020-10-08 15:30 ` [dpdk-dev] [PATCH v4 5/5] eal/windows: " rohit.raj
2020-10-11 8:06 ` Tal Shnaiderman
2020-10-27 5:55 ` Narcisa Ana Maria Vasile
2020-10-18 9:21 ` [dpdk-dev] [PATCH v4 1/5] eal: add API for bus close David Marchand
2022-01-10 5:26 ` [PATCH v5 1/2] " rohit.raj
2022-01-10 5:26 ` [PATCH v5 2/2] bus/fslmc: support bus close API rohit.raj
2022-01-19 10:31 ` Thomas Monjalon [this message]
2022-01-20 14:51 ` [EXT] Re: [PATCH v5 1/2] eal: add API for bus close Rohit Raj
2022-01-20 14:58 ` Thomas Monjalon
2022-02-01 5:40 ` Rohit Raj
2022-02-01 7:43 ` Thomas Monjalon
2022-02-09 11:04 ` David Marchand
2022-02-09 13:20 ` Thomas Monjalon
2023-07-05 23:37 ` [dpdk-dev] [PATCH v2 1/3] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8133639.5OynTdThKG@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=mdr@ashroe.eu \
--cc=navasile@linux.microsoft.com \
--cc=nipun.gupta@nxp.com \
--cc=pallavi.kadam@intel.com \
--cc=rohit.raj@nxp.com \
--cc=sachin.saxena@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).