From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF46EA04A5; Wed, 19 Jan 2022 11:32:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38702410F7; Wed, 19 Jan 2022 11:32:01 +0100 (CET) Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) by mails.dpdk.org (Postfix) with ESMTP id 9FF3D4013F for ; Wed, 19 Jan 2022 11:31:59 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 00A7258015B; Wed, 19 Jan 2022 05:31:59 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 19 Jan 2022 05:31:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm3; bh= Ajbz7jFerWSI8P5BjkJ60h2vtczCPde/4ClZ8bKHR7U=; b=Nk7w9pXG9n2MQaMh hYSUYH3xp58GpQ5C5wj4bzFhfI/k/Tqh/cUXIn7Y9Oa2XHm64nvmU74NcT0XAFqz Zftu3E94vrShRwMYL/mKcHJSQgC2Q/q9vteTSQHOJ4A/ZD+cKb52Xx34gPPWSNV6 YCdQSlv/+k2X8PwZ2+ZAcNAACJDbXwhMgfOK9XhAtUEUWKk9Bqvj7OLHCIL05OZF wWeTDkdmbyDF3qCHlabB7GsxM8R1mdjfkzASC44qhShle1iv4lBmi5WFnaPuJLFr hXqpyQEKW3VZXjWtdS0DQLUlYh7FmZw3NP5lbiAEr7zm/qMEYw7n7FNAetfJyMld h+K3qA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=Ajbz7jFerWSI8P5BjkJ60h2vtczCPde/4ClZ8bKHR 7U=; b=BAQOKeOPiDjZV0dySb8lqe/kjkxkQS2jrSe11GOOOU1qfZoMUET5QL6VK PLYQ+IjZlZwmieElIuQBJUWg2ShGGcSZZ5M1KNHbc2rPVY/dl0ADn0DzOz6VlKRm 8Xpc3VnH7LOsyXL+7kXXrVJbUu5RhlryLsVr4Vi/Ok/virv0igXku2IB5Xa85LJf vLBEX6o6CI+drkipUYkwI83u9OIz+YXS2DZwWlA3QIVg5b83qiCzH1kc95GvvOxd HBp4t154lYC2OZvnBJ3bPNfHHlXLqwuizAG8e92y1fl+JFAuqrLyTD1tSJUYFnie HXJj57+HoMoV9kAoVWF0sdAxEpqsg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudehgddujecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 19 Jan 2022 05:31:57 -0500 (EST) From: Thomas Monjalon To: Rohit Raj Cc: Bruce Richardson , Ray Kinsella , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , dev@dpdk.org, nipun.gupta@nxp.com, sachin.saxena@nxp.com, hemant.agrawal@nxp.com, ferruh.yigit@intel.com, david.marchand@redhat.com Subject: Re: [PATCH v5 1/2] eal: add API for bus close Date: Wed, 19 Jan 2022 11:31:55 +0100 Message-ID: <8133639.5OynTdThKG@thomas> In-Reply-To: <20220110052627.22577-1-rohit.raj@nxp.com> References: <20201008153048.19369-1-rohit.raj@nxp.com> <20220110052627.22577-1-rohit.raj@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, 10/01/2022 06:26, rohit.raj@nxp.com: > From: Rohit Raj > > As per the current code we have API for bus probe, but the > bus close API is missing. This breaks the multi process > scenarios as objects are not cleaned while terminating the > secondary processes. > > This patch adds a new API rte_bus_close() for cleanup of > bus objects which were acquired during probe. I don't understand how closing all devices of a bus will help better than just closing all devices. As Ferruh already suggested in the past, we could force closing all devices in rte_eal_cleanup(). And we already have the function rte_dev_remove().