From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5014243B39; Fri, 16 Feb 2024 12:39:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E738D432C8; Fri, 16 Feb 2024 12:39:43 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2066.outbound.protection.outlook.com [40.107.244.66]) by mails.dpdk.org (Postfix) with ESMTP id DEB5543001 for ; Fri, 16 Feb 2024 12:39:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VocafJRWMC/kjTtrAyLlkP3bCY8IodfhraJi8ncNhUzpBXg3bo+Hjhpvgx8CT28QQ0hS6x5kdQKWT+FiMhGQ8WXr+ch7ON5EX/7Ysc7i9VBwOjKWyiSS+v+y5eLaBeuD432ctgWDjwi6+O6zGNQ77FS9jAe23osLvJkfglK8v0BNQBnnLdNY+tyIUhfhh098dSyxfxKY0yceh/SncdwmiUFmMzAig4vzoIOIfjGcHKp2S43Hnvm9GqulqLsPi/xKXvOFKvhzwidvLp7n73gHG6kJ2n3zdkE+eGjOR3OfWkNaYRGUId0EVdPQ2q+pMHI7phwm8l3/vM1C/Dcloi570g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7jnfsTQCTfktmatqGkGoCdtMpl8jVKVr7WRSWoruXjI=; b=eu6rBbivGItvqQVKoT62SC/2OwFsdpp+fl5ejlMt+L9qt+m6KV4JWhLQwG4RqEiTHgqJFZwvhBc1r5kc/DfR27GYfxgtRM+OS2SAWveN/RL2C5RBfXuapzSuppK1snotD/Xcaxob6Bz7vz4ZZvlLDNZvMMvsmMUiV49cJlTU+awo6Cj124pq8wL5guaOeKePKFpstThG1QpEX+7YfkMyrG5yQJpEGUtQBcEIZw3VPj/qqFEDSzFDGmwpDMNOWqa0kchvmKpftpHjZbollYmLVKHAnewyBXiub5YxHKloW7HLxXoJXQ9RMWOXZbERJPDxWqfd4tNBuu9g5Hmy9plseQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7jnfsTQCTfktmatqGkGoCdtMpl8jVKVr7WRSWoruXjI=; b=TsOxG1RSan5USy2WX9up4zgPmig7S2p5KSw4Opry4htZz1Bm4xxrtPi7nVH0slGAjoDjPtKzwKKK48Oa1juyPz2zT5MgH3HXWtLeFii++IgThoPoTdLn1G0YU6gm3Bf6guZFF1VgZuqqeY3ia4wHQZN2kpX8G1MdVQTzy5xalL0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4101.namprd12.prod.outlook.com (2603:10b6:610:a8::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.12; Fri, 16 Feb 2024 11:39:39 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7316.012; Fri, 16 Feb 2024 11:39:39 +0000 Message-ID: <8139ddff-aabf-4ee0-a51b-a2a658691624@amd.com> Date: Fri, 16 Feb 2024 11:39:32 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6] net/netvsc: fix parsing of VLAN metadata Content-Language: en-US To: Alan Elder , Long Li , Andrew Rybchenko Cc: "dev@dpdk.org" , stephen References: From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0189.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::33) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4101:EE_ X-MS-Office365-Filtering-Correlation-Id: d92d3b9b-4e87-4507-29f9-08dc2ee3f570 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EaVkgP058ze5oVH+3gZjkUTcRKJKAB2FO19Ay6uaGgjW4bdeddITKH93n7jvdTGG52EzvbIlhlHc6JU59JFpeLKndcgLEK461jUMjm5xW52ioRmXVN5lQz7t4eMDFu7jP/QlcScfisRt5r0D/SBn6qYEUEpQtmFG230NQyHgK1D0Z4Mr9sSU7U3enRiZi/lYPhU/Iz3aV8ZziDJEQO35CQmaNpdoV4hXmn0PPVUxC/qKFvtAXEsK2pbza6dHxqMWTCPt3b4kbcp6X8SqAdNuwpNIMllkaNvOZs7LpfHHIF4Hq3FSV8bNmzjifkIzjRoa1i5GI4fb/+JEBzp6qLya1CIkYInmNO43S4Qx8sj5d0TzqIQ8y+DcAv7AFUlvpsXBACWp1/lnQhz/n1Bxl69+QrPwRYXh0tKw9HbbB11TA0BX5ktsJCGSwABEKZ7rwrVNVWXnDZdjAKp3n8pZpcauIiMm/ue0hsQSjkvRLt4bfqPriWaGrbvhjiORigUd3jmDdZ2/+LTDQdizLWLq6cqyr9CTVZDUiGD9iGWwmsAwXFVT+5EMeh71lHc3TLufP+Gu X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(136003)(366004)(396003)(39860400002)(376002)(230922051799003)(64100799003)(451199024)(1800799012)(186009)(6666004)(6512007)(6486002)(110136005)(36756003)(31686004)(6506007)(53546011)(31696002)(4744005)(2906002)(38100700002)(5660300002)(41300700001)(316002)(54906003)(44832011)(8676002)(4326008)(86362001)(8936002)(66556008)(66476007)(66946007)(2616005)(478600001)(45080400002)(26005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RS9LSGZULzVseVg2K2VQL2loVVB3ck5GVnBnOUwyVkI5UmxxTmprZHhURE10?= =?utf-8?B?LzlqL3lFempCcHgyazFTNUZsYUs1WkZMcjBHZFNzekw1amtPaUZUenpVandI?= =?utf-8?B?c2xlOFhIUmxhTjdZVmREd2JOVkhHQ1ZHbk1pYjQ5YWprYVF4eDJVejhVeU1o?= =?utf-8?B?c0tLSS9YL3NPcHllblhpSXM5eUI2d1A2MkpLdE9kNDlaUyttT0RTTDhWZVVq?= =?utf-8?B?dkxRZFEzVTA1QldhV3BHbGE3YitYK3RPSWtic0xOd1dnd1NYWWIzZW5xUG1I?= =?utf-8?B?Tjc5YjExWE1VMDhLeFVRSVRuWW9wQUI2TWE1Q0pzQTBQaFJYQTVTWnBzMnpL?= =?utf-8?B?aDVMcmhkTUVuUzFkV0ZVWEFJMGdxVDRXdFllMEZyOHQyTGluQ0tHYlRmQUZj?= =?utf-8?B?SHJ4MTJjRU5GYTMwM2ZZNGplY1VqL1NWRjY1Qkt1WGQ1eTh2VWk5YXh5R3dL?= =?utf-8?B?N1ZLM29tOXVGRUVNVit4NXBEL0Z3czZLLytBMmN5RzJFOTh6bXg0V21FQUsy?= =?utf-8?B?YVl3MG9IRkNuanhaZkErcWJSVWdUUTBzaU04M0pGSTEvVGYrbmM0MHFBNzFp?= =?utf-8?B?WWQwajkxZk0yMUxtK0p2TTdidGtJRTZkaVN2Z1dSR1NsN1ZiZHd6czlTTVpw?= =?utf-8?B?SVVaN0hVZWw2aFdGbEZCbUdXYWtPV2g5eGwwdUhCMHFnNGNnb1JUbHpRTHFp?= =?utf-8?B?QjBMNmZSQytDTTZXcDJoSXljY2ovQUF2VUJlZllDRVFabTc0V1k4SFVOVitz?= =?utf-8?B?MGdvRnJNb1AxVWtuTW1PSWx1U2RjbTZyZGdqQ0ZkYWw1MFpyN3NlcUhPN1lF?= =?utf-8?B?K3R6T1QzbnNrN1pXMFQrODEzbmFhL3FzM2JVNWVKSkNWZzJIbVlhMmVCSHJi?= =?utf-8?B?NTdKdDQvOVhBRmFpdkdzTHRlcWpsakwvc29PTXY1aXplei83QjdGUDlLZUNL?= =?utf-8?B?eStkVGhTRkd4TCtUVmV1dHJGZUV2dkZqMGwyQm5MK2p5ODJFT1IzbFBKRFFO?= =?utf-8?B?c0RTeWE3WVdIZVNPVHdZL0xCSC84cU5yZWorVHNsK2g1OE53M3NncUpSaXdD?= =?utf-8?B?aGdlQTVhbkVOeTluR2dTd3NOUGZVeUZvYzZSMXE5c1IrNTNCUTI0WlZtcWx3?= =?utf-8?B?SE8rYUlyZW9KNWNmWU9WYUg0dmUyeXBFV1Z6RmFZbnBiL0JXZ25KWnVvMlpv?= =?utf-8?B?NVdkZllYTG83OGxaT1ozWjNBT3hyVmN2TG4vY2VKQ3NJbFkrOHBaMVV1bUU0?= =?utf-8?B?bVZVM0R3aVFqM2Y4dERCd0NaTVZjcDl5ckZ5ZjVxVlZHU3lVNWpLV3F3bU9V?= =?utf-8?B?U2hKbVJxTVNhUTVFNnBzQ0E4NXJIdU9vOVhEdk5GbEVxa0tjUk4zeEo2Snhv?= =?utf-8?B?OTJKRHVGNHNzTHQ1N3VoRWVweDVjNEtNcklnaDhrMXVvSmF5YXgzbmtYUFA0?= =?utf-8?B?Tmx0YWNxeXpiYTRtVERNMmxZbngwcjFOUkxLZDNFZlp4amlOMWFSRTVxVEt1?= =?utf-8?B?dFMxVlk0VkpMcVE0aFROMnBRRnd6ZkhuWFJEYzJPLzlHbGtjVkRrdzFsSlAy?= =?utf-8?B?RlRnSjMrSjhBalVMVlhLcllPTXR5YXB3QWRJT1NkYVBjblRQdTFzTUwvNU1D?= =?utf-8?B?dVQwNEdhT1lKRUxIY003WGhoVEU2UGZta0pnVHVPNnpwaUZVM3RxU0t2Z1p4?= =?utf-8?B?Nk5YQlhxNVBOQ25lTHQxRGhnL29OQnM2VUg3RkRyTzlUdUw4SmQ2clE5b1Q3?= =?utf-8?B?cUpzTjkwQm1sZkxOVk50YUtRUUV2QkhxQ0Z3Q0taK3NlZlNCRG9PY25yekE5?= =?utf-8?B?WFlKWFlQNTRYN2FKNVVZTGQzdFloMTRzaFFyalhsQlh5aWRUSVd6cHM1WUs1?= =?utf-8?B?endBUGxwbC9DYmliMHBrUGQ3Y0lId1FYOXFCd1h3U05LTVYyeVdEa3JtaGQ1?= =?utf-8?B?My9RRlVXVHJ3QU1DOEhCOGxjS1BoRHFwYjg2Q3NBVHB3T1lsWUxuRDZXWVJO?= =?utf-8?B?OGZ1ZE5CS1E0aWd4YlF3ZjZKRURvMzMyanRGU3lwRVErdDNIYmwrenVZVUgw?= =?utf-8?B?SnVway9pSXh6Qzc2YXVOV2RPbTB6SC9qdHJES08xZVg2TTdGK3RKRzZlN2Q2?= =?utf-8?Q?0l6osHS76Z6ftr0GfOKfrxljn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d92d3b9b-4e87-4507-29f9-08dc2ee3f570 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 11:39:39.2317 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2RxfzVBVlj6LJWeWDr09CyoiRgQsdTrskRH7Ikp1QzrX459X8MQgyWnunqqaxeUA X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4101 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/16/2024 9:43 AM, Alan Elder wrote: > The previous code incorrectly parsed the VLAN ID and priority. > If the 16-bits of VLAN ID and priority/CFI on the wire was > 0123456789ABCDEF the code parsed it as 456789ABCDEF3012. There > were macros defined to handle this conversion but they were not > used. > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > Cc: sthemmin@microsoft.com > Cc: stable@dpdk.org > > Signed-off-by: Alan Elder > I missed v6 but put some comment on v5, briefly can you please split the patch for lib/net and driver?