* [dpdk-dev] [PATCH] app/testpmd: fix icmp echo tx queues
@ 2015-10-29 8:47 David Marchand
2015-11-10 15:27 ` Thomas Monjalon
2015-11-10 16:10 ` De Lara Guarch, Pablo
0 siblings, 2 replies; 4+ messages in thread
From: David Marchand @ 2015-10-29 8:47 UTC (permalink / raw)
To: dev
icmp echo forward engine relies on the core rank rather than the number of
queues available.
This fix is still wrong, because if we set a nb-rxq > nb-txq, then we will use
an invalid txq, but with this, we are aligned on other fwd engines.
Signed-off-by: David Marchand <david.marchand@6wind.com>
---
app/test-pmd/config.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index cf2aa6e..314215c 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1278,7 +1278,7 @@ icmp_echo_config_setup(void)
fs->rx_port = fwd_ports_ids[rxp];
fs->rx_queue = rxq;
fs->tx_port = fs->rx_port;
- fs->tx_queue = lc_id;
+ fs->tx_queue = rxq;
fs->peer_addr = fs->tx_port;
if (verbose_level > 0)
printf(" stream=%d port=%d rxq=%d txq=%d\n",
--
1.9.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix icmp echo tx queues
2015-10-29 8:47 [dpdk-dev] [PATCH] app/testpmd: fix icmp echo tx queues David Marchand
@ 2015-11-10 15:27 ` Thomas Monjalon
2015-11-10 16:10 ` De Lara Guarch, Pablo
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2015-11-10 15:27 UTC (permalink / raw)
To: pablo.de.lara.guarch; +Cc: dev
2015-10-29 09:47, David Marchand:
> icmp echo forward engine relies on the core rank rather than the number of
> queues available.
> This fix is still wrong, because if we set a nb-rxq > nb-txq, then we will use
> an invalid txq, but with this, we are aligned on other fwd engines.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
[...]
> - fs->tx_queue = lc_id;
> + fs->tx_queue = rxq;
Pablo, any opinion?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix icmp echo tx queues
2015-10-29 8:47 [dpdk-dev] [PATCH] app/testpmd: fix icmp echo tx queues David Marchand
2015-11-10 15:27 ` Thomas Monjalon
@ 2015-11-10 16:10 ` De Lara Guarch, Pablo
2015-11-10 16:23 ` Thomas Monjalon
1 sibling, 1 reply; 4+ messages in thread
From: De Lara Guarch, Pablo @ 2015-11-10 16:10 UTC (permalink / raw)
To: David Marchand, dev
Hi,
> -----Original Message-----
> From: David Marchand [mailto:david.marchand@6wind.com]
> Sent: Thursday, October 29, 2015 8:47 AM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo
> Subject: [PATCH] app/testpmd: fix icmp echo tx queues
>
> icmp echo forward engine relies on the core rank rather than the number of
> queues available.
> This fix is still wrong, because if we set a nb-rxq > nb-txq, then we will use
> an invalid txq, but with this, we are aligned on other fwd engines.
>
> Signed-off-by: David Marchand <david.marchand@6wind.com>
> ---
> app/test-pmd/config.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index cf2aa6e..314215c 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1278,7 +1278,7 @@ icmp_echo_config_setup(void)
> fs->rx_port = fwd_ports_ids[rxp];
> fs->rx_queue = rxq;
> fs->tx_port = fs->rx_port;
> - fs->tx_queue = lc_id;
> + fs->tx_queue = rxq;
> fs->peer_addr = fs->tx_port;
> if (verbose_level > 0)
> printf(" stream=%d port=%d rxq=%d
> txq=%d\n",
> --
> 1.9.1
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix icmp echo tx queues
2015-11-10 16:10 ` De Lara Guarch, Pablo
@ 2015-11-10 16:23 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2015-11-10 16:23 UTC (permalink / raw)
To: David Marchand; +Cc: dev
> > icmp echo forward engine relies on the core rank rather than the number of
> > queues available.
> > This fix is still wrong, because if we set a nb-rxq > nb-txq, then we will use
> > an invalid txq, but with this, we are aligned on other fwd engines.
> >
> > Signed-off-by: David Marchand <david.marchand@6wind.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-10 16:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-29 8:47 [dpdk-dev] [PATCH] app/testpmd: fix icmp echo tx queues David Marchand
2015-11-10 15:27 ` Thomas Monjalon
2015-11-10 16:10 ` De Lara Guarch, Pablo
2015-11-10 16:23 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).