From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2208A0565; Tue, 10 Mar 2020 10:36:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D44B21C029; Tue, 10 Mar 2020 10:36:49 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 81E491C002; Tue, 10 Mar 2020 10:36:47 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Mar 2020 02:36:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,536,1574150400"; d="scan'208";a="231262237" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.20]) ([10.237.221.20]) by orsmga007.jf.intel.com with ESMTP; 10 Mar 2020 02:36:43 -0700 To: Thomas Monjalon , Kevin Traynor , David Marchand , "Ye, Xiaolong" , "Wang, Haiyue" Cc: dev , "Zhang, Qi Z" , "Yang, Qiming" , "Xing, Beilei" , "Zhao1, Wei" , Aaron Conole , "ci@dpdk.org" References: <20200309141437.11800-1-haiyue.wang@intel.com> <21697353.6Emhk5qWAg@xps> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <8145ace5-7b3e-82fa-95e2-28dc1844459e@intel.com> Date: Tue, 10 Mar 2020 09:36:42 +0000 MIME-Version: 1.0 In-Reply-To: <21697353.6Emhk5qWAg@xps> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/10/2020 7:48 AM, Thomas Monjalon wrote: > 10/03/2020 03:00, Wang, Haiyue: >>> -----Original Message----- >>> From: Kevin Traynor >>> Sent: Tuesday, March 10, 2020 03:34 >>> To: Thomas Monjalon ; David Marchand ; Ye, Xiaolong >>> >>> Cc: Wang, Haiyue ; dev ; Zhang, Qi Z ; Yang, >>> Qiming ; Xing, Beilei ; Zhao1, Wei ; >>> Aaron Conole ; ci@dpdk.org; Yigit, Ferruh >>> Subject: Re: [dpdk-dev] [PATCH v1 0/4] add Intel DCF PMD support >>> >>> On 09/03/2020 17:57, Thomas Monjalon wrote: >>>> 09/03/2020 17:20, Ye Xiaolong: >>>>> Hi, David >>>>> >>>>> On 03/09, David Marchand wrote: >>>>>> On Mon, Mar 9, 2020 at 3:22 PM Haiyue Wang wrote: >>>>>>> >>>>>>> A DCF (Device Config Function) based approach is proposed where a device >>>>>>> bound to the device's VF0 can act as a sole controlling entity to exercise >>>>>>> advance functionality (such as switch, ACL) for rest of the VFs. >>>>>>> >>>>>>> The DCF works as a standalone PMD to support this function, which shares the >>>>>>> ice PMD flow control core function and the iavf virtchnl mailbox core module. >>>>>>> >>>>>>> This patchset is based on: >>>>>>> [1] https://patchwork.dpdk.org/cover/66417/ update ice base code >>>>>> >>>>>> The problem is that the CI(s) won't handle this. >>>>>> Example for the robot: https://travis-ci.com/ovsrobot/dpdk/builds/152461907 >>>>>> >>>>>> Maybe we could add something as an annotation to the cover letter or >>>>>> the first patch of a series so that the CI(s) can detect and try to be >>>>>> intelligent? >>>>> >>>>> Agree, It'd be helpful if the cover letter of the first patch contains some >>>>> base tree info including the base commit and dependency patchset info (if any), >>>>> so the CI can determine the correct base on top of which the developer's >>>>> patchset applies to avoid any apply issue and potential false positive. >>>>> >>>>> And I know there is one option '--base'' of `git format-patch` which is >>>>> dedicated for this kind of usage, it can help create the base tree info block >>>>> which can be easily consumed by the CI. Here is the simple intro of it. >>>>> >>>>> Imagine that on top of the public commit P (already in upstream), the developer >>>>> applied well-known (on-flight, in the mailing list but not merged yet) patches >>>>> X, Y and Z from somebody else or himself, and then built his three-patch series >>>>> A, B, C, the commit history would be like: >>>>> >>>>> ................................................ >>>>> ---P---X---Y---Z---A---B---C >>>>> ................................................ >>>>> >>>>> With `git format-patch --base=P -3 C`, >>>>> >>>>> where P could be the exact commit sha, or variants e.g. HEAD~6, we can also use >>>>> --base=auto for convenience, the base tree information block will be shown at >>>>> the end of the first message the command outputs (either the first patch, or >>>>> the cover letter), like this: >>>>> >>>>> ------------ >>>>> base-commit: P >>>>> prerequisite-patch-id: X >>>>> prerequisite-patch-id: Y >>>>> prerequisite-patch-id: Z >>>>> ------------ >>>>> >>>>> Here P is the commit sha, and X,Y,Z are the patch ids of the dependency patches. >>>>> >>>>> >>>>> With this info in place, I think CI should be able to setup the exact base for >>>>> the coming patchset, the missing part I can see is the mapping of >>>>> (in-flight patch <-> patch id), since we have all the in-flight patches in >>>>> patchwork, creating and maintaining such mapping in DB is doable, what do you >>>>> think? >>>> >>>> I think it would simpler to list dependencies as patchwork ids. >>>> Example: >>>> Depends-on: series-42, patch-12345 >>>> >>> >> >> Just list the 'series' ? Since it can download the whole patchset with >> the single link format like: >> >> Depends-on: series-8843 --> https://patchwork.dpdk.org/series/8843/mbox/ > > Yes, I was proposing both format: series-X and patch-Y (on top of series-X). > But we probably never need to be specific about a single patch. > I think you are right, we can keep only "series-X" syntax, > and allow describing a list of series, ordered and separated with comma. > +1 to "Depends-on: series-#####" syntax