From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5074EA0540; Fri, 2 Dec 2022 20:41:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 39E4340687; Fri, 2 Dec 2022 20:41:24 +0100 (CET) Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by mails.dpdk.org (Postfix) with ESMTP id DF712400D6 for ; Fri, 2 Dec 2022 20:41:22 +0100 (CET) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 8801B320039A; Fri, 2 Dec 2022 14:41:20 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 02 Dec 2022 14:41:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1670010080; x= 1670096480; bh=3FiJmSUpmM45s4kvNdXPYWl3YP8wZg6cnlWVoV3F3xs=; b=S RfavceywWxzklGPTNscIVzfp96OwajqNOFbj8QeaPxZxg9F5MdifrofovABSpZTt Dh8AD4khT5PtiFCaXVRSDkXqjXX6dryUikEXYKx8v+qabOgMxxhLY5+w3a5GwoNO 9NAcM7ym4tJEJ+nXXtA6uHDyZz6Gly8LWGEGcS2ek9dXfbLfbIdwWppRLD5+6loR LxBvtsCSFo+MvMQA9xl1TeE0SKgIYGfbPQ+gHia5VRpvEgX+KxI3CVTnDQgAWK5Q u3A+3tSvVZpkwZzCRbAsUxZMjX+EPPt74HZ+aBLr+7t7Apz0E4UVHXsy9WYAEbF6 Ba2HylCFXpoBWxNqxLZ+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1670010080; x= 1670096480; bh=3FiJmSUpmM45s4kvNdXPYWl3YP8wZg6cnlWVoV3F3xs=; b=b rHS+099t8Kc/t/flpjNiihwTN/9t5/LXwmVvWiRsyrx5+6YWgZMncookB+HbvZK4 GxubQUwPDWTZITYQtgcJPmELfj0xTsDutfDey6KfKUnMuIMImnMP1B6PkFcjd6Ks xaISpik+EbNe6rVlMi4CvkQApHeWAwjJoXvE7AOvXlswWr8BRB7wzGiG34CSX9W9 wfJYfE3jc73h0dktKK8TCXK+cBMDBZhZ44sB0IBCGhSWd3x8KuJcoWOzp9FWW41h 2MCatagIp+Vhv/xSW+gyhaCtv2cJyJIyNwKQ8b5j9zew1/RoreKib8r9JJJCITgL 8JNJ3RJH3krPIJ+3J/qcw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtdekgddutdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpeegtddtleejjeegffekkeektdejvedtheevtdekiedvueeuvdei uddvleevjeeujeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 2 Dec 2022 14:41:18 -0500 (EST) From: Thomas Monjalon To: Andrew Rybchenko , Hanumanth Reddy Pothula Cc: "dev@dpdk.org" , Aman Singh , Yuying Zhang , "dev@dpdk.org" , Jerin Jacob Kollanukkaran , Nithin Kumar Dabilpuram , "rasland@nvidia.com" , "orika@nvidia.com" , "viacheslavo@nvidia.com" Subject: Re: [EXT] Re: [PATCH v3 1/1] app/testpmd: control passing Rx metadata to PMD Date: Fri, 02 Dec 2022 20:41:15 +0100 Message-ID: <8148001.T7Z3S40VBb@thomas> In-Reply-To: References: <20220802175151.2277437-1-hpothula@marvell.com> <6437234.G0QQBjFxQf@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/12/2022 17:14, Hanumanth Reddy Pothula: > -----Original Message----- > > 27/10/2022 09:34, Thomas Monjalon: > > > 17/10/2022 10:32, Andrew Rybchenko: > > > > On 10/6/22 21:35, Hanumanth Pothula wrote: > > > > > Presently, Rx metadata is sent to PMD by default, leading to a > > > > > performance drop as processing for the same in rx path takes extra > > > > > cycles. > > > > > > > > > > Hence, introducing command line argument, 'nic-to-pmd-rx-metadata' > > > > > to control passing rx metadata to PMD. By default it=E2=80=99s di= sabled. > > > > > > > > > > Signed-off-by: Hanumanth Pothula > > > > > > > > Acked-by: Andrew Rybchenko > > > > > > > > Applied to dpdk-next-net/main, thanks. > > > > > > I'm not sure this patch is really acceptable. > > > It is disabling Rx metadata by default just for benchmarking reason > > > because your driver is doing some processing even if metadata is not > > required. > > > > > > From a user perspective, if a command requesting metadata is entered, > > > it won't work until we enable this new option on startup. > > > It looks terrible. > > > > > > Please tell me I misunderstood something. > >=20 > > While pulling, I see that the name is not compliant with others. > > I think it should start with "enable-", use hyphens and be sorted. > >=20 > > I'll drop it from the pull for now, we can have it in -rc3. > >=20 >=20 > @Thomas Monjalon I missed your comment, sorry for the delayed response. >=20 > Sending Rx metadata to PMD is added recently, which breaking our driver p= erformance. =20 > Normally any feature added to testpmd will be disabled by default, to mak= e sure it won't affect other code(PMD).=20 > Hence adding new testpmd command line argument to disable this feature by= default.=20 No, disabling by default doesn't mean you should enable with option. It should be enabled if required by a command.