From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-000f0801.pphosted.com (mx0b-000f0801.pphosted.com [67.231.152.113]) by dpdk.org (Postfix) with ESMTP id 60DD928EE for ; Mon, 22 May 2017 15:20:56 +0200 (CEST) Received: from pps.filterd (m0048192.ppops.net [127.0.0.1]) by mx0b-000f0801.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v4MDG6Lj030420; Mon, 22 May 2017 06:20:55 -0700 Received: from brmwp-exmb12.corp.brocade.com ([208.47.132.227]) by mx0b-000f0801.pphosted.com with ESMTP id 2aktcgh3rg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 22 May 2017 06:20:55 -0700 Received: from [10.252.136.13] (10.252.136.13) by BRMWP-EXMB12.corp.brocade.com (172.16.59.130) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 22 May 2017 07:20:53 -0600 To: Ferruh Yigit , References: <1495044215-16915-1-git-send-email-ciwillia@brocade.com> <1495044215-16915-2-git-send-email-ciwillia@brocade.com> <4fdc5000-66c1-ff96-6330-20a3cc92d900@intel.com> CC: From: "Charles (Chas) Williams" Message-ID: <814c1db3-0be7-b18e-f6cd-0cb6acb8728c@brocade.com> Date: Mon, 22 May 2017 09:20:52 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <4fdc5000-66c1-ff96-6330-20a3cc92d900@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: hq1wp-excas13.corp.brocade.com (10.70.36.103) To BRMWP-EXMB12.corp.brocade.com (172.16.59.130) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-05-22_09:, , signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705220069 Subject: Re: [dpdk-dev] [PATCH 2/3] net/af_packet: add accessor for iface X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 May 2017 13:20:56 -0000 On 05/22/2017 05:39 AM, Ferruh Yigit wrote: > Hi Chas, > > On 5/17/2017 7:03 PM, Charles (Chas) Williams wrote: >> Provide an accessor for the name of the underlying linux interface >> used by the AF_PACKET-based interface. > > This patch provides a PMD specific API to get PMD internal data > (internals->if_name). > > I think we should avoid PMD specific APIs if possible. > > internals->if_name is provided by application, as devargs to af_packet > (iface=..), so app already knows port_id -> if_name mapping. > > OR > > With rte_eth_dev_info_get() af_packet returns the if_index for > underlying interface, it is possible to use if_indextoname() to get ifname. > > Because above methods exists to get if_name, I think this API is not > necessary. I will go this route then. >> >> Signed-off-by: Charles (Chas) Williams > > <...> >