From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 7CC192E8A for <dev@dpdk.org>; Wed, 12 Apr 2017 14:31:58 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id w64so86650350wma.0 for <dev@dpdk.org>; Wed, 12 Apr 2017 05:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=v5taMuyuQqbApmpe0ae88Gj8mpr/8Dh9NvePfhhHeH8=; b=lJSh+dGc3mhqshUSAfS9Yh9TKmUai3v2teafNVPlJ84MtXCz42EWjhMR80ov0BulMo BoUA4MWMfi792OUl3Im6+o355gSHCdWiRoMBrOu1auxyLj62RCRbkRA9MZ9faLBBJzYr BVhBUDk6u3p893Hl4xNz71bRXACm/IlZXCnIhdFzD0VGsI4uT1oJRlvh+/0GOPTabBvq oK+ew/QbS46z4Y2WpW+5Ss0OL3DxhHEm6ajJgNNPlDvQl/7306HjhMWMuY31DGPT7Tyu JzZyCTDFLVKDUOB6VqbicvkUaXSXDF3gAHaozptO7Foj3yebGJqPq39cUVyi/CbA8L3g vAEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=v5taMuyuQqbApmpe0ae88Gj8mpr/8Dh9NvePfhhHeH8=; b=gOvQx6cml4Ljx/HPvD2f7Ah3rj+gYNLmjQUK/rTujieV0URS+zDcLliMU5nffEC+Qe HcW1udggZ+vB/nSMdBPeZ+n+LN+y6g3g9Ca9Ml58eVo+4q6yjS0NgFMGIqDEMFnnR3cH MhhS42yn0I6l8YLk49N3PCOSq7KTDH1EvcOrQxLBVHSeH2PwFx2E0s7bVmYcFKy5XmE8 KsDzxox8kbmNWrrfzrbTrC76rjy5JFmugtzvpbQdLgCy9DkzGfE7X/eRQQgICX7ZuBl1 LmQS5QFE9hnUKcRvoR8X6i8lEbxB28jm/gyBy83YfdY0eNbnmDQabNvvevc1M5QQg+S5 SeZQ== X-Gm-Message-State: AN3rC/4Y57RwaB3rCQ2s8Co5a/Ee4BW6BBu0i7JUgJNtfqG5a9texTT0 BKkpa6aQER89q6vF X-Received: by 10.28.9.76 with SMTP id 73mr13498272wmj.93.1492000318121; Wed, 12 Apr 2017 05:31:58 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id u189sm6439561wmg.18.2017.04.12.05.31.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Apr 2017 05:31:57 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: "Richardson, Bruce" <bruce.richardson@intel.com> Cc: Shreyansh Jain <shreyansh.jain@nxp.com>, john miller <john.miller@atomicrules.com>, dev@dpdk.org, "olivier.matz@6wind.com" <olivier.matz@6wind.com> Date: Wed, 12 Apr 2017 14:31:56 +0200 Message-ID: <8154073.47RD1mYHR3@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <59AF69C657FD0841A61C55336867B5B06675640D@IRSMSX103.ger.corp.intel.com> References: <357262EF-AA7B-4064-963E-FF130E4607E6@atomicrules.com> <VI1PR0401MB24644620D86665DC93E8073F90030@VI1PR0401MB2464.eurprd04.prod.outlook.com> <59AF69C657FD0841A61C55336867B5B06675640D@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 12 Apr 2017 12:31:58 -0000 2017-04-12 11:31, Richardson, Bruce: > > > -----Original Message----- > > From: Shreyansh Jain [mailto:shreyansh.jain@nxp.com] > > Sent: Wednesday, April 12, 2017 12:02 PM > > To: Richardson, Bruce <bruce.richardson@intel.com> > > Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; john miller > > <john.miller@atomicrules.com>; dev@dpdk.org; olivier.matz@6wind.com > > Subject: RE: [dpdk-dev] error in testpmd when > > CONFIG_RTE_BUILD_SHARED_LIB=y > > > > > -----Original Message----- > > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > > Sent: Wednesday, April 12, 2017 4:12 PM > > > To: Shreyansh Jain <shreyansh.jain@nxp.com> > > > Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; john miller > > > <john.miller@atomicrules.com>; dev@dpdk.org; olivier.matz@6wind.com > > > Subject: Re: [dpdk-dev] error in testpmd when > > > CONFIG_RTE_BUILD_SHARED_LIB=y > > > > > > On Wed, Apr 12, 2017 at 11:38:55AM +0100, Bruce Richardson wrote: > > > > On Wed, Apr 12, 2017 at 10:33:10AM +0000, Shreyansh Jain wrote: > > > > > My bad - I was too quick in replying - some clarification beneath. > > > > > > > > > > > -----Original Message----- > > > > > > From: Shreyansh Jain > > > > > > Sent: Wednesday, April 12, 2017 3:55 PM > > > > > > To: 'Bruce Richardson' <bruce.richardson@intel.com> > > > > > > Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; john miller > > > > > > <john.miller@atomicrules.com>; dev@dpdk.org; > > > > > > olivier.matz@6wind.com > > > > > > Subject: RE: [dpdk-dev] error in testpmd when > > > CONFIG_RTE_BUILD_SHARED_LIB=y > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > > > > > > Sent: Wednesday, April 12, 2017 3:35 PM > > > > > > > To: Shreyansh Jain <shreyansh.jain@nxp.com> > > > > > > > Cc: Thomas Monjalon <thomas.monjalon@6wind.com>; john miller > > > > > > > <john.miller@atomicrules.com>; dev@dpdk.org; > > > > > > > olivier.matz@6wind.com > > > > > > > Subject: Re: [dpdk-dev] error in testpmd when > > > CONFIG_RTE_BUILD_SHARED_LIB=y > > > > > > > > > > > > > > On Wed, Apr 12, 2017 at 04:52:47AM +0000, Shreyansh Jain wrote: > > > > > > > > > -----Original Message----- > > > > > > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > > > > > > Sent: Wednesday, April 12, 2017 12:58 AM > > > > > > > > > To: john miller <john.miller@atomicrules.com> > > > > > > > > > Cc: dev@dpdk.org; olivier.matz@6wind.com; Shreyansh Jain > > > > > > > > > <shreyansh.jain@nxp.com> > > > > > > > > > Subject: Re: [dpdk-dev] error in testpmd when > > > > > > > CONFIG_RTE_BUILD_SHARED_LIB=y > > > > > > > > > > > > > > > > > > 2017-04-11 14:02, john miller: > > > > > > > > > > > > > > > > > > > > We are seeing an issue when running from the head of the > > > > > > > > > > master > > > > > > branch > > > > > > > in > > > > > > > > > dpdk-next-net and building with > > CONFIG_RTE_BUILD_SHARED_LIB=y. > > > When > > > > > > we > > > > > > > run > > > > > > > > > testpmd using -d to point to our PMD we get this error > > > > > > > > > > > > > > > > > > > > EAL: Error - exiting with code: 1 > > > > > > > > > > Cause: Creation of mbuf pool for socket 0 failed: > > > > > > > > > > Invalid > > > argument > > > > > > > > > > > > > > > > > > > > This error occurs as a result of the rte mempool ops > > > > > > > > > > table > > > having 0 > > > > > > > > > entries. This table is populated from a call to > > > > > > > rte_mempool_register_ops(). > > > > > > > > > This function gets called in rte_mempool_ring.c via the > > > > > > > > > static > > > > > > > initialization > > > > > > > > > MACRO MEMPOOL_REGISTER_OPS and exists in > > librte_mempool_ring.so. > > > > > > However > > > > > > > > > this library is not loaded when the rte_eal_init() gets > > > > > > > > > called so > > > the > > > > > > > static > > > > > > > > > initializers are not yet loaded. > > > > > > > > > > > > > > > > > > > > I am requesting advice on the proper way to repair this. > > > > > > > > > > > > > > > > "-d" the ring library (rte_mempool_ring) - just like any > > > > > > > > other > > > shared > > > > > > lib. > > > > > > > > > > > > > > > > > > > > > > I think this is a bug that should be fixed. The user should > > > > > > > not need > > > to > > > > > > > have to specify a mempool driver just to get testpmd working, > > > > > > > so I > > > think > > > > > > > the ring handler as default should be compiled in > > > > > > > automatically so as > > > to > > > > > > > allow regular mempools to just work as before. > > > > > > > > > > > > For Ring Mempool as default enabled, +1 > > > > > > > > > > Actually, Ring mempool is enabled by default. But, obviously for > > > > > shared > > > library case, this still means "-d". > > > > > > > > > > > > > Not necessarily. That only applies if we don't explicitly link it > > > > like the other shared libraries. We "special-case" our drivers in > > > > that we don't add them with a -l flag, but expect the user to > > > > dynamically load them at runtime. This is one case where I think all > > > > apps should explicitly link against the ring mempool driver. There > > > > is no reason we can't make some drivers mandatory. > > > > > > > > > > > > > > > > > > > > > > > > > This change was done recently to move ring handler into its > > > separate > > > > > > > drivers/mempool/ring directory. That also means it no longer > > > > > > > is > > > compiled > > > > > > into > > > > > > > the librte_mempool. > > > > > > > > > > > > > > > > > > > > > > > > > > We should just add a better error message if no mempool > > > > > > > > > driver is > > > > > > > available. > > > > > > > > > > > > > > > > Yes, that is something to be improved. > > > > > > > > > > > > > > This should be fixed by always having a mempool driver > > installed. > > > > > > > > > > > > Agree. > > > > > > > > > > Probably, as ring mempool is a driver and compiled in shared mode, > > > enabled by default will not fix this. > > > > > > > > But linked in by default will fix it. > > > > > > > And as follow-up to my own mail, I think we can actually go further > > > here. Mempool is a core library, and very little can be done in DPDK > > > without it. It's also not what most people would think as needing a > > > driver loaded, so from a usability point of view, I don't see why we > > > shouldn't link in all mempool drivers by default, like we do other libs. > > > It will make users life easier, and I can't see any downside to doing > > > so - they are just .so's after all! > > > > I don't have a particularly strong opinion against this. > > For static build, we are already 'there' - mempool would be linked in with > > testpmd. > > For Shared library, the idea is to have small footprint and leave it to > > user to link what is required, and what is not. > > > > Still, for usability sakes, we have three options: > > 1. Link all library - which might be more than just ring (stack, more to > > be added soon...) 2. Only link ring by default - because that is also > > being used as default option when creating the mempool (ring_mp_mc) 3. > > Don't link any > > > > (3) is a cleaner approach, but may not be a good usecase. But, going by > > (1) would mean linking in unused mempool handler by default (yes, user > > could always say 'n' in config file). > > > > So, if we are going to select the mempool as inbuild, we might as well > > have it only for Ring (2). > > > > It's more important to make DPDK useful than to make it idealistic. :) > > > > I'm ok with option 2 or 3. I think the default mempool could be linked. I don't know how easy it is to transform CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS="ring_mp_mc" into -lrte_mempool_ring Anyone for a patch?