From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 58C0ADE0
 for <dev@dpdk.org>; Mon, 13 Jul 2015 18:21:22 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so34310722wib.1
 for <dev@dpdk.org>; Mon, 13 Jul 2015 09:21:22 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=R01CZRIuqzEcMeMoZFZq/xNEaanvsmN4RnnUoqIXi/E=;
 b=Np5K3H8OLgAuLQ5jXEiGG1GB/EzZbOy8wJCgJxUvhxQw5fyyP2oDYgXRmVn0iDuqGd
 3CoGpC5vIsojRh7XBv20K7jpMUFUMTKV8UAKFOAwnLXyzq8qId7GkmvdfNtUHibw2zse
 PYyLlu1ABMhbHqOWwoQ2k/Cgb8iGmOBzm7jhCRp2IX3eUmb701F5d4gsMWxU2HV4ojqN
 PSa11wrJpGvXvTaKI0tcoPrIAe5ILe8bUnUEXBhexPsjAOlAyq5Qll50IPS+sO7Gz3Ou
 zWqTqu6j6XAteogfBNCH7DLwKeWRBrR9wM+7D4HKAoUb0/VouqrgSMfilbuZ68agJeb/
 uvmA==
X-Gm-Message-State: ALoCoQk1x85YBAbNz0k3/Y3DnDOZkmDRbps+e4iX88pgv4ln3c17yPnjZc0UvW8tf739+ovDU1t5
X-Received: by 10.180.198.178 with SMTP id jd18mr24369955wic.14.1436804482194; 
 Mon, 13 Jul 2015 09:21:22 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id ym2sm30026819wjc.44.2015.07.13.09.21.20
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 13 Jul 2015 09:21:21 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Date: Mon, 13 Jul 2015 18:20:08 +0200
Message-ID: <8164644.CYfKgKpKoo@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <20150713161420.GB6932@bricha3-MOBL3>
References: <1436571020-16252-1-git-send-email-pablo.de.lara.guarch@intel.com>
 <20150713161154.GA6932@bricha3-MOBL3> <20150713161420.GB6932@bricha3-MOBL3>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 1/7] hash: replace existing hash library
	with cuckoo hash implementation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jul 2015 16:21:22 -0000

2015-07-13 17:14, Bruce Richardson:
> On Mon, Jul 13, 2015 at 05:11:54PM +0100, Bruce Richardson wrote:
> > On Mon, Jul 13, 2015 at 12:29:53AM +0200, Thomas Monjalon wrote:
> > > 2015-07-11 01:18, Pablo de Lara:
> > > > The main change when creating a new table is that the number of entries
> > > > per bucket is fixed now, so its parameter is ignored now
> > > > (still there to maintain the same parameters structure).
> > > 
> > > Why not rename the "bucket_entries" field to "reserved"?
> > > The API of this field has changed (now ignored) so it should be reflected
> > > without changing the ABI.
> > 
> > Since the hash_create function is itself already versionned to take account of the
> > new struct parameter, there is no reason to keep the field at all, as far as I can see.
> > We can just drop it, and let the ABI versionning handle the change.
> > 
> > /Bruce
> 
> Sorry, my mistake. It's no longer versioned in the patchset that was merged, so
> the field does need to be kept. :-(

So do you agree to submit a patch which rename the unused field?