From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EFDF943A39; Thu, 1 Feb 2024 13:02:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B2EF40299; Thu, 1 Feb 2024 13:02:09 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2089.outbound.protection.outlook.com [40.107.100.89]) by mails.dpdk.org (Postfix) with ESMTP id 2D42E4021D for ; Thu, 1 Feb 2024 13:02:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BNDCccKrmMBmCTw+cXXMmYYR/LsD2u3mbraFnj4NjxR1I4Le/h91x7pxBtOs79MnyF8oiFT65kSTN7CCPDjIKhZB+fD0EY0oLI/DWjlH105xKNz5RMBWkCy1/3SRCObbYMi5rdnEIBZCulBI/DzxtPw4AOgW6EUkcywsByzW1eNB3E2Gq6DI4MWl7Jdqt6NGdiPBTnS8MP4x+ixPJkGSHABjbJwG73jHzRarokZAApr6QtAPf1n+EWf8ecM1sq2jh+CXZw3edW/ch2lIEBHNjPq+sVcYcC0C/dbAJeLKIw9e9goVQaicyt7h4O0XmAqQnCIAScxShRLHIsiAEMer5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wgl89X763NFjsa3Pcn15IKcyeqhJ/pvQ1sUid0EeyhY=; b=kk0JuYl3aM++vnz/8obJCsjXPCbiCLmDiPAWwkt5zmF9GilDWgk2HjEgGJwPJ0+QLXnOXgUXSfbMoPYF6CxG+5/1Hk6Gu2wW6rWkb9sKWrznjhS+thpzS05pkHCxrcvX6TxMg87a5A22W6z861/omInlzKlM2EZZf6EeBYuH50juabmPo9c5wPvzN3/SUZYRi6zAAct8SP531+2Eh2Lyy9v0SpNDemDdKPgZI3FsJgzEZa3glari4O029rXjbGMcsnM3IRxg3eAWO712RaMmw2s0sXOu05FHyV4DV/jo/a7gVd+/sfI4her1cO09fEEIKl5jyQuE+Dh1uTC81iMZeQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wgl89X763NFjsa3Pcn15IKcyeqhJ/pvQ1sUid0EeyhY=; b=IbcaFPlb/LYD/X89o1k2x7cPKw94qfTslVmXKslmHT2guPQNy0y+bM5ujZuoeXbD0zWYvdLLi9akk32I0PSYcXsaUfHHxzjfD/ppmN+FKQD0YIleazbkdVR+QYvxw9TSAEinTqWrcDQEiDTQaHVQhpuypxLGOfvlHa9CIbTz2rE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from PH7PR12MB8596.namprd12.prod.outlook.com (2603:10b6:510:1b7::6) by DS0PR12MB8295.namprd12.prod.outlook.com (2603:10b6:8:f6::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.9; Thu, 1 Feb 2024 12:02:05 +0000 Received: from PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::120d:8f4f:a6d2:606f]) by PH7PR12MB8596.namprd12.prod.outlook.com ([fe80::120d:8f4f:a6d2:606f%3]) with mapi id 15.20.7228.029; Thu, 1 Feb 2024 12:02:05 +0000 Message-ID: <816f2208-d6ac-4aab-a352-0a2fb8f030c1@amd.com> Date: Thu, 1 Feb 2024 17:31:57 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] cfgfile: increase value length To: David Marchand Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, Ferruh Yigit , Bruce Richardson References: <20231206112952.1588-1-vipin.varghese@amd.com> Content-Language: en-US From: "Varghese, Vipin" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR02CA0027.apcprd02.prod.outlook.com (2603:1096:3:18::15) To PH7PR12MB8596.namprd12.prod.outlook.com (2603:10b6:510:1b7::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR12MB8596:EE_|DS0PR12MB8295:EE_ X-MS-Office365-Filtering-Correlation-Id: 0c5b14f9-2486-4437-b850-08dc231d9b4f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FjlreLmpVKMzNvejde/7KfRFpvqjganjzFq47ddHfU+o8fGOR9lkieyQMqze7bR+HTtrlKqkD2M5OHPtdq4deCDzXBnQi/GhUQxB6Czx1j62G6RYSV/ic4vsm0CG/m3ynKC779CdlNKN6P8SCmWV4udKnkY5AlW+qF2w9+900/kUulLAS47d+hFjYuiLPG5bAwABQ2Yp8nJ71yUMuJwTMMUyMgktmfG2+ykbHGVBLz7JhyiMUf1xCL/PBCRYkpTNNbAGFjHvcNb1j/vDkDSoHxa3ZW1uCQsMzzIg458h6KjNqg/7/nanXlMSQYtz4g4edIlJ1hcYH3vYACrB+iJ4RRFwSvLSOauIPrLF7+rjgD2k5gBU814gpW1m+FE7WnJa+mygqBk5KoCNwcUIfNyEVQFaGxqvuRfuEnpGXqu8W44MBi/Ftyc9Bp3O73ktKwvXTblP9eXvBsem59yBZbHnBMJtHT13dyIU5ZC6NB09saidabnJkr7qCAbIrzAkF+3JfUzQl5m2rZS6BPXGacewxfRPNmKRkdj92z1qeghijjmAL+NtSMFp9IuHlym0cHrZypfEzsd5ntI0RjBYmmATZupRvDEkkTb2bJsZ8HZNKP4hOIEqg0TBLyp9FcUJygV2PMzpcju27SghMO1ZunnWGX+dLImpMtvjL7G1zWoB7c2y9LqW8ywka5JJSumBSzVU X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR12MB8596.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(39860400002)(396003)(366004)(136003)(230922051799003)(230273577357003)(230173577357003)(186009)(1800799012)(451199024)(64100799003)(2906002)(5660300002)(8676002)(4326008)(31686004)(8936002)(6512007)(2616005)(316002)(66476007)(54906003)(6916009)(66946007)(66556008)(6506007)(6486002)(6666004)(966005)(478600001)(53546011)(26005)(83380400001)(38100700002)(41300700001)(86362001)(31696002)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SWhyN0FwelVKUHRFTnFjM2F5REZmZTBJQWRqaDBOTHYvVVFQQ0lNaHljVDdk?= =?utf-8?B?Q3c0SmlUT1hoWG9YSEVTVHJoN0RkdCswcVBSOEV4emxvUEFrNTk1SVFKcEQx?= =?utf-8?B?NE5TQ2JQMGNJYVFQeGFiYUpZVFR6V0JjYjhJV1VtYzl2T01LeXlPb21SNnhM?= =?utf-8?B?R0ZjNzN3ZnAwU3p0Rk9SdGxYUDhVTlN2M2ozMjhXZWJyRk9rMGpYdGtuUWVt?= =?utf-8?B?bzl1akZaL3krM0dYM1RyZitmYXhOaCtCUzZCdExXeHZnWGVOK1p5TTBQaVFP?= =?utf-8?B?dWs3bXZ2Y1YwSkpyaG5DcS90VGUzam9QR2FjbUpOdW1CbWZyZzNjR3lveUx3?= =?utf-8?B?aEc1Z0xwZS9pWTVPNnF4OWU1QTJuejNoOHZOaG9tOVVDN2JxQlBDOFRPQ0Vt?= =?utf-8?B?bWgzQ0hsdXRhL3BLbmpUall5N3JPOUtoUHRKTjJLK0NhU0R3bW9ob2xqa2Jl?= =?utf-8?B?dnlFc3hPODNxNm1SMHVJbUlTVTRSSTBZcUIwcHpXZkNGTFNGcTNmaVRUWmpT?= =?utf-8?B?U0I3bmlMaVNLcHFmdWFKQVA2N3l2WGpSTkFzK2l5OGhCRzZreDdDTHlRLzBQ?= =?utf-8?B?bVoxSThQR3M2UTREcHR4YWtLdGU4Zi8wczFPaTk2L0k2ZGZ5YnBKL2JRL2pv?= =?utf-8?B?UDY0cGRtS0JyQjY5d2JkRkZlV2xiSWdKamxpejllOTYzdDZ1akVGUTJiYzdW?= =?utf-8?B?WEZvSHlWbXZob1FSaGwwT0tXeVY5SXArRFBWeVJ0VW5KUjgwb3M1M3hFekE1?= =?utf-8?B?TmUxS0JaYnE0eVZoMVRVaDFHVk5lY0pZbHZMYmVERU9qb1lkQXJ4b2xXWnNj?= =?utf-8?B?dXA2a1h5ZmNURVNka3MzbFd3MHE2aUNTY3k0ckxqNk83dk5aVnZTd1htTTZr?= =?utf-8?B?dUJhSnB2S3dCN1RNR0hrNFJtNHlsWEJ4SXVkOUVQdW0yRkZnNUROaTB2bVJm?= =?utf-8?B?Z05VemtEZUJBSE1taytPdmVXVEZGNTl3akRoaUpGZHJWTEh0YmFQZDRjUVlK?= =?utf-8?B?OFJSYkpOdTFEWktycVRld2hPLzFnTHBSQzBaUHhRK0FpMldyTlQ1YnprdEMy?= =?utf-8?B?SW5wU0lOdTVQcGI0OVI2Y3poR2xLTnFZblArUDNqZ0NRN0FpVEtTaVYyY2xs?= =?utf-8?B?QnZjYzBpaFMrYitvdk1IZTB1ckRUWWJTb0h6bEgrdzFyU3MzeHJFckZLUzV3?= =?utf-8?B?WVl2MGJBQUNpYXd4SXZ5d0ZvTlhQd2luL2ZnRzJaSHFGSTZ3eUxMd1VaeklX?= =?utf-8?B?Q3dHRjU4QTI2ckJsazZ3MHpoc0FUajFPNHVqS0NvZ08xdU9VY0xWbkF3WGk5?= =?utf-8?B?bDRFb25HbDMrNHNOU2FFSGJ0THFkR1JlUnQ4RkExblFEdURmV0xKWEcrajdh?= =?utf-8?B?Z29mY09yd2x1RjhsUVpmMzE2dE9TSzJIMGdJRXhTTjk1ak42NlpjNGhLSFJS?= =?utf-8?B?ektXcm5MQmthS3hxb1kzQTIxeVYvNGtzaWlNQjdLbzFjNG12OERzVHJhLzI0?= =?utf-8?B?aVBjNHFOQVVhbnNGTEl4Y2RIWHFEZlVhYlhNaWR5VVYwbHExZ1BJZHkxNkFz?= =?utf-8?B?N2hDY3pVL0hYaGFZT0t3WlhlOVdsdFpJbXRvamJWT05nOFc4czVQRnM4TkZn?= =?utf-8?B?MVJrL1l1VExiRE1JVnk1aS9SQ0N3eThRY1ZLeTZKcHY1VEN3dXFmUytiVm9L?= =?utf-8?B?QmtPNDVRbUQzaXZqcktyN1dRaTNFYWcyOXRnVExkekloT1lIa2xnM3Z5eVBh?= =?utf-8?B?eWVHRnQrTVZUajU0N1dRVXNLN2xzUmxXZHRKWUR4TlcxRTY4YjdmUkl4aTJ3?= =?utf-8?B?Nnp0VkZ4bEJ2eDBKTGJpclJoMHlySGdDRkNLYlllSVpLdFVMUjlWUXFtMGEy?= =?utf-8?B?VXB0NGpUNWVmQk9rcVJPRHdPaXBTVVhKMTZIZHpNcW11L01qSzRwUTF3QVZO?= =?utf-8?B?QkRIVy80Kzg4MVp2bUU2L1VkeWF4eWNrY2M3ekNKTnlnVUNrR2V6WVY1cHFp?= =?utf-8?B?RGdGcW56ekIrVFFNOU5Xd21LbDRXeGVPbjZFQXJNb0lOOW5udytDdDJkM1Nz?= =?utf-8?B?UDN6Qm9PT2x1M2ZTQ3NTbGtYRFpiVGUrYmg4aVQvRnpsZVVBRFpIb0RVbXU1?= =?utf-8?Q?WFo3xIdTlJfz+w7vQ/91DOrcv?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c5b14f9-2486-4437-b850-08dc231d9b4f X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB8596.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2024 12:02:04.9569 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IdFi2lHIbCPOkIwOCn7RkbJ+sagwgkJmuUJKyl03C27JAjMtEBBZzIXJ9fGuznwioJyCBUP+uZpOG4dgm7FeuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8295 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/1/2024 4:02 PM, David Marchand wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > On Wed, Dec 6, 2023 at 12:31 PM Vipin Varghese wrote: >> The default value for CFG_VALUE_LEN is set to 256 characters. >> This limits the parsing for longer strings in configuration file. >> Setting the default to 2048 characters increases the value array >> size in `struct rte_cfgfile_entry`. >> >> Files using cfgfile library are >> 1. drivers/net/mvpp2/ >> 2. app/test-dma-perf/ >> 3. app/test/ >> 4. examples/qos_sched/ >> >> The structure `rte_cfgfile_entry` is not included in DPDK libraries. >> Modifying from 256 to 2048 allows `app/test-dma-perf/main.c` helps to >> parse longer string as shared in https://bugs.dpdk.org/show_bug.cgi?id=1333 >> >> Signed-off-by: Vipin Varghese >> Suggested-by: Ferruh Yigit >> --- >> lib/cfgfile/rte_cfgfile.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/cfgfile/rte_cfgfile.h b/lib/cfgfile/rte_cfgfile.h >> index 232c65c77b..401353c44e 100644 >> --- a/lib/cfgfile/rte_cfgfile.h >> +++ b/lib/cfgfile/rte_cfgfile.h >> @@ -24,7 +24,7 @@ extern "C" { >> #endif >> >> #ifndef CFG_VALUE_LEN >> -#define CFG_VALUE_LEN 256 >> +#define CFG_VALUE_LEN 2048 >> #endif >> >> /** Configuration file */ > Last time I looked at this code, I had the impression such a change > would break the ABI. Thanks David, Internally & 7 Dec 2023 based on the covnersation email from Bruce & Cristian; the new approach DPDK community should be taking is not to use comma seperated DMA instance. Instead make DMA instances like `dma-1:, dma-2:, dma-3 ... etc`. > > I see that the discussion stopped at a suggestion to change some parsing logic. > For now, I marked this patch as Changes requested. I will make this deffer-ed or close the same. > > Thanks. > > > -- > David Marchand >