From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 08B71374C for ; Mon, 20 Nov 2017 14:07:16 +0100 (CET) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20171120130714euoutp01b160e0227584c3402914b5878891a680~4zSVIORjQ2881628816euoutp01E; Mon, 20 Nov 2017 13:07:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20171120130714euoutp01b160e0227584c3402914b5878891a680~4zSVIORjQ2881628816euoutp01E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1511183235; bh=SfYOtT9IJrcjcVGK35/2EceajFx43fwsbvLX/0HY5k4=; h=To:Subject:Cc:From:Date:In-reply-to:References:From; b=tJb+5CpArxooxp3Tw494OWzZ32sfE8oOlJkJHRemHvRHwxtc+FxKHqFnPIgAMFm0U 6cTNkllaQLaacjFZZLomXPD7jS/ZKiR6fvuJ3bVJS922eW0fuo+PW8n6/s+6YldJ6m 37YlzISEQZm1kz1KQkM54OGOgaqa6uRoNvJNJxk0= Received: from eusmges2.samsung.com (unknown [203.254.199.241]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20171120130714eucas1p2d81ebb5ab6b1ed64d39337ae92216434~4zSUg3iK92764327643eucas1p2R; Mon, 20 Nov 2017 13:07:14 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2.samsung.com (EUCPMTA) with SMTP id 3A.60.12907.183D21A5; Mon, 20 Nov 2017 13:07:14 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20171120130713eucas1p21960847cb6dd2927200d623d4fcf27b8~4zST5YxIw0725807258eucas1p2e; Mon, 20 Nov 2017 13:07:13 +0000 (GMT) X-AuditID: cbfec7f1-f793a6d00000326b-2d-5a12d3815b64 Received: from eusync2.samsung.com ( [203.254.199.212]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 6C.89.18832.183D21A5; Mon, 20 Nov 2017 13:07:13 +0000 (GMT) Received: from [106.109.129.180] by eusync2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0OZP0054IWFUME70@eusync2.samsung.com>; Mon, 20 Nov 2017 13:07:13 +0000 (GMT) To: dev@dpdk.org, Gellert Babel Cc: Jan Wickbom , Jan Wickbom , "Tan, Jianfeng" , Yuanhan Liu , Maxime Coquelin From: Ilya Maximets Message-id: <8180d5a9-cf2a-09ad-9a9a-6b1e5bac8007@samsung.com> Date: Mon, 20 Nov 2017 16:07:06 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-version: 1.0 In-reply-to: <1511161153-5127-1-git-send-email-gellert.babel@ericsson.com> Content-type: text/plain; charset="utf-8" Content-language: en-GB Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMKsWRmVeSWpSXmKPExsWy7djPc7pNl4WiDE7sY7F492k7k8Wq6T+Z LK60/2S3WLH1KLNF9+wvbBbHOvewWLQs2cnkwO7xa8FSVo9fX6+yedz4d4vNY/Gel0we7/cB uX1bVjEGsEVx2aSk5mSWpRbp2yVwZUz4V1Zwmq+i88xNlgbGm9xdjJwcEgImEmu629kgbDGJ C/fWA9lcHEICSxklzm8/wg6SEBL4zCjx7LByFyMHWMP5pcoQNcsYJXpW7YFqeMEo0ffkJFiD iICNxLLD38BsYYFgieenDzGCFDELXGGUeHjvOwtIgk1AR+LU6iOMIDavgJ3Ewet7WEFsFgFV ifZP28BsUYEIiQubfjJB1AhK/Jh8D6yXU8BL4tq+l2BxZgFNiRdfJrFA2OISx+7fZISw5SU2 r3nLDLJYQuAxm0Tz0u2MEC+4SHxvNYB4WVji1fEt7BC2jERnx0EmiPpmRomGVZcYIZwJjBJf mpczQVTZS5y6eRVqM5/EpG3TmSGG8kp0tAlBlHhIPHu+mhHCdpTofb2bERJEcxklur60sE9g lJ+F5KFZSJ6YheSJWUieWMDIsopRJLW0ODc9tdhIrzgxt7g0L10vOT93EyMw6Zz+d/zjDsb3 J6wOMQpwMCrx8H7gEYoSYk0sK67MPcQowcGsJMKrFgUU4k1JrKxKLcqPLyrNSS0+xCjNwaIk zmsb1RYpJJCeWJKanZpakFoEk2Xi4JRqYGT9fT3j59XnG37JHcgKWS7cEXjJeUHoG/uL86Yz bJ3+pvbsoV37s/wDE23P8XksP6B9/uCz3wvXpO5/vtdj/ge3ON7p/uzb9TNE+b9Uhr9ozunw mvz/k+28EIWThc3Sl3pjbm3UZ1gvPlV3ulrH1xP/nj9yczhrEs9Q9t5fcFnMylmL/J/vTFiu xFKckWioxVxUnAgAq+A4BzYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrKLMWRmVeSWpSXmKPExsVy+t/xK7qNl4WiDBoXqVm8+7SdyWLV9J9M Flfaf7JbrNh6lNmie/YXNotjnXtYLFqW7GRyYPf4tWApq8evr1fZPG78u8XmsXjPSyaP9/uA 3L4tqxgD2KK4bFJSczLLUov07RK4Mib8Kys4zVfReeYmSwPjTe4uRg4OCQETifNLlbsYOYFM MYkL99azdTFycQgJLGGUmD9hIjuE84JR4vTaB+wgVSICNhLLDn8Ds4UEPCW+r/jHBmILCwRL PD99iBGkgVngCqPEi71nmEASbAI6EqdWH2EEsXkF7CQOXt/DCmKzCKhKtH/axgpyhahAhMSG jfwQJYISPybfYwGxOQW8JK7te8kEUsIsoC4xZUouSJhZQFzi2P2bjBC2vMTmNW+ZJzAKzkLS PQuhYxaSjllIOhYwsqxiFEktLc5Nzy021CtOzC0uzUvXS87P3cQIjIxtx35u3sF4aWPwIUYB DkYlHt4PPEJRQqyJZcWVuYcYJTiYlUR41aKAQrwpiZVVqUX58UWlOanFhxilOViUxHl796yO FBJITyxJzU5NLUgtgskycXBKNTAKfrOV3sxz/eIWB76VNkFla1uXt+785lLxe1GuxcUnBf8O vV0o2TTNaOs+hcQVv5170oOT1kxd8bjUP5N9/eQf/1y4d+Ub6nHyZjuV5jJ0t996edPOQtrq V+ANjo/nfl9ZZfb9kPzFkyULa/05ZoaeXbvgw93JTjPl5zjOu3i+7fC/RWfuMEQoKLEUZyQa ajEXFScCAP7kjBGIAgAA X-CMS-MailID: 20171120130713eucas1p21960847cb6dd2927200d623d4fcf27b8 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171120130713eucas1p21960847cb6dd2927200d623d4fcf27b8 X-RootMTR: 20171120130713eucas1p21960847cb6dd2927200d623d4fcf27b8 References: <1511161153-5127-1-git-send-email-gellert.babel@ericsson.com> Subject: Re: [dpdk-dev] [PATCH] vhost user: unlink sockaddr when poll sched fails X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Nov 2017 13:07:17 -0000 Hi everyone, This issue is already discussed many times here and in OVS mail-lists. The basic restart issue was resolved by removing the sockets at exit in OVS. The crash scenario is not handled but you're able to remove all of the left files by some external script before restarting the OVS. That is one of the discussions about: http://dpdk.org/ml/archives/dev/2015-December/030326.html The second point is that vhostuser ports are dpricated now in OVS and will be removed in future release. So, it's better for you to migrate to vhostuserclient and everything will be fine because QEMU properly handles sockets itself. So, IMHO, we should not add such overkill and, potentially, very dangerous solutions to DPDK just to fix minor issue in deprecated OVS code. Best regards, Ilya Maximets. > From: Jan Wickbom > > Issue: > > Vhost user socket addresses left in /var/run/openvswitch. > This will lead to failure to add vhost user ports with names that > already exist in this directory. > > When there is a failure to add a vhost user socket file descriptor to > the file descriptor set using fdset_add() in > rte_vhost_driver_register() the address bound to the socket is not > released. > > Solution: > Add unlink of the file path corresponding to the socket address. > > Signed-off-by: Jan Wickbom > Signed-off-by: Gellert Babel > --- > lib/librte_vhost/socket.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c > index 41aa3f9..eb9dae2 100644 > --- a/lib/librte_vhost/socket.c > +++ b/lib/librte_vhost/socket.c > @@ -352,6 +352,7 @@ struct vhost_user { > > err: > close(fd); > + unlink(path); > return -1; > } > > -- > 1.9.1