From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by dpdk.org (Postfix) with ESMTP id 8702B28FD for ; Sun, 5 May 2019 03:21:01 +0200 (CEST) Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 91FD122C67396A7566CE; Sun, 5 May 2019 09:20:59 +0800 (CST) Received: from [127.0.0.1] (10.177.131.206) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.439.0; Sun, 5 May 2019 09:20:56 +0800 To: Thomas Monjalon CC: , , References: <1556800505-59917-1-git-send-email-mousuanming@huawei.com> <1556862508-61677-1-git-send-email-mousuanming@huawei.com> <6913769.b5EUOLfAN7@xps> From: Suanming.Mou Message-ID: <818cde04-8f60-b3d8-a15d-37a435bbc6bf@huawei.com> Date: Sun, 5 May 2019 09:20:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <6913769.b5EUOLfAN7@xps> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.177.131.206] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 May 2019 01:21:01 -0000 On 2019/5/5 5:17, Thomas Monjalon wrote: > Hi, > > 03/05/2019 07:48, Suanming. Mou: >> When primary app exits, the residual running pdump will stop the >> primary app to restart. Add pdump exits with primary support. > Sorry I fail to parse this sentence. > Maybe it should be longer to be more explicit about > what it the current issue and how it is solved. Thanks for the suggestion. It's fine to add more contents. > Some comments in the code may also be improved. Could you please help to show the detail? Or it will be hard to do the improvement. ` There are a thousand Hamlets in a thousand people's eyes.` > >> Signed-off-by: Suanming.Mou > I think you should remove the dot in your name. Sorry for that, maybe I missed some important instructions which notes the dot. I will remove it later. > >> Reviewed-by: Anatoly Burakov >> Reviewed-by: Vipin Varghese >> --- >> V8: >> * reword the print info in monitor_primary. >> * add release_19_05.rst update. > As it is not a fix, it will slip in 19.08. It seems 19.08 is still not started yet. Does that mean the patch should be hung till 19.08 be started? > > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id E9708A0AC5 for ; Sun, 5 May 2019 03:21:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7DA512986; Sun, 5 May 2019 03:21:02 +0200 (CEST) Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by dpdk.org (Postfix) with ESMTP id 8702B28FD for ; Sun, 5 May 2019 03:21:01 +0200 (CEST) Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 91FD122C67396A7566CE; Sun, 5 May 2019 09:20:59 +0800 (CST) Received: from [127.0.0.1] (10.177.131.206) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.439.0; Sun, 5 May 2019 09:20:56 +0800 To: Thomas Monjalon CC: , , References: <1556800505-59917-1-git-send-email-mousuanming@huawei.com> <1556862508-61677-1-git-send-email-mousuanming@huawei.com> <6913769.b5EUOLfAN7@xps> From: Suanming.Mou Message-ID: <818cde04-8f60-b3d8-a15d-37a435bbc6bf@huawei.com> Date: Sun, 5 May 2019 09:20:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <6913769.b5EUOLfAN7@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.177.131.206] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v8] app/pdump: add pudmp exits with primary support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190505012054.6xnRXz7DvglTNbBVvoWtGxyzLL7DXcwqcmMf7Sx2Niw@z> On 2019/5/5 5:17, Thomas Monjalon wrote: > Hi, > > 03/05/2019 07:48, Suanming. Mou: >> When primary app exits, the residual running pdump will stop the >> primary app to restart. Add pdump exits with primary support. > Sorry I fail to parse this sentence. > Maybe it should be longer to be more explicit about > what it the current issue and how it is solved. Thanks for the suggestion. It's fine to add more contents. > Some comments in the code may also be improved. Could you please help to show the detail? Or it will be hard to do the improvement. ` There are a thousand Hamlets in a thousand people's eyes.` > >> Signed-off-by: Suanming.Mou > I think you should remove the dot in your name. Sorry for that, maybe I missed some important instructions which notes the dot. I will remove it later. > >> Reviewed-by: Anatoly Burakov >> Reviewed-by: Vipin Varghese >> --- >> V8: >> * reword the print info in monitor_primary. >> * add release_19_05.rst update. > As it is not a fix, it will slip in 19.08. It seems 19.08 is still not started yet. Does that mean the patch should be hung till 19.08 be started? > > > > >