From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 8C0344CAD for ; Tue, 27 Feb 2018 12:44:11 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBF6B40363BE; Tue, 27 Feb 2018 11:44:10 +0000 (UTC) Received: from [10.36.112.50] (ovpn-112-50.ams2.redhat.com [10.36.112.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AE1862144B21; Tue, 27 Feb 2018 11:44:09 +0000 (UTC) To: Jens Freimann Cc: jianfeng.tan@intel.com, stefanha@redhat.com, tiwei.bie@intel.com, dev@dpdk.org References: <20180222181910.23134-1-maxime.coquelin@redhat.com> <20180222181910.23134-2-maxime.coquelin@redhat.com> <20180227112229.dkt6fy6feqlbbjay@dhcp-192-241.str.redhat.com> From: Maxime Coquelin Message-ID: <81997881-7cc0-4608-042f-e687e6417c9f@redhat.com> Date: Tue, 27 Feb 2018 12:44:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180227112229.dkt6fy6feqlbbjay@dhcp-192-241.str.redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 27 Feb 2018 11:44:10 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 27 Feb 2018 11:44:10 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [RFC 1/3] vhost: invalidate vring addresses in cleanup_vq() X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2018 11:44:11 -0000 Hi Jens, On 02/27/2018 12:22 PM, Jens Freimann wrote: > On Thu, Feb 22, 2018 at 07:19:08PM +0100, Maxime Coquelin wrote: >> When cleaning-up the virtqueue, we also need to invalidate its >> addresses to be sure outdated addresses won't be used later. >> >> Signed-off-by: Maxime Coquelin >> --- >> lib/librte_vhost/vhost.c      | 6 ++++-- >> lib/librte_vhost/vhost.h      | 4 +++- >> lib/librte_vhost/vhost_user.c | 2 +- >> 3 files changed, 8 insertions(+), 4 deletions(-) >> >> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c >> index f6f12a03b..e4281cf67 100644 >> --- a/lib/librte_vhost/vhost.c >> +++ b/lib/librte_vhost/vhost.c >> @@ -69,12 +69,14 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct >> vhost_virtqueue *vq, >> } >> >> void >> -cleanup_vq(struct vhost_virtqueue *vq, int destroy) >> +cleanup_vq(struct virtio_net *dev, struct vhost_virtqueue *vq, int >> destroy) >> { >>     if ((vq->callfd >= 0) && (destroy != 0)) >>         close(vq->callfd); >>     if (vq->kickfd >= 0) >>         close(vq->kickfd); >> + >> +    vring_invalidate(dev, vq); >> } >> >> /* >> @@ -89,7 +91,7 @@ cleanup_device(struct virtio_net *dev, int destroy) >>     vhost_backend_cleanup(dev); >> >>     for (i = 0; i < dev->nr_vring; i++) >> -        cleanup_vq(dev->virtqueue[i], destroy); >> +        cleanup_vq(dev, dev->virtqueue[i], destroy); >> } >> >> void >> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h >> index 58aec2e0d..4ebf84bec 100644 >> --- a/lib/librte_vhost/vhost.h >> +++ b/lib/librte_vhost/vhost.h >> @@ -241,6 +241,7 @@ struct virtio_net { >>     struct guest_page       *guest_pages; >> >>     int            slave_req_fd; >> +    uint8_t        virtio_status; > > Belongs into other patch? Oh, right! I squashed in wrong commit. > Apart from that Reviewed-by: Jens Freimann Is your r-b for the full series or this single patch? Thanks! Maxime > regards, > Jens