From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Cc: <linuxarm@huawei.com>, <xavier_huwei@163.com>,
<liudongdong3@huawei.com>, <forest.zhouchang@huawei.com>
Subject: Re: [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files
Date: Tue, 10 Sep 2019 19:43:58 +0800 [thread overview]
Message-ID: <81bb00fb-1775-1632-52e4-991b1d788a97@huawei.com> (raw)
In-Reply-To: <a1dc447d-0ded-534d-28a8-35fc23b3d3eb@intel.com>
Hi, Ferruh Yigit
On 2019/8/30 22:58, Ferruh Yigit wrote:
> On 8/23/2019 2:47 PM, Wei Hu (Xavier) wrote:
>> This patch add build related files for hns3 PMD driver.
>>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> Signed-off-by: Chunsong Feng <fengchunsong@huawei.com>
>> Signed-off-by: Hao Chen <chenhao164@huawei.com>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>> MAINTAINERS | 7 ++++
>> config/common_armv8a_linux | 5 +++
>> config/common_base | 5 +++
>> config/defconfig_arm64-armv8a-linuxapp-clang | 2 +
>> doc/guides/nics/features/hns3.ini | 38 +++++++++++++++++++
>> doc/guides/nics/hns3.rst | 55 ++++++++++++++++++++++++++++
> This file needs to be added to the index file: 'doc/guides/nics/index.rst'
Thanks for your suggestion.
We will fix it in patch V2.
>
> <...>
>
>> diff --git a/config/defconfig_arm64-armv8a-linuxapp-clang b/config/defconfig_arm64-armv8a-linuxapp-clang
>> index d3b4dad..c73f5fb 100644
>> --- a/config/defconfig_arm64-armv8a-linuxapp-clang
>> +++ b/config/defconfig_arm64-armv8a-linuxapp-clang
>> @@ -6,3 +6,5 @@
>>
>> CONFIG_RTE_TOOLCHAIN="clang"
>> CONFIG_RTE_TOOLCHAIN_CLANG=y
>> +
>> +CONFIG_RTE_LIBRTE_HNS3_PMD=n
> I can understand the architecture ones, but why clang is not supported? Can you
> please add this support?
We will fix it in patch V2.
> <...>
>
>> diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
>> new file mode 100644
>> index 0000000..c9d0253
>> --- /dev/null
>> +++ b/doc/guides/nics/hns3.rst
>> @@ -0,0 +1,55 @@
>> +.. SPDX-License-Identifier: BSD-3-Clause
>> + Copyright(c) 2018-2019 Hisilicon Limited.
>> +
>> +HNS3 Poll Mode Driver
>> +===============================
>> +
>> +The Hisilicon Network Subsystem is a long term evolution IP which is
>> +supposed to be used in Hisilicon ICT SoCs such as Kunpeng 920.
> Can you please add a official link/reference to the product?
>
The official website link of kunpeng920 chip is not available yet,
And we will paste the link to the servers product using kunpeng920 in
patch V2.
Thanks for your suggestion.
> <...>
>
>> @@ -0,0 +1,43 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2018-2019 Hisilicon Limited.
>> +
>> +include $(RTE_SDK)/mk/rte.vars.mk
>> +
>> +#
>> +# library name
>> +#
>> +LIB = librte_pmd_hns3.a
>> +
>> +CFLAGS += -O3
>> +CFLAGS += $(WERROR_FLAGS)
>> +CFLAGS += -DALLOW_EXPERIMENTAL_API -fsigned-char
> Why '-DALLOW_EXPERIMENTAL_API' is required? Can we remove it?
There are some APIs as follows in hns3 PMD driver,
'-DALLOW_EXPERIMENTAL_API' can clear warning during compiling.
# Experimantal APIs:
# - rte_mp_action_register
# - rte_mp_action_unregister
# - rte_mp_reply
# - rte_mp_request_sync
>> +
>> +LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>> +LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_hash
>> +LDLIBS += -lrte_bus_pci
> Are all these libraries really required, like kvargs? Can you please clean the
> unused ones?
We will fix it in patch V2.
>> +
>> +EXPORT_MAP := rte_pmd_hns3_version.map
>> +
>> +LIBABIVER := 2
> It should be 1.
We will fix it in patch V2.
>
> <...>
>
>> +# install this header file
>> +SYMLINK-$(CONFIG_RTE_LIBRTE_HNS3_PMD)-include := hns3_ethdev.h
> No need to expose the header file, it is not public header.
We will fix it in patch V2.
>
> <...>
>
>> @@ -0,0 +1,19 @@
>> +# SPDX-License-Identifier: BSD-3-Clause
>> +# Copyright(c) 2018-2019 Hisilicon Limited
>> +
>> +sources = files('hns3_cmd.c',
>> + 'hns3_dcb.c',
>> + 'hns3_intr.c',
>> + 'hns3_ethdev.c',
>> + 'hns3_ethdev_vf.c',
>> + 'hns3_fdir.c',
>> + 'hns3_flow.c',
>> + 'hns3_mbx.c',
>> + 'hns3_regs.c',
>> + 'hns3_rss.c',
>> + 'hns3_rxtx.c',
>> + 'hns3_stats.c',
>> + 'hns3_mp.c')
>> +deps += ['hash']
>> +
>> +cflags += '-DALLOW_EXPERIMENTAL_API'
> There is better way to do this in meson, please check other samples. But as the
> makefile comment, does it really needed, if so can you please add the
> experimental APIs used as a comment, to both meson and Makefile?
I will update it as follows:
allow_experimental_apis = true
# Experimantal APIs:
# - rte_mp_action_register
# - rte_mp_action_unregister
# - rte_mp_reply
# - rte_mp_request_sync
Thanks for your suggestion.
>> diff --git a/drivers/net/hns3/rte_pmd_hns3_version.map b/drivers/net/hns3/rte_pmd_hns3_version.map
>> new file mode 100644
>> index 0000000..3aef967
>> --- /dev/null
>> +++ b/drivers/net/hns3/rte_pmd_hns3_version.map
>> @@ -0,0 +1,3 @@
>> +DPDK_19.08 {
> DPDK_19.11
We will fix it in patch V2.
Thanks for your suggestion.
Regards
Xavier
>
> .
>
next prev parent reply other threads:[~2019-09-10 11:44 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-23 13:46 [dpdk-dev] [PATCH 00/22] add hns3 ethernet PMD driver Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 01/22] net/hns3: add hardware registers definition Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 02/22] net/hns3: add some definitions for data structure and macro Wei Hu (Xavier)
2019-08-30 8:25 ` Gavin Hu (Arm Technology China)
2019-09-05 6:01 ` Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 03/22] net/hns3: register hns3 PMD driver Wei Hu (Xavier)
2019-08-30 15:01 ` Ferruh Yigit
2019-09-06 6:20 ` Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 04/22] net/hns3: add support for cmd of " Wei Hu (Xavier)
2019-08-30 15:02 ` Ferruh Yigit
2019-09-06 6:49 ` Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 05/22] net/hns3: add the initialization " Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 06/22] net/hns3: add support for MAC address related operations Wei Hu (Xavier)
2019-08-30 15:03 ` Ferruh Yigit
2019-09-05 5:40 ` Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 07/22] net/hns3: add support for some misc operations Wei Hu (Xavier)
2019-08-30 15:04 ` Ferruh Yigit
2019-08-23 13:46 ` [dpdk-dev] [PATCH 08/22] net/hns3: add support for link update operation Wei Hu (Xavier)
2019-08-30 15:04 ` Ferruh Yigit
2019-09-06 6:56 ` Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 09/22] net/hns3: add support for flow directory of hns3 PMD driver Wei Hu (Xavier)
2019-08-30 15:06 ` Ferruh Yigit
2019-09-06 8:23 ` Wei Hu (Xavier)
2019-09-06 11:08 ` Wei Hu (Xavier)
2019-08-23 13:46 ` [dpdk-dev] [PATCH 10/22] net/hns3: add support for RSS " Wei Hu (Xavier)
2019-08-30 15:07 ` Ferruh Yigit
2019-08-31 9:16 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 11/22] net/hns3: add support for flow control " Wei Hu (Xavier)
2019-08-30 15:07 ` Ferruh Yigit
2019-08-31 8:04 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 12/22] net/hns3: add support for VLAN " Wei Hu (Xavier)
2019-08-30 15:08 ` Ferruh Yigit
2019-08-31 9:04 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 13/22] net/hns3: add support for mailbox " Wei Hu (Xavier)
2019-08-30 15:08 ` Ferruh Yigit
2019-09-06 11:25 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 14/22] net/hns3: add support for hns3 VF " Wei Hu (Xavier)
2019-08-30 15:11 ` Ferruh Yigit
2019-08-31 9:03 ` Wei Hu (Xavier)
2019-09-06 11:27 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 15/22] net/hns3: add package and queue related operation Wei Hu (Xavier)
2019-08-23 15:42 ` Aaron Conole
2019-08-30 15:13 ` Ferruh Yigit
2019-09-11 11:40 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 16/22] net/hns3: add start stop configure promiscuous ops Wei Hu (Xavier)
2019-08-30 15:14 ` Ferruh Yigit
2019-09-06 11:51 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 17/22] net/hns3: add dump register ops for hns3 PMD driver Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 18/22] net/hns3: add abnormal interrupt process " Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 19/22] net/hns3: add stats related ops " Wei Hu (Xavier)
2019-08-30 15:20 ` Ferruh Yigit
2019-08-31 8:49 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 20/22] net/hns3: add reset related process " Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 21/22] net/hns3: add multiple process support " Wei Hu (Xavier)
2019-08-30 15:14 ` Ferruh Yigit
2019-09-02 13:41 ` Wei Hu (Xavier)
2019-08-23 13:47 ` [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files Wei Hu (Xavier)
2019-08-23 14:08 ` Jerin Jacob Kollanukkaran
2019-08-30 3:22 ` Wei Hu (Xavier)
2019-08-31 2:10 ` Wei Hu (Xavier)
2019-08-30 14:57 ` Ferruh Yigit
2019-08-30 6:16 ` Stephen Hemminger
2019-08-31 8:46 ` Wei Hu (Xavier)
2019-08-30 6:17 ` Stephen Hemminger
2019-08-31 8:44 ` Wei Hu (Xavier)
2019-09-03 15:27 ` Ye Xiaolong
2019-09-11 11:36 ` Wei Hu (Xavier)
2019-08-30 14:58 ` Ferruh Yigit
2019-09-10 11:43 ` Wei Hu (Xavier) [this message]
2019-08-30 15:00 ` Ferruh Yigit
2019-08-31 8:07 ` Wei Hu (Xavier)
2019-08-30 15:12 ` Ferruh Yigit
2019-08-31 8:07 ` Wei Hu (Xavier)
2019-08-30 15:23 ` [dpdk-dev] [PATCH 00/22] add hns3 ethernet PMD driver Ferruh Yigit
2019-08-31 8:06 ` Wei Hu (Xavier)
2019-09-02 4:24 [dpdk-dev] [PATCH 22/22] net/hns3: add hns3 build files Jerin Jacob Kollanukkaran
2019-09-06 12:21 ` Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81bb00fb-1775-1632-52e4-991b1d788a97@huawei.com \
--to=xavier.huwei@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=forest.zhouchang@huawei.com \
--cc=linuxarm@huawei.com \
--cc=liudongdong3@huawei.com \
--cc=xavier_huwei@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).