From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 8CE5C4D3A; Fri, 30 Mar 2018 12:39:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Mar 2018 03:39:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,381,1517904000"; d="scan'208";a="216078188" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.252.18.75]) ([10.252.18.75]) by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2018 03:39:45 -0700 To: Matan Azrad , Thomas Monjalon , Gaetan Rivet , Jingjing Wu Cc: "dev@dpdk.org" , Neil Horman , Bruce Richardson , Konstantin Ananyev , "stable@dpdk.org" References: <1515318351-4756-1-git-send-email-matan@mellanox.com> <1516293317-30748-1-git-send-email-matan@mellanox.com> <1516293317-30748-2-git-send-email-matan@mellanox.com> <1aac7e4c-6f2a-7f3d-5f7c-e07e48baac6a@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; keydata= xsFNBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABzSVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+wsF+BBMBAgAoAhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgAUCWZR1xgUJB33UawAKCRD5M+tD3xNhH3TID/wNjq1doFXg49WaM7ZXez/1 qwj7U6FQ2eUhlEPX8dXc52cu+iQk8/mssXQtANEx+jndxfvlkikBNgI+mr3m/ho54uQWFZd7 Bv0DVVkLHNkLWK6tT6iISdCgXrQuOv8y5rucEGkJ8dDPsp8Mqr4sBjavRBpczphoa3miKusA HzUEo0SYuHUPmBlbmvKv4PkA5quWtXpkgV2HZ1bW9X0dQkAqEVioAPm5Q6pXJODfV8kaZUtJ z4swEtBnK9XAWm2HccF7KmFh0vv+Zh9lEMnEFt7UPXngY6+xCTo6xV1IVc8EZfDjOip8I4h2 ALMaLgrZwA9VVmHCVOrnO3UZqfGehrwz4O3sUrcmIzxjk3gfBmVRCBfuWGchSpWtZ99U6V1a OEuG+ymyjBDtyymW+KSvmCBl2gIxZHvZFvSRRdDObkkUIskSJ95f/6HBOESRZBOiV9GEAhC5 gI9OAKKF8HQaN/r5KJrkzscjQcjIdV1jXhTkfQ4wH3GJiVM5JxsKsEjjRw7yfSJo2GBEGqMe KMwMLWg4f1DgVtjOuGf10isu+29MvapW2IxKYaHcVc2vHfWbDi2AvBj/VAzKILWbTEgI1VL5 zKpo5p6X2O55oEyeflDiAzrUfvLqB4vmTyqXtW6PdLyZC7kXIzmNu6EBVx9oSgy3CADw5saN 0La9OoCAc7Tn+s7BTQRX1ky+ARAApzQNvXvE2q1LAS+Z+ni2R13Bb1cDS1ZYq1jgpR13+OKN ipzd8MPngRJilXxBaPTErhgzR0vGcNTYhjGMSyFIHVOoBq1VbP1a0Fi/NqWzJOowo/fDfgVy K4vuitc/gCJs+2se4hdZA4EQJxVlNM51lgYDNpjPGIA43MX15OLAip73+ho6NPBMuc5qse3X pAClNhBKfENRCWN428pi3WVkT+ABRTE0taxjJNP7bb+9TQYNRqGwnGzX5/XISv44asWIQCaq vOkXSUJLd//cdVNTqtL1wreCVVR5pMXj7VIrlk07fmmJVALCmGbFr53BMb8O+8dgK2A5mitM n44d+8KdJWOwziRxcaMk/LclmZS3Iv1TERtiWt98Y9AjeAtcgYPkA3ld0BcUKONogP8pHVz1 Ed3s5rDQ91yr1S0wuAzW91fxGUO4wY+uPmxCtFVuBgd9VT9NAKTUL0qHM7CDgCnZPe0TW6Zj 8OqtdCCyAfvU9cW5xWM7Icxhde6AtPxhDSBwE8fL2ZmrDmaA4jmUKXp3i4JxRPSX84S08b+s DWXHPxy10UFU5A7EK/BEbZAKBwn9ROfm+WK+6X5xOGLoRE++OqNuUudxC1GDyLOPaqCbBCS9 +P6HsTHzxsjyJa27n4jcrcuY3P9TEcFJYSZSeSDh8mVGvugi0exnSJrrBZDyVCcAEQEAAcLB ZQQYAQIADwIbDAUCWZR1ZwUJA59cIQAKCRD5M+tD3xNhH5b+D/9XG44Ci6STdcA5RO/ur05J EE3Ux1DCHZ5V7vNAtX/8Wg4l4GZfweauXwuJ1w7Sp7fklwcNC6wsceI+EmNjGMqfIaukGetG +jBGqsQ7moOZodfXUoCK98gblKgt/BPYMVidzlGC8Q/+lZg1+o29sPnwImW+MXt/Z5az/Z17 Qc265g+p5cqJHzq6bpQdnF7Fu6btKU/kv6wJghENvgMXBuyThqsyFReJWFh2wfaKyuix3Zyj ccq7/blkhzIKmtFWgDcgaSc2UAuJU+x9nuYjihW6WobpKP/nlUDu3BIsbIq09UEke+uE/QK+ FJ8PTJkAsXOf1Bc2C0XbW4Y2hf103+YY6L8weUCBsWC5VH5VtVmeuh26ENURclwfeXhWQ9Og 77yzpTXWr5g1Z0oLpYpWPv745J4bE7pv+dzxOrFdM1xNkzY2pvXph/A8OjxZNQklDkHQ7PIB Lki5L2F4XkEOddUUQchJwzMqTPsggPDmGjgLZrqgO+s4ECZK5+nLD3HEpAbPa3JLDaScy+90 Nu1lAqPUHSnP3vYZVw85ZYm6UCxHE4VLMnnJsN09ZhsOSVR+GyP5Nyw9rT1V3lcsuH7M5Naa 2Xobn9m7l9bRCD/Ji8kG15eV1WTxx1HXVQGjdUYDI7UwegBNbwMLh17XDy+3sn/6SgcqtECA Q6pZKA2mTQxEKA== Message-ID: <81bbd03d-3a69-979d-dcb0-553b91952198@intel.com> Date: Fri, 30 Mar 2018 11:39:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/7] ethdev: fix port data reset timing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Mar 2018 10:39:49 -0000 On 3/28/2018 1:07 PM, Matan Azrad wrote: > Hi Ferruh > >> From: Ferruh Yigit, Wednesday, March 28, 2018 1:38 AM >> On 3/5/2018 3:12 PM, Matan Azrad wrote: >>> Hi Ferruh >>> >>> From: Ferruh Yigit, Sent: Monday, March 5, 2018 5:07 PM >>>> On 3/5/2018 2:52 PM, Matan Azrad wrote: >>>>> HI >>>>> >>>>> From: Ferruh Yigit, Sent: Monday, March 5, 2018 1:24 PM >>>>>> On 1/18/2018 4:35 PM, Matan Azrad wrote: >>>>>>> rte_eth_dev_data structure is allocated per ethdev port and can be >>>>>>> used to get a data of the port internally. >>>>>>> >>>>>>> rte_eth_dev_attach_secondary tries to find the port identifier >>>>>>> using rte_eth_dev_data name field comparison and may get an >>>>>>> identifier of invalid port in case of this port was released by >>>>>>> the primary process because the port release API doesn't reset the >> port data. >>>>>>> >>>>>>> So, it will be better to reset the port data in release time >>>>>>> instead of allocation time. >>>>>>> >>>>>>> Move the port data reset to the port release API. >>>>>>> >>>>>>> Fixes: d948f596fee2 ("ethdev: fix port data mismatched in multiple >>>>>>> process model") >>>>>>> Cc: stable@dpdk.org >>>>>>> >>>>>>> Signed-off-by: Matan Azrad >>>>>>> --- >>>>>>> lib/librte_ether/rte_ethdev.c | 2 +- >>>>>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/lib/librte_ether/rte_ethdev.c >>>>>>> b/lib/librte_ether/rte_ethdev.c index 7044159..156231c 100644 >>>>>>> --- a/lib/librte_ether/rte_ethdev.c >>>>>>> +++ b/lib/librte_ether/rte_ethdev.c >>>>>>> @@ -204,7 +204,6 @@ struct rte_eth_dev * >>>>>>> return NULL; >>>>>>> } >>>>>>> >>>>>>> - memset(&rte_eth_dev_data[port_id], 0, sizeof(struct >>>>>> rte_eth_dev_data)); >>>>>>> eth_dev = eth_dev_get(port_id); >>>>>>> snprintf(eth_dev->data->name, sizeof(eth_dev->data->name), >>>>>> "%s", name); >>>>>>> eth_dev->data->port_id = port_id; @@ -252,6 +251,7 @@ struct >>>>>>> rte_eth_dev * >>>>>>> if (eth_dev == NULL) >>>>>>> return -EINVAL; >>>>>>> >>>>>>> + memset(eth_dev->data, 0, sizeof(struct >> rte_eth_dev_data)); >>>>>> >>>>>> Hi Matan, >>>>>> >>>>>> What most of the vdev release path does is: >>>>>> >>>>>> eth_dev = rte_eth_dev_allocated(...) >>>>>> rte_free(eth_dev->data->dev_private); >>>>>> rte_free(eth_dev->data); >>>>>> rte_eth_dev_release_port(eth_dev); >>>>>> >>>>>> Since eth_dev->data freed, memset() it in >>>>>> rte_eth_dev_release_port() will be problem. >>>>>> >>>>>> We don't run remove path that is why we didn't hit the issue but >>>>>> this seems problem for all virtual PMDs. >>>>> >>>>> Yes, it is a problem and should be fixed: >>>>> For vdevs which use private rte_eth_dev_data the remove order can >> be: >>>>> private_data = eth_dev->data; >>>>> rte_free(eth_dev->data->dev_private); >>>>> rte_eth_dev_release_port(eth_dev); /* The last operation working >>>> on ethdev structure. */ >>>>> rte_free(private_data); >>>> >>>> Do we need to save "private_data"? >>> >>> Just to emphasis that eth_dev structure should not more be available after >> rte_eth_dev_release_port(). >>> Maybe in the future rte_eth_dev_release_port() will zero eth_dev >>> structure too :) >> >> Hi Matan, >> >> Reminder of this issue, it would be nice to fix in this release. >> > > Regarding the private rte_eth_dev_data, it should be fixed in the next thread: > https://dpdk.org/dev/patchwork/patch/35632/ > > Regarding the rte_eth_dev_pci_release() function: I'm going to send a fix. Thanks Matan for the patch, But rte_eth_dev_release_port() is still broken because of this change, please check _rte_eth_dev_callback_process() which uses dev->data->port_id. > >>> >>>>> >>>>> >>>>>> Also rte_eth_dev_pci_release() looks problematic now. >>>>> >>>>> Yes, again, the last operation working on ethdev structure should be >>>> rte_eth_dev_release_port(). >>>>> >>>>> So need to fix all vdevs and the rte_eth_dev_pci_release() function. >>>>> >>>>> Any comments? >>>>> >>> >