From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 956EA45769; Thu, 8 Aug 2024 10:50:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66B8940A80; Thu, 8 Aug 2024 10:50:31 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2045.outbound.protection.outlook.com [40.107.220.45]) by mails.dpdk.org (Postfix) with ESMTP id 924BA40696 for ; Thu, 8 Aug 2024 10:50:30 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AX7bGROZ9e9FgTRFwZKqWi0nVMowoNfeKC635pyCEyDNjFI1P8N4wtQsnKthp0jCHv8KNXS39BH2gqa5zF4rkwg4+QSr3d5zt+2+Dg+gUafkYoqf7AYWGPSzxuN6INGjJggdvTT0hx70Wu3Qqm+axD+yk3J/cDzzGCJVwi9EMoyvCgKdL5ZN09EFem+uB2mhd0SP2IZymGJHvAeVyVFCJ04RMCfoO++N61CYPZPJSFtLC44jy6OXeieokLE3vycaIX2KP7ivEzEZ6METQl+1lR0sy2KhfkY3sVIUzmgqnOvddszOvbjDMpiIbwi9U8oZeMjzTJSGK+YpBrhwUX2OJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q8PN/ZtaM4NhwuYgNPRGRevAcUuAuTxch77DwlvOWyY=; b=hp1MgMPW61Wclj3lBGaLl2m/bDd0gn0kbqL9gzxL8W8g7CRjPtvLbGY6oIjnftQ1W8dY/tqQe0J6TlpRL4IgP1Dmu+PgC+nXxvyqsYWKkGEmk7uxt+Y5pCtzmCmQBg/OFEMXyZB3ZO/SxY85cRkDuSEOlUZsUWh4bH8iOC9jLNQEm16++A4XJ1nuBGvZz7TZ9FvspNwnXUnSGtl4AVTYit0kOsNTIm7jOa6kqW2u5YC28s67Y1EczmUzMyWpqcT5ZLHG7NP9Z8DDhv3U9hxduMsXz+GMljEykMCcZjmW9SSOz5FRGOEBMwTrze3NIIr8cmPIPkvQ+Uw30ugn5fpAuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q8PN/ZtaM4NhwuYgNPRGRevAcUuAuTxch77DwlvOWyY=; b=JnJao4x3Ou6n0CBm/UInP93T3TW11PXLd9in4PX5peym4fv32omgVOHhm+gWyFh2JCK/SAUX9+1g0dRtf/udGbL5eTfNzXKwxaG5qYpBqAEU1oqBXhSrc6qh/pqDzGxESYuzncbXCAWnej30f3swxNIRvKSWe0DYjuLBHRboD+c= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW6PR12MB9019.namprd12.prod.outlook.com (2603:10b6:303:23f::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.23; Thu, 8 Aug 2024 08:50:27 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7849.008; Thu, 8 Aug 2024 08:50:27 +0000 Message-ID: <81cacbfa-7bd7-4e1b-9b9c-f60c11848dab@amd.com> Date: Thu, 8 Aug 2024 09:50:24 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] net/enic: support SR-IOV VF using admin channel To: Hyong Youb Kim Cc: dev@dpdk.org, John Daley References: <20240808041838.31367-4-hyonkim@cisco.com> <20240808061433.14971-1-hyonkim@cisco.com> <20240808061433.14971-2-hyonkim@cisco.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240808061433.14971-2-hyonkim@cisco.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO6P123CA0038.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW6PR12MB9019:EE_ X-MS-Office365-Filtering-Correlation-Id: 652a84b5-a1b9-43da-d989-08dcb7872691 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b1BRNXRXQ3o2ZmkxejVOODZtck9MczRiWHQ3SVVEM2lIQ0g0RHIvY2Iyekt2?= =?utf-8?B?SGVMNW1jb1d1NVVZanJoS05DbDlUamxOeFRGY2lZZDgzUEY5b0h0b1NjOEF1?= =?utf-8?B?dzFHR1NDZEY5czl3aGtiSytiSy81NHlrcFM2T1dOV0VMR3YxZ3Z0ZVp0T211?= =?utf-8?B?N21LclkvM0gxZ1pLaGRXRTczNm43bEs0eTNQdDFyNHoydVJkSFZoRW5Xbmt4?= =?utf-8?B?ZVV4RWd6bE9GTkdaUHBuVkNENHJCM3lxd3J6ZURNMklSU1JuVGl1aHJoV3Z6?= =?utf-8?B?WndYMEFXcHBZMCs1SXRneW1CNFN5T0lrckRobUtQSTZna3FCRGJHbk5aZVZq?= =?utf-8?B?eCttYnowOXFZa2V2dERFV1FKaXRkM2cxZHlJbGlyUitRdmRTcUlFM2hRNlFm?= =?utf-8?B?anI3TzdNMUdUVHVLYm1FQkdmeXVGRnJsRklRdFNKL2l6a3NRbW81YWtiUlNp?= =?utf-8?B?ejJSTlpEQlc1OGFIbnQ4Z3JqQ2VaUmc1ZjNNSmxaSnpybysrNlNqVGFhd3BQ?= =?utf-8?B?RmRJOTBlVHRleG9JODlXYXJyMlhpcWdDZldOSzFrbHB2UlBMMzFwU3NNenBy?= =?utf-8?B?NngyOEkybG92TXliYm9KdXdZd3BISGhxeWl4dkRhVUc3STh0cmpDZVdwR1BZ?= =?utf-8?B?WkxmSFdpbitZMFpaT2s5ZndJVEQzUmFCdGVIS09TRXBpT3dTWEJZV0tLY3Ex?= =?utf-8?B?VXVvMHMvTjNkVUJzL3ljVVkvRmtWSEFBMGkzL2hiY0t3U1BXVlFpYjI3NVpq?= =?utf-8?B?MlljYWhyUi8wVFNDVUIrU3pOKzZGVzJxL3c4YWQyT3d3OTRzZ1FvejJiNHpU?= =?utf-8?B?UmpOV3J6Q0ZIaFpQMjB5RTNLV0JBajdDSjJsOFEzcW5talpUL3hHZ3lBcWtp?= =?utf-8?B?N0VZSjZkVnhyOG5zeXBpa1lLSG4rSGNCdEtRY0Q4RjRzMkNGODBjRWxCTTA5?= =?utf-8?B?blNBRStpaEtXZTdVRHZMZko0d0RnYThhNTI5MDVuUTViZDNrZFRaai9YY0RL?= =?utf-8?B?ZkJmMjlIQkN6MTNneXBxNUJNNm4wN2VjQXhMbk9pMTRvNzBaaS9FQ1ZOSEM2?= =?utf-8?B?ZzBQUmJCZG94YUtVYjBKVGtJanJ4Zi9BWjBpWldTK2RVNzJ3K3BjTG5jN0NL?= =?utf-8?B?enRha3c1RVhYRjhuRGwwRnRyZ1o1YTExZmRyaGhla1QvZkhvb25FK1NPaExM?= =?utf-8?B?TmlRT2I3TGRjM3YwcFNrUElwL1dzc1F5N0ZEa2ozUkFydnBnR21oSXNvNmlt?= =?utf-8?B?ZmJzUXlHRHg3N3dIN0h6R3p3anJ4c3JzMmN2MXhabmM0VklHN3BER0l6aEJu?= =?utf-8?B?RE1PeGNVcm9xcmptNkFBT2NLV1ZqZExzZ3ZQOHRGUVQ1VmVRQlB1bDFlT0ti?= =?utf-8?B?SUlGMzJ4eFllejZaSFVmM1JPejdXdnFNbldWMS9UdEJXbWJaZGN4ajNQdHVa?= =?utf-8?B?dTJuTk9jVVJXZHdQTVZnQm84Q1BnbGZpQVh3ajBFOWhHTlBQZVlKdllrUmdL?= =?utf-8?B?NHcwTkxTUm9jM09ycis0cURub1NVWXE2UitGVTVIQ1ZxdlU3STZSLzZnUCtZ?= =?utf-8?B?MElRZlRrekNrOXhLK2dWcG9HNGhjTjcwQ1lVeTIwQ3AzSW51VVFsTDlCOXN1?= =?utf-8?B?R0podmxkZGZvaVc4ZEpmeHlhUGNNQWE3MjRyT1p4Y0NlOVdDbFp0ZDdKRVZt?= =?utf-8?B?M2lDNkNKSkw0cnZralh1VUlLTlVLWHpndENZam53bjJWd05TRkJyd2p2c3Fy?= =?utf-8?B?M3FlQjU1UmUzdUhOenFIbG5SN2R3aVYvdHpKZ2hzME1JR3N5eW9JUVg1VldQ?= =?utf-8?B?enJ4bWNhbXVqUm9MWTFvZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWhDZDgwSCtTRUtaUDB6WVRIK0pMSE9iVzVIMGxqUFBPc0Z6VTdrT3R1M2I3?= =?utf-8?B?UjJWekFPSVZLcFZrZGk3Ulp3UFpWRWQ0MGFOR1VXbWM3YXpBUHBFWkEzRFFj?= =?utf-8?B?K2FCWmhTS25yRFFBT21nYytyTXgySEtkQnNzL2I2YXhvSERoL3cvN3Exd1JK?= =?utf-8?B?RElCRTlxdC9zQVRSQlBDaW9yVkE5Skc5bmVrTE8vbXlsR0l3YXQzaE1JMXds?= =?utf-8?B?eTNhd01DSjJOVkhkRGlIUElUMk5kWXVzSnNGUGlocTJYL2g1c3hpZEJNb0sw?= =?utf-8?B?TGdtUlQ4d0o4bGQ4S1VZdzI1OXM0ckdhSmFIWTNhRWh6NkhkRndjUTNDUW55?= =?utf-8?B?V1ZTTVV2czgwSWJyVEkwYW9PZ2F2bndRdEhJUlF1bXFET1pqWmxwY1NuSGZL?= =?utf-8?B?R0VXbDlxUzRKOVAzczNnQVZ2WThjKy9WdFpmK1pUcjlreEorMVdudU9SQWtE?= =?utf-8?B?K3EzMmFScjg5aTVRUHhyZjJJWXh0QXJqUnluNWpIR1dSbmFrQ293eXlaclZY?= =?utf-8?B?MCt5dUFtSk1DUzE0aGcxdUthZkZlRGYvMGp3R3QrZkxPd2ljcEhFU0hzSGM1?= =?utf-8?B?bW9MWjI4eTNmU0M4Qy8zekxNSEcrVEhGckRRZGFSRE9nWkhPMkM3ZTBibHBV?= =?utf-8?B?d1JFZHlpejJjTFZ5SExOY0g0cTFMZjJFdjl3cjBuUWwrVmRoNjh5cG51STJJ?= =?utf-8?B?VEk4bEhtY3ZDa09EcEswMjhIdU5MckFZQmZvY3RtbjJmbTF2NzlEYlFQc0dD?= =?utf-8?B?QTV2OGZ6YzVwSndMc1RVM1pUU1grOU4wV1dJWXN5WUdhdzdnTTl6cEFNQ2lM?= =?utf-8?B?bTY4OFdIRVl0bmNySDlqY1pFOTVSSHR5NExWdlpIRjh5UVc2djhpdjJmVitH?= =?utf-8?B?ell1SGZDK1FMc2FvSXpNVFQzMExRQkNlRUY0eXhTYTRvTFR6djNNK2g5dzhH?= =?utf-8?B?dUFCSXBuUWxySmVwTkE5NDFXeDI3M3hzV1hOYXF6RjRzZkRoVjExUnVTWWJk?= =?utf-8?B?NkNma2FKWDU3S3pFaEFxVXYzK1NpRkUvdG1qeWZoQlhBS21jT1lNelhRTm5z?= =?utf-8?B?VlVqM3ltOEcybUhCbnpGTlBicTVWdk0vVytoemZoUlVtNlVNRGRqdEZXQWVI?= =?utf-8?B?RUlrdk13OFZtU3VNR0lrOUlDNUQ2ZmNSd1MramRsNnNPcFV6d0VvRnlXcGsz?= =?utf-8?B?SlJzb3FnK1JrdlpIYXZ0RmJEYzYwUFlhN0FBMjVMVmxDVFdvR1FKQW51RVF4?= =?utf-8?B?YWs3R1BpZXAwVWRvSlp4UXo1U0J6bjVLRlJ5UE5FNnZsTHNVMzFzeU5UVTRt?= =?utf-8?B?VHNtYzliWFVxQTZFd095WVQ2bmtqMnBudVRSWVRxdmVHRnFsOEl6ZXJzTW40?= =?utf-8?B?SjVxRTdhc2JRU29QL1ZjQTFjamJLZ0dWYTVqZjBUQ0pGaWZYRVpvWlJob0ox?= =?utf-8?B?dXV1T0h2azZudDczampDYlJBNHZEMlNoV0ZJVFNnWTAyNnJsbysyU3Z4S3JF?= =?utf-8?B?dkRyeTVMRXlwYVg4S1lTUVAyQ0lBS3hjVkxxL3dMclNuMmhUTXJGY1pPU1ha?= =?utf-8?B?cFFKN2NLUU5Td0ZNZVY1RVE3SzgvRHpyeEFlRG9sclJlQ0M5M1ZCS0JRT1FB?= =?utf-8?B?WnlNTXVybHo1dis0bE1FL0xUeTdacXRXUXFxWjF0SG1vVnU0OWZsWkxPcWNK?= =?utf-8?B?Mk5KcE0wLzVkQVM3bFlMREtlTFNkNlVzN0ZqR1FPM3M1R3FYd2lZd3F2Z0Rr?= =?utf-8?B?Q1J1cXJhY0t2VFVqaGFkNHlreVAvYlhzSnRWMWsrYzJtK0pIYXYzbjlQUnRV?= =?utf-8?B?SG5PU0YwYnFzT2Yza3k5RDlwZ2cvdmEreTFUTEFaQVVaZzQ1ZUFsZDFEUURh?= =?utf-8?B?UU1UZWQyZExHSUFGOUJqWTBhU1VmQ2dPVmxCVVdDTDVWVkh0cWxVTEQrdm1y?= =?utf-8?B?bjBKbTdnbkdmbVJZelFnaDI1Q0VEbVloekFEbHcxQnh0NVYwSUlCRkFBclky?= =?utf-8?B?UzZzNm9KUldEMUh0elFEQ0REMk9yWTFRSHhXN09xdjlFS3dpd2NxMkhxT1NX?= =?utf-8?B?eDdaREMrZy8rVGwyL1h0T1JHeGZiQ3RFbDJCaDVZVmNjU0p5aG9VZjJVcEM1?= =?utf-8?Q?AWP1O9JVIkISKMdpct7lOROjn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 652a84b5-a1b9-43da-d989-08dcb7872691 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Aug 2024 08:50:27.7124 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 4XN/Wjk5Y649PjQ46WGJQdzN6gv9fzVSZqQ91O88xYQNG8fQV3w331rmW5trT/rD X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB9019 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/8/2024 7:14 AM, Hyong Youb Kim wrote: > The Linux VIC PF driver now requires the use of the admin channel > between PF and VF drivers. Certain devcmds are disabled for VF. The VF > driver is supposed to send control messages through the admin channel > to the PF driver to perform those devcmds. This commit adds the admin > channel to the VF driver (net/enic). > > The VF's admin channel consists of normal Tx/Rx queues. VIC firmware > hardwires those queues to PF. Control messages are specially crafted > but otherwise normal packets. > > The Rx queue uses LSC interrupt (interrupt vector 0) to notify the > driver of new Rx control messages. The PF driver may send unsolicited > request messages (e.g. asking for VF stats) to VF. Such messages cause > LSC interrupts and are processed on the global interrupt thread. > > For devcmds that must be sent through the admin channel, use wrapper > functions. They check if the device is a VF. If VF, use the admin > channel. Otherwise, perform devcmd directly. > > Two complications: > - Soft Rx stats > VF on old VIC models does not have HW Rx counters. In this case, the > VF driver counts packets/bytes and reports them as device stats. > > - Backward compatibility mode > Old VIC PF drivers on some operating systems may support only > VF_CAPABILITY_REQUEST message or not support the admin channel at > all. When the VF driver detects such PF driver, it reverts to the > compatibility mode and does not use the admin channel. In this mode, > trust mode (e.g. enabling promiscuous mode) does not work. > Do you think does it worth to document above restrictions in the driver guide? > Signed-off-by: Hyong Youb Kim > Reviewed-by: John Daley > --- > drivers/net/enic/base/vnic_cq.c | 27 + > drivers/net/enic/base/vnic_cq.h | 3 + > drivers/net/enic/base/vnic_dev.c | 48 ++ > drivers/net/enic/base/vnic_dev.h | 3 + > drivers/net/enic/base/vnic_devcmd.h | 49 ++ > drivers/net/enic/base/vnic_resource.h | 32 +- > drivers/net/enic/base/vnic_rq.c | 27 + > drivers/net/enic/base/vnic_rq.h | 7 + > drivers/net/enic/base/vnic_wq.c | 37 +- > drivers/net/enic/base/vnic_wq.h | 5 + > drivers/net/enic/enic.h | 28 +- > drivers/net/enic/enic_ethdev.c | 8 +- > drivers/net/enic/enic_main.c | 77 ++- > drivers/net/enic/enic_res.c | 12 + > drivers/net/enic/enic_rxtx.c | 20 + > drivers/net/enic/enic_sriov.c | 801 ++++++++++++++++++++++++++ > drivers/net/enic/enic_sriov.h | 209 +++++++ > This new file is missing coopyright and license information. (Detected by './devtools/check-spdx-tag.sh' script) <...> > diff --git a/drivers/net/enic/enic_ethdev.c b/drivers/net/enic/enic_ethdev.c > index cad8db2f6f..5c967677fb 100644 > --- a/drivers/net/enic/enic_ethdev.c > +++ b/drivers/net/enic/enic_ethdev.c > @@ -21,6 +21,7 @@ > #include "vnic_rq.h" > #include "vnic_enet.h" > #include "enic.h" > +#include "enic_sriov.h" > > /* > * The set of PCI devices this driver supports > @@ -28,7 +29,6 @@ > #define CISCO_PCI_VENDOR_ID 0x1137 > static const struct rte_pci_id pci_id_enic_map[] = { > {RTE_PCI_DEVICE(CISCO_PCI_VENDOR_ID, PCI_DEVICE_ID_CISCO_VIC_ENET)}, > - {RTE_PCI_DEVICE(CISCO_PCI_VENDOR_ID, PCI_DEVICE_ID_CISCO_VIC_ENET_VF)}, > {RTE_PCI_DEVICE(CISCO_PCI_VENDOR_ID, PCI_DEVICE_ID_CISCO_VIC_ENET_SN)}, > Won't there be a specific PCIe device ID for the VF? Can there be some old devices around that requires this support? What is the difference between PCI_DEVICE_ID_CISCO_VIC_ENET_VF & PCI_DEVICE_ID_CISCO_VIC_ENET_SN? Current code seems detecting device as VF when the PCIe device ID is PCI_DEVICE_ID_CISCO_VIC_ENET_SN.