From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0491CA050A; Sat, 7 May 2022 09:10:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EEB5540696; Sat, 7 May 2022 09:10:32 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 8D2774068A; Sat, 7 May 2022 09:10:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651907431; x=1683443431; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uJitWxKdtAyfRRRohoDal21FPSRUvXkhn16vXXVFgRw=; b=T0aVD/kfTJ7mSxY7Vgj/D+JwWBIXSR4jdscZ/sMcNZBbxU5fL3oAmMN/ mdvaQ4+jPMbagyQouVtcOieAT+TM3l81M0fH9GDybSPQwwgKXIiQCgk6I vCxbKgfR2HJv0zmT4/HxSLqk8wyffly460NMZZcNKU2J+ZqqGW7mb3TBC qfOio6zaGUZey/C6UM4BU84ff+aiNHIp4s8qKA4OcejimeoFu3o2X9t/E BA+0RL546Re9yCKGuK/pMnbCySKgwhZcUjfS6i5o6UiE2WkWNUuxAIHVl OOsP0PRVu4b7UqTxhF9dmwxE3toYcmDeeRxxANh2SwW0J2tLTrArFGfjL g==; X-IronPort-AV: E=McAfee;i="6400,9594,10339"; a="329217356" X-IronPort-AV: E=Sophos;i="5.91,206,1647327600"; d="scan'208";a="329217356" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2022 00:10:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,206,1647327600"; d="scan'208";a="709794004" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 07 May 2022 00:10:30 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 7 May 2022 00:10:29 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 7 May 2022 00:10:29 -0700 Received: from fmsmsx612.amr.corp.intel.com ([10.18.126.92]) by fmsmsx612.amr.corp.intel.com ([10.18.126.92]) with mapi id 15.01.2308.027; Sat, 7 May 2022 00:10:29 -0700 From: "Zhang, Qi Z" To: "Zhang, Peng1X" , "Yang, Qiming" , "Zhou, YidingX" , "dev@dpdk.org" CC: "stable@dpdk.org" Subject: RE: [PATCH] net/ice: Modify DCF state checking mechanism and error code Thread-Topic: [PATCH] net/ice: Modify DCF state checking mechanism and error code Thread-Index: AQHYYFQdc2u3/qLOi0mfyTDGJPsmW60TAdLw Date: Sat, 7 May 2022 07:10:29 +0000 Message-ID: <81e3dc069d384b63bb4a05c843ae1675@intel.com> References: <20220505153932.401749-1-peng1x.zhang@intel.com> In-Reply-To: <20220505153932.401749-1-peng1x.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.401.20 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Peng1X > Sent: Thursday, May 5, 2022 11:40 PM > To: Yang, Qiming ; Zhang, Qi Z > ; Zhou, YidingX ; > dev@dpdk.org > Cc: Zhang, Peng1X ; stable@dpdk.org > Subject: [PATCH] net/ice: Modify DCF state checking mechanism and error > code >=20 > From: Peng Zhang >=20 > Add DCF state checking mechanism which will conduct whether reset is > done.And modify error code to avoid misleading. >=20 > Fixes: b71573ec2fc2 ("net/ice: retry getting VF VSI map after failure") > Cc: stable@dpdk.org >=20 > Signed-off-by: Peng Zhang > --- > drivers/net/ice/ice_dcf.c | 3 ++- > drivers/net/ice/ice_switch_filter.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c index > 7f0c074b01..3808272ea3 100644 > --- a/drivers/net/ice/ice_dcf.c > +++ b/drivers/net/ice/ice_dcf.c > @@ -544,7 +544,8 @@ ice_dcf_handle_vsi_update_event(struct ice_dcf_hw > *hw) >=20 > for (;;) { > if (ice_dcf_get_vf_resource(hw) =3D=3D 0 && > - ice_dcf_get_vf_vsi_map(hw) >=3D 0) { > + ice_dcf_get_vf_vsi_map(hw) >=3D 0 && > + ice_dcf_check_reset_done(hw) =3D=3D 0) { > err =3D 0; > break; > } > diff --git a/drivers/net/ice/ice_switch_filter.c > b/drivers/net/ice/ice_switch_filter.c > index 36c9bffb73..199a981018 100644 > --- a/drivers/net/ice/ice_switch_filter.c > +++ b/drivers/net/ice/ice_switch_filter.c > @@ -434,7 +434,7 @@ ice_switch_create(struct ice_adapter *ad, > flow->rule =3D filter_conf_ptr; > } else { > if (ice_dcf_adminq_need_retry(ad)) > - ret =3D -EAGAIN; > + ret =3D -EBUSY; what's wrong with -EAGAIN? Is it necessary? > else > ret =3D -EINVAL; >=20 > -- > 2.25.1