From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 7A7622C66 for ; Mon, 7 Mar 2016 12:19:11 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id n186so80806260wmn.1 for ; Mon, 07 Mar 2016 03:19:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=kf+ijEzA3xfyrQiOJD+YlYWb5htaQZ/OD6TSoA/CgFQ=; b=q729Ps1broFh3ioSWP3r53j+1Cl9TrtkeFlCMzIzyucJaqldl2tKxX2iYjucdb+yAA PNuPENJCgcic5VwWXzjXGQoNY5Z2EJmacgIMD0desINOapEpxp929Fn79sFhqZqu4JTk l0l+bsQK+52NUCyprcaUcANhDtIp7TKl3sGVC0/ifKg5ffA3zrxnsccnZxFvUtAUpDLr +9dS7ygZaG+JE44ph68fvFb0wyEtz4KXXExLyfcBLMvtKx7kSOWm8WYWaxrvopmLo7CE HFT5BuMHSBbPQZsE36sVxL8xoU27dh3rHPxyLNu7jDKSlx4TC+3X4QrYx0Bd9DpH08wY RDHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=kf+ijEzA3xfyrQiOJD+YlYWb5htaQZ/OD6TSoA/CgFQ=; b=RW7zGfsvbXKdip4witOS7hwCFaq038BQ1Jlv6cMJUj4xnPRBPQvJiN0QLv5Is6OEtM pvhxo6fAVA5k8xqWHX7y6NoSW2R3CZ0/zb8uuHHMVsXPOXxs9xF820YszjdqimmbN8YH XhgzF/PiZ9gPgIfglNRJ4v10fFK7XYxpa1Fo8fHIqXRU9MyoMygVxSV4wXed/IfTu1GZ ZwYZ8RLvQ2mHquvbUPwlNEZoSiKKL9kN8RxxCJvVOKqmnTGlFovpaRwtmIIcJddeetHn Cix8XPY+jgoJwLTB3Xseueg1B02lmUdaVnpw8E/MMdVSIRFE6AZ+ogSPw6b+Y9PLebBy 6lRw== X-Gm-Message-State: AD7BkJJgU2JYNJJpQtXxEl1pIYlmfNBSsOAEegbty/0caE2VTyWF+z1wpx9iSDg5lCvdYIqE X-Received: by 10.28.35.66 with SMTP id j63mr12528913wmj.78.1457349551292; Mon, 07 Mar 2016 03:19:11 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id gb9sm17444440wjb.26.2016.03.07.03.19.10 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 Mar 2016 03:19:10 -0800 (PST) From: Thomas Monjalon To: Fan Zhang Date: Mon, 07 Mar 2016 12:17:34 +0100 Message-ID: <8203471.f1i4Yl96V2@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1455707490-13826-2-git-send-email-roy.fan.zhang@intel.com> References: <1455707490-13826-1-git-send-email-roy.fan.zhang@intel.com> <1455707490-13826-2-git-send-email-roy.fan.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 1/4] lib/librte_port: add PCAP file support to source port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2016 11:19:11 -0000 2016-02-17 11:11, Fan Zhang: > --- a/lib/librte_port/rte_port_source_sink.h > +++ b/lib/librte_port/rte_port_source_sink.h > @@ -53,6 +53,13 @@ extern "C" { > struct rte_port_source_params { > /** Pre-initialized buffer pool */ > struct rte_mempool *mempool; > + /** The full path of the pcap file to read packets from */ > + char *file_name; > + /** The number of bytes to be read from each packet in the > + * pcap file. If this value is 0, the whole packet is read; > + * if it is bigger than packet size, the generated packets > + * will contain the whole packet */ > + uint32_t n_bytes_per_pkt; > }; If this struct is used in a table, changing its size will break the ABI. More generally, are you sure of the benefits of exposing a configuration structure in the API? [...] > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -111,6 +111,7 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lxenstore > _LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD) += -lgxio > # QAT PMD has a dependency on libcrypto (from openssl) for calculating HMAC precomputes > _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += -lcrypto > +_LDLIBS-$(CONFIG_RTE_PORT_PCAP) += -lpcap Please move this line upper before PMD_PCAP.