From: Thomas Monjalon <thomas@monjalon.net>
To: Suanming Mou <suanmingm@mellanox.com>
Cc: dev@dpdk.org, Matan Azrad <matan@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
xiangxia.m.yue@gmail.com, rasland@mellanox.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix incorrect pointer operation
Date: Tue, 07 Jan 2020 15:29:20 +0100 [thread overview]
Message-ID: <8204855.LtI52ktEx1@xps> (raw)
In-Reply-To: <1578387392-114282-1-git-send-email-suanmingm@mellanox.com>
Hi,
How this issue was seen? Is it related to the bug reported by Tonghao Zhang?
If yes, you may use "Reported-by:".
One comment about the title, please describe which area is fixed,
instead of "incorrect pointer operation" which is very generic.
The title should probably include the word "meter".
Then in the explanations below, please explain what is the impact of the bug.
Thanks
07/01/2020 09:56, Suanming Mou:
> The meter suffix flow item pointer restore is not correct to minus a
> fixed value. It should minus the real offset it increases.
>
> Set the value to the real offset the pointer increases to fix the issue.
>
> Fixes: 9ea9b049a960 ("net/mlx5: split meter flow")
> Cc: stable@dpdk.org
>
> Signed-off-by: Suanming Mou <suanmingm@mellanox.com>
> Tested-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
next prev parent reply other threads:[~2020-01-07 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 8:56 Suanming Mou
2020-01-07 14:29 ` Thomas Monjalon [this message]
2020-01-08 10:41 ` [dpdk-dev] [PATCH v2] net/mlx5: fix incorrect pointer operation in meter Suanming Mou
2020-01-20 13:08 ` Slava Ovsiienko
2020-01-20 14:03 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8204855.LtI52ktEx1@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=suanmingm@mellanox.com \
--cc=viacheslavo@mellanox.com \
--cc=xiangxia.m.yue@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).