From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E0C1A034F; Mon, 11 Oct 2021 10:06:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 405CE410DB; Mon, 11 Oct 2021 10:06:03 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 38BCF410DA for ; Mon, 11 Oct 2021 10:06:02 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 784C07F50A; Mon, 11 Oct 2021 11:06:01 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 784C07F50A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1633939561; bh=GXRvTti9BvkC2yQuibqSxgu/2UsaIVeR7kOPnIpc8io=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=GXM8Vl4nlTxypwWy9LpevZSNkoQl3C2Fa5LdoQhIfWro0MGCAUhqOIN/9YGa4U8mk xNpGyI+trnNBPc/tUqTrItw0gCaUveigJzGYptb2Y4yvBdvVqgQ3VYeMCZxR3mp53A oYE8tCHjezPQtj6EXru+tRNa7ngK8nPXAukwx24k= To: Konstantin Ananyev , dev@dpdk.org Cc: xiaoyun.li@intel.com, anoobj@marvell.com, jerinj@marvell.com, ndabilpuram@marvell.com, adwivedi@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, irusskikh@marvell.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, rahul.lakkireddy@chelsio.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, haiyue.wang@intel.com, johndale@cisco.com, hyonkim@cisco.com, qi.z.zhang@intel.com, xiao.w.wang@intel.com, humin29@huawei.com, yisen.zhuang@huawei.com, oulijun@huawei.com, beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com, matan@nvidia.com, viacheslavo@nvidia.com, sthemmin@microsoft.com, longli@microsoft.com, heinrich.kuhn@corigine.com, kirankumark@marvell.com, mczekaj@marvell.com, jiawenwu@trustnetic.com, jianwang@trustnetic.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, thomas@monjalon.net, ferruh.yigit@intel.com, mdr@ashroe.eu, jay.jayatheerthan@intel.com References: <20211004135603.20593-1-konstantin.ananyev@intel.com> <20211007112750.25526-1-konstantin.ananyev@intel.com> <20211007112750.25526-4-konstantin.ananyev@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <820da9f2-4526-8757-9218-3fb622ccb122@oktetlabs.ru> Date: Mon, 11 Oct 2021 11:06:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211007112750.25526-4-konstantin.ananyev@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 3/7] ethdev: change input parameters for rx_queue_count X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/7/21 2:27 PM, Konstantin Ananyev wrote: > Currently majority of fast-path ethdev ops take pointers to internal > queue data structures as an input parameter. > While eth_rx_queue_count() takes a pointer to rte_eth_dev and queue > index. > For future work to hide rte_eth_devices[] and friends it would be > plausible to unify parameters list of all fast-path ethdev ops. > This patch changes eth_rx_queue_count() to accept pointer to internal > queue data as input parameter. > While this change is transparent to user, it still counts as an ABI change, > as eth_rx_queue_count_t is used by ethdev public inline function > rte_eth_rx_queue_count(). > > Signed-off-by: Konstantin Ananyev Reviewed-by: Andrew Rybchenko The patch introduces a number usages of rte_eth_devices in drivers. As I understand it is undesirable, but I don't think it is a blocker of the patch series. It should be addresses separately.