From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id F38481D7; Tue, 13 Nov 2018 18:47:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2018 09:47:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,228,1539673200"; d="scan'208";a="104057383" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.252.9.8]) ([10.252.9.8]) by fmsmga002.fm.intel.com with ESMTP; 13 Nov 2018 09:47:43 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, Bruce Richardson , vipin.varghese@intel.com, stable@dpdk.org References: <88cced4f601c44c6203b9adb09abacdce0b3a260.1542122595.git.anatoly.burakov@intel.com> <7096e585fd36399cea92dd32fe1f19b051697bec.1542124270.git.anatoly.burakov@intel.com> <2394199.rkv9bdJ101@xps> From: "Burakov, Anatoly" Message-ID: <821e4582-5594-d291-6047-d6e5ba7b120f@intel.com> Date: Tue, 13 Nov 2018 17:47:43 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <2394199.rkv9bdJ101@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Nov 2018 17:47:46 -0000 On 13-Nov-18 4:57 PM, Thomas Monjalon wrote: > 13/11/2018 16:54, Anatoly Burakov: >> When creating process data structures, EAL will create many files >> in EAL runtime directory. Because we allow multiple secondary >> processes to run, each secondary process gets their own unique >> file. With many secondary processes running and exiting on the >> system, runtime directory will, over time, create enormous amounts >> of sockets, fbarray files and other stuff that just sits there >> unused because the process that allocated it has died a long time >> ago. This may lead to exhaustion of disk (or RAM) space in the >> runtime directory. >> >> Fix this by removing every unlocked file at initialization that >> matches either socket or fbarray naming convention. We cannot be >> sure of any other files, so we'll leave them alone. Also, remove >> similar code from mp socket code. >> >> We do it at the end of init, rather than at the beginning, because >> secondary process will use primary process' data structures even >> if the primary itself has died, and we don't want to remove those >> before we lock them. >> >> Bugzilla ID: 106 >> >> Cc: stable@dpdk.org >> >> Reported-by: Vipin Varghese >> >> Signed-off-by: Anatoly Burakov > > I feel it is too big and too late for 18.11. > Can we move it to 19.02? > From maintainer's point of view, i agree that it's too risky to merge into 18.11 at this stage. My input should probably stop there, but Vipin (the original bug reporter) may have other thoughts on this matter. -- Thanks, Anatoly