DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] doc: add testpmd latencystats option
@ 2024-01-09 23:08 Stephen Hemminger
  2024-01-10 18:11 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2024-01-09 23:08 UTC (permalink / raw)
  To: dev
  Cc: Stephen Hemminger, Aman Singh, Yuying Zhang, Remy Horton,
	Reshma Pattan, Harry van Haaren

Option was added but never added to documentation.

Fixes: 62d3216d6194 ("app/testpmd: add latency statistics calculation")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 doc/guides/testpmd_app_ug/run_app.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst
index 24a086401ee7..e149373cd235 100644
--- a/doc/guides/testpmd_app_ug/run_app.rst
+++ b/doc/guides/testpmd_app_ug/run_app.rst
@@ -422,6 +422,10 @@ The command line options are:
 
     Set the logical core N to perform bitrate calculation.
 
+*   ``--latencystats=N``
+
+    Set the logical core N to perform latency calculation.
+
 *   ``--print-event <unknown|intr_lsc|queue_state|intr_reset|vf_mbox|macsec|intr_rmv|dev_probed|dev_released|flow_aged|err_recovering|recovery_success|recovery_failed|all>``
 
     Enable printing the occurrence of the designated event. Using all will
-- 
2.43.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] doc: add testpmd latencystats option
  2024-01-09 23:08 [PATCH] doc: add testpmd latencystats option Stephen Hemminger
@ 2024-01-10 18:11 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2024-01-10 18:11 UTC (permalink / raw)
  To: Stephen Hemminger, dev
  Cc: Aman Singh, Yuying Zhang, Remy Horton, Reshma Pattan, Harry van Haaren

On 1/9/2024 11:08 PM, Stephen Hemminger wrote:
> Option was added but never added to documentation.
> 
> Fixes: 62d3216d6194 ("app/testpmd: add latency statistics calculation")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  doc/guides/testpmd_app_ug/run_app.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst
> index 24a086401ee7..e149373cd235 100644
> --- a/doc/guides/testpmd_app_ug/run_app.rst
> +++ b/doc/guides/testpmd_app_ug/run_app.rst
> @@ -422,6 +422,10 @@ The command line options are:
>  
>      Set the logical core N to perform bitrate calculation.
>  
> +*   ``--latencystats=N``
> +
> +    Set the logical core N to perform latency calculation.
> +
>

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

Applied to dpdk-next-net/main, thanks.


Help output also mentions from jitter calculation [1] and jitter is
actually calculated, so changed document as following while merging:

"Set the logical core N to perform latency and jitter calculations."


[1]
In 'app/test-pmd/parameters.c', help documents as following:
  "  --latencystats=N: enable latency and jitter statistics monitoring
on forwarding lcore id N."



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-10 18:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-09 23:08 [PATCH] doc: add testpmd latencystats option Stephen Hemminger
2024-01-10 18:11 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).