From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D27FA0C41; Thu, 30 Sep 2021 11:04:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83FB040DDA; Thu, 30 Sep 2021 11:04:05 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 9EC9E4067E for ; Thu, 30 Sep 2021 11:04:03 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10122"; a="247677423" X-IronPort-AV: E=Sophos;i="5.85,335,1624345200"; d="scan'208";a="247677423" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 02:04:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,335,1624345200"; d="scan'208";a="520275198" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga008.fm.intel.com with ESMTP; 30 Sep 2021 02:04:01 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 02:04:01 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 02:04:01 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 02:04:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S1w+y+3TTe7Vxf1vpp5FzLbOKQTVkDL+zkNvoQNSZX4CQLlGXekRC4dernV/HvbyjKxqMwdOYutpzpIjhFpvzqo53QckPks2Jq/77zBWNr/MhvRCd+ySgThFoUMCmsvo2functSv+i03+mNZRdseu1S/4bjlaPT5VF4xPCs4FR4hJe9lsyrBKNNqsckWXQYi5kIimkbLxvqR2jFZwH1H8SCfpFraTnwaonJ+wApyy4r1WbKfBvIYhQpqZur4sPDvSbNL+vaf8MeEns4+LGQnSj8G6kUBpl3+Py7b+bh7vrJ6is4YPYJicFEdwDcU/xqVxeTOxylqax5k7ti9xzRXVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3kErQFpRYaqDlNIvjeGnh5YmEhxUd+QXgFCna4hrV+o=; b=PhW2VRY073EvvnG8y5qjvqKod9avW28SfzyKt2S6Ebobx5n/E97rApIUFXFAtsS9h/xf52J+nHgeGyRzKl4jwAK9U90RQmkdQlRXli4TtjNv72/cZHAPftixilN5Ep9pKKMwvlVaUUcVqQrLvV/Ocn+3Nn1yJkL3PiPU9hbLp9TFjA5aglOixF553CZ0gYH0JVuzbQkEJfx/vOnygN7IW2slFef/VMWDiAPEfZIUkLExZoyHvOHIZy2wbBszfx+cux85IKOQc22RjT31SKszothSqdYDOJ2jlPwKmddcD+YV8J9XaNMe3dEEz3GSXh1ojjEicwTk3axvM9Z9gO5G2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3kErQFpRYaqDlNIvjeGnh5YmEhxUd+QXgFCna4hrV+o=; b=DtGadD7JiaLN5vC030nllQuVtHG73RUSSjnWXoUW6blEnTKVk2XYbtRsuZhh/hCxFJPVqwXirKSqqzS6gt10tBo+Q9ueRpoYSBipBcZEicesNs3vXCNayv4x2VgGZVb/3io2+ekk5S2e/BbSeOdJCIl0GLnBs0TMEpOFC3L01W4= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB4879.namprd11.prod.outlook.com (2603:10b6:a03:2da::8) by SJ0PR11MB4909.namprd11.prod.outlook.com (2603:10b6:a03:2af::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Thu, 30 Sep 2021 09:03:58 +0000 Received: from SJ0PR11MB4879.namprd11.prod.outlook.com ([fe80::4d2f:6c7:757c:8e93]) by SJ0PR11MB4879.namprd11.prod.outlook.com ([fe80::4d2f:6c7:757c:8e93%5]) with mapi id 15.20.4544.021; Thu, 30 Sep 2021 09:03:58 +0000 To: "Ananyev, Konstantin" , Olivier Matz CC: "dev@dpdk.org" , "mdr@ashroe.eu" , "Medvedkin, Vladimir" , "Richardson, Bruce" , "Zhang, Roy Fan" , "hemant.agrawal@nxp.com" , "gakhil@marvell.com" , "anoobj@marvell.com" , "Doherty, Declan" , "Sinha, Abhijit" , "Buckley, Daniel M" , "marchana@marvell.com" , "ktejasree@marvell.com" , "matan@nvidia.com" References: <20210713133542.3550525-1-radu.nicolau@intel.com> <20210917091747.1528262-1-radu.nicolau@intel.com> <20210917091747.1528262-5-radu.nicolau@intel.com> From: "Nicolau, Radu" Message-ID: <8233b094-64a9-fb6b-279e-c867eb327899@intel.com> Date: Thu, 30 Sep 2021 10:03:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-ClientProxiedBy: DB6PR1001CA0042.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::28) To SJ0PR11MB4879.namprd11.prod.outlook.com (2603:10b6:a03:2da::8) MIME-Version: 1.0 Received: from [192.168.1.12] (109.255.186.106) by DB6PR1001CA0042.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Thu, 30 Sep 2021 09:03:55 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d0578e99-3455-4511-93b2-08d983f13cdf X-MS-TrafficTypeDiagnostic: SJ0PR11MB4909: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A4KRA/T4eDEci9xiDnNN/Ze2hcr1+etkyiza7xsBNwixYpRJtQdawZSFHeQIB7wg7pZCpxLB0wk1X0rRBzhFt1DKaoMkyKbJwhp8sIYW/OhuxEXfXO223pFrIDJJH2ScSPZWfGxIVqKz30Q8hYYba4aQiLeIJPPx/Na0w2C1u4nJsI3dfu5DTMUR8dseovolL1i729uZ2L6GjQbaPAEsFxaVTDtAfxkJe/ldh5Y8sIydFLDmxVlxcJDl71sdQ0ZC/ETvwngnPPfrMWGWUPuvKgFz0VZ6zxesI4T6j6qyqEh+XZJXJnrfh1woCiOBGfdi0GeNl+vpqNLCK+5WlrmIF0ig1o6XgxyULgRnaKto2kugBtf4VRSUlxHfZMPAHwEjVW9v3kYd9BiSh35HrjYTX6rBGurnmp0F1uwWo1gWtFY8ywXcH+jBjG6dH86rXkVSg3peZRvB1jXubjUjozEW4W2ieIxGbwsKCxOYVKSlXVQKfSKee5mptqrUp3nqWjHDlJAfzExAopSVbna9fRPrmePAzJx/hxtHdJhpuJswC6cqtwW3otknnQh1C3Qv2WAq3ahD3pH45cWmhvUX03TTSJ6ai0BXqh7+mn8kxmv2bM5/Ac4L2HDDMGqcpVQvyCvtu3niUWwEpc3CXml9MB0M1f/pwwiNEEM9AlgPH4c976KX/xaI88byfGNRa2OufABfV22kKEd9U78UccJDxi+c59CLMjrYq8OeiCz0dClStm4= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB4879.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(55236004)(53546011)(110136005)(6486002)(83380400001)(8936002)(16576012)(6666004)(66946007)(4326008)(508600001)(8676002)(5660300002)(36756003)(316002)(54906003)(31686004)(66476007)(2906002)(66556008)(31696002)(2616005)(956004)(38100700002)(186003)(26005)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a05oMWYwM1A2SnE4Vm1BTlhnZHg3QlZRNEFydk0vbEhXcUhXV2NnUW54M1B1?= =?utf-8?B?TnpMQUtZWGtiWkhtUHNGcVZ1ZDFhZTFJTGRWbGNUd0dwZnVVZ3crMWtvSXhG?= =?utf-8?B?SXUzWEYwcUFrTWk3aWNqdzRNU2RaWlUrRjlYaHgvWU12Z3oyMjFsd0ZUWFAw?= =?utf-8?B?ZTluVldLSVdQYmNvaE1WdURtaXVaM2xSN2JSVWRxT3pCQ1RGd2E2LzVlQmVH?= =?utf-8?B?eFJWMHlkVTBKWmxRcmRWdmtPeUhiSWNOYmFib2R5bkhpaFh4VmtKOFVPNmpn?= =?utf-8?B?Q2MreDV3b2tpQ0NnQVYvQ0o3QjB5STBnZHBuS0FBNGo0OUkyNnd1QTNJYzJC?= =?utf-8?B?ekZKNVRpam4yM2NqQUxXeWE5NVZiV0tkUEcyaUNTQ1ZKMHdyUmU1ZlRYWGFh?= =?utf-8?B?cXVNSFpObC9KcmJmWFA1YTQ3OGFUVmEyT0hWdWVwR0pNQ21UZ1hWSU9GVUE1?= =?utf-8?B?NkJiK2NEenB2eHBYajVZZTMxVjNmaUxaQXFkT0JXbFByLzJ2bWViM1BXQjl2?= =?utf-8?B?VHpPTmpJSVNYY1FkMytWekc5WDQ4aTQxUk1zNmFJSStBOGJrTWU1Q0k3Ulpx?= =?utf-8?B?U2h6Y0Y0eDl1K3ZUWVZjTWxVWTRHS1dIT1hTSXdDRUhUZVpzK0JETzNZN0dG?= =?utf-8?B?eFJZUWRNQUllVjJMVmVnYm1xK3BVQ0lNOWVZSEpPRnNhb3dZYkMxTFd1d0tP?= =?utf-8?B?N3krZFd2ZEVzZEt0TnY1cldkdzVFd3RCTnhGbzR4aE5hb01IamI4RXJ5a2hO?= =?utf-8?B?Zk9WcFpjbTVXbTBzKzUzMjRVRUFnYytOKzhzYTREUGRDTzJXTVRhZUthbXJi?= =?utf-8?B?bE4vVnhJdEdJdHQ3eVpmMWlaazZwQnEwTmlrek03Ky8raFlCWms5MjlwUXVa?= =?utf-8?B?MWF6cExsY3FlRkZ5R2NsUkFETWVaeW9XYm9FdGF0M1daR0VuNmV5YytlbVg5?= =?utf-8?B?NE53YUhkNTdsb1k0dkwzSk9uTjg1ZFk1bjdDMlhFRU5wcmVNZHphYjRPcVhC?= =?utf-8?B?YmVDRDVRQnI1ZXN1UFkzWkFCS2RwclhNTUZYcXZvUExCblRvY21NWFFkZ1ZK?= =?utf-8?B?VkFkSlY4Ymo1STRkZjhUcTBRUnJyM00rdkdBdTBnVm0wNWkvcXhtc3N1WDZx?= =?utf-8?B?OGlKT1dGakZ4RGlTUkR2QlFkTXdjSHZqbFArTGt5MU5Vbmxxbi9GdmVzVHp6?= =?utf-8?B?bzRaMVZKUk1LNXlUa2JZVzF5RW9YWHRBMGI0dm9hUVd3Mml6V3FHd2UzQ0Rv?= =?utf-8?B?eTVkc0pNRmE5cjBHUEoyYUFPeDRhWWZ2Ry8vMytPYTJ4ZGovdXFTVFVGY1o5?= =?utf-8?B?clNvYk9oekFkNmlseStJeHhRbXNBQ05Xa01xNlk5WjZQR2NpbnAyTU10UExR?= =?utf-8?B?akJoWUlSTWorblJTdERNU1NYcmoybkhTYTg2bTV2MXo0bktIaVFkNTlRSy9S?= =?utf-8?B?TVBYTDJtN0pYVnA4MVE5YTBmTHpHdUtHN3ZUellHdTFDQWd4L1hvZUt1RDVQ?= =?utf-8?B?RmZTL1ZYaE10RGlsQ0lNblduUk1IZHhaYWtmMjNDODNVdVltWFpBa2dLTGNW?= =?utf-8?B?TDgyU3NCWDZyZ3huVXBFRWgyeG5PbG1nSlBlUEpjVGZOcWNSZXk3cExtYWk0?= =?utf-8?B?WFhnS3BtWkRyK0RnYmNBR1JUZFppSmJoa1B1QjJwZjkraWxHYW56dkJlNUUy?= =?utf-8?B?ME5ZZ3BveWt1NDdRczlBL1lIQXlWamNFLysyeE9OY2FKa2NpTkNDOXRpeVRq?= =?utf-8?Q?FaiQGNjjqpNb0MWSCCbDZx5rqICYikD/ao4QGuG?= X-MS-Exchange-CrossTenant-Network-Message-Id: d0578e99-3455-4511-93b2-08d983f13cdf X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB4879.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 09:03:58.3568 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: obeJ8Zh2vzQCovwXC17ktykD1famrO1d+8vAbbxvf+LQg0btPB8iG21pag5oYSSP1ll5FgKYkjZcvDSGfd8FXw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4909 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v6 04/10] mbuf: add IPsec ESP tunnel type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/23/2021 1:59 PM, Ananyev, Konstantin wrote: >> Add tunnel type for IPsec ESP tunnels >> >> Signed-off-by: Declan Doherty >> Signed-off-by: Radu Nicolau >> Signed-off-by: Abhijit Sinha >> Signed-off-by: Daniel Martin Buckley >> Acked-by: Fan Zhang >> Acked-by: Akhil Goyal >> Acked-by: Olivier Matz >> --- >> lib/mbuf/rte_mbuf_core.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/mbuf/rte_mbuf_core.h b/lib/mbuf/rte_mbuf_core.h >> index bb38d7f581..a4d95deee6 100644 >> --- a/lib/mbuf/rte_mbuf_core.h >> +++ b/lib/mbuf/rte_mbuf_core.h >> @@ -253,6 +253,7 @@ extern "C" { >> #define PKT_TX_TUNNEL_MPLSINUDP (0x5ULL << 45) >> #define PKT_TX_TUNNEL_VXLAN_GPE (0x6ULL << 45) >> #define PKT_TX_TUNNEL_GTP (0x7ULL << 45) >> +#define PKT_TX_TUNNEL_ESP (0x8ULL << 45) > As I can see, that's not ptype, that's TX flag. > Could you clarify what exactly what flag would mean for PMD TX: > - what is expected from the user who sets this flag > - what is expected from PMD that claims to support it. > > BTW, would we need new DEV_TX_OFFLOAD_* for it? There is documentation above for the other tunnel types, they are supposed to be used for TSO purposes. I will update the commit message to clarify this. > >> /** >> * Generic IP encapsulated tunnel type, used for TSO and checksum offload. >> * It can be used for tunnels which are not standards or listed above. >> -- >> 2.25.1