From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Chaoyong He <chaoyong.he@corigine.com>, dev@dpdk.org
Cc: oss-drivers@corigine.com, niklas.soderlund@corigine.com,
Qin Ke <qin.ke@corigine.com>,
stable@dpdk.org, Peng Zhang <peng.zhang@corigine.com>
Subject: Re: [PATCH] net/nfp: fix add redundant read configure operations
Date: Tue, 20 Jun 2023 18:53:01 +0100 [thread overview]
Message-ID: <823d32e9-d9ad-45fc-7f52-8d338488a7be@amd.com> (raw)
In-Reply-To: <20230614055116.784145-1-chaoyong.he@corigine.com>
On 6/14/2023 6:51 AM, Chaoyong He wrote:
> From: Qin Ke <qin.ke@corigine.com>
>
> Performance is reduced because of adding redundant read configure
> operations in nfp_net_parse_ptype() called by nfp_net_recv_pkts(),
> which cause every received packet to spend more time.
>
> Fix the performance issue by deleting the redundant code directly.
>
> Fixes: 2e7c36128be ("net/nfp: report packet type by Rx descriptor")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qin Ke <qin.ke@corigine.com>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
> Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
Applied to dpdk-next-net/main, thanks.
<...>
> diff --git a/drivers/net/nfp/nfp_rxtx.c b/drivers/net/nfp/nfp_rxtx.c
> index 9867db4388..297864450b 100644
> --- a/drivers/net/nfp/nfp_rxtx.c
> +++ b/drivers/net/nfp/nfp_rxtx.c
> @@ -317,7 +317,8 @@ nfp_net_parse_meta(struct nfp_net_rx_desc *rxds,
> * Mbuf to set the packet type.
> */
> static void
> -nfp_net_set_ptype(const struct nfp_ptype_parsed *nfp_ptype, struct rte_mbuf *mb)
> +nfp_net_set_ptype(const struct nfp_ptype_parsed *nfp_ptype,
> + struct rte_mbuf *mb)
Above unrelated modification dropped while merging.
prev parent reply other threads:[~2023-06-20 17:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 5:51 Chaoyong He
2023-06-20 17:53 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=823d32e9-d9ad-45fc-7f52-8d338488a7be@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=peng.zhang@corigine.com \
--cc=qin.ke@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).