* [dpdk-dev] [PATCH] net/mlx5: fix flow director deletion
@ 2017-11-13 10:25 Nelio Laranjeiro
2017-11-13 16:56 ` Yongseok Koh
0 siblings, 1 reply; 3+ messages in thread
From: Nelio Laranjeiro @ 2017-11-13 10:25 UTC (permalink / raw)
To: dev; +Cc: Yongseok Koh, Adrien Mazarguil
The speciation are wrongly computed causing the rule to not be match
correctly for deletion.
Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
drivers/net/mlx5/mlx5_flow.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 3df8fba4e..466d74b5f 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -2915,8 +2915,8 @@ priv_fdir_filter_delete(struct priv *priv,
if (memcmp(spec, flow_spec,
RTE_MIN(attr_h->size, flow_h->size)))
goto wrong_flow;
- spec = (void *)((uintptr_t)attr + attr_h->size);
- flow_spec = (void *)((uintptr_t)flow_attr +
+ spec = (void *)((uintptr_t)spec + attr_h->size);
+ flow_spec = (void *)((uintptr_t)flow_spec +
flow_h->size);
}
/* At this point, the flow match. */
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow director deletion
2017-11-13 10:25 [dpdk-dev] [PATCH] net/mlx5: fix flow director deletion Nelio Laranjeiro
@ 2017-11-13 16:56 ` Yongseok Koh
2017-11-14 7:56 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Yongseok Koh @ 2017-11-13 16:56 UTC (permalink / raw)
To: Nélio Laranjeiro; +Cc: dev, Adrien Mazarguil
> On Nov 13, 2017, at 4:25 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
>
> The speciation are wrongly computed causing the rule to not be match
> correctly for deletion.
>
> Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director")
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> ---
There's a typo in the commit message, speciation -> specification.
Except for that,
Acked-by: Yongseok Koh <yskoh@mellanox.com>
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mlx5: fix flow director deletion
2017-11-13 16:56 ` Yongseok Koh
@ 2017-11-14 7:56 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2017-11-14 7:56 UTC (permalink / raw)
To: Yongseok Koh, Nélio Laranjeiro; +Cc: dev, Adrien Mazarguil
13/11/2017 17:56, Yongseok Koh:
>
> > On Nov 13, 2017, at 4:25 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
> >
> > The speciation are wrongly computed causing the rule to not be match
> > correctly for deletion.
> >
> > Fixes: 4c3e9bcdd52e ("net/mlx5: support flow director")
> >
> > Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> > ---
>
> There's a typo in the commit message, speciation -> specification.
> Except for that,
>
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-14 7:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-13 10:25 [dpdk-dev] [PATCH] net/mlx5: fix flow director deletion Nelio Laranjeiro
2017-11-13 16:56 ` Yongseok Koh
2017-11-14 7:56 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).