From: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, <stephen@networkplumber.org>
Subject: Re: [PATCH] test/fib: clarify FIB RCU negative tests
Date: Thu, 7 Nov 2024 17:02:36 +0000 [thread overview]
Message-ID: <8259f1c9-0f76-4f26-9a6e-5e11a54e94cd@intel.com> (raw)
In-Reply-To: <CAJFAV8yuuFDu6Lj6Gb-WpuWnvFcM33qkVm9Ath5rjooE83mkhg@mail.gmail.com>
Hi David,
On 07/11/2024 13:00, David Marchand wrote:
> On Wed, Oct 16, 2024 at 8:42 PM Vladimir Medvedkin
> <vladimir.medvedkin@intel.com> wrote:
>> @@ -445,7 +454,7 @@ test_invalid_rcu(void)
>> rcu_cfg.v = qsv2;
>> rcu_cfg.mode = RTE_FIB_QSBR_MODE_SYNC;
>> status = rte_fib_rcu_qsbr_add(fib, &rcu_cfg);
>> - RTE_TEST_ASSERT(status != 0, "Secondary RCU was mistakenly attached\n");
>> + RTE_TEST_ASSERT(status = -EEXIST, "Secondary RCU was mistakenly attached\n");
> My eyes stopped on this.
> Should be == right?
You right, thanks!
Will send v2
>
>> rte_fib_free(fib);
>> rte_free(qsv);
>
--
Regards,
Vladimir
next prev parent reply other threads:[~2024-11-07 17:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-16 18:42 Vladimir Medvedkin
2024-10-16 20:33 ` Stephen Hemminger
2024-11-07 13:00 ` David Marchand
2024-11-07 17:02 ` Medvedkin, Vladimir [this message]
2024-11-07 17:04 ` [PATCH v2] " Vladimir Medvedkin
2024-11-08 14:16 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8259f1c9-0f76-4f26-9a6e-5e11a54e94cd@intel.com \
--to=vladimir.medvedkin@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).