From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B5FDA2EEB for ; Tue, 10 Sep 2019 10:06:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3F9F1EB38; Tue, 10 Sep 2019 10:06:55 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id D1F8E1EB38 for ; Tue, 10 Sep 2019 10:06:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Sep 2019 01:06:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,489,1559545200"; d="scan'208";a="268333033" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.4]) ([10.237.221.4]) by orsmga001.jf.intel.com with ESMTP; 10 Sep 2019 01:06:51 -0700 To: "Wang, Haiyue" , "Richardson, Bruce" Cc: Ray Kinsella , "dev@dpdk.org" , "Sun, Chenmin" References: <1565665572-65495-1-git-send-email-haiyue.wang@intel.com> <1565665572-65495-2-git-send-email-haiyue.wang@intel.com> <20190812202436.662e6ca8@hermes.lan> <75f88e4b-97ca-7e1f-1385-8e69f659be7f@intel.com> <20190909124038.GA1889@bricha3-MOBL.ger.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <8268b844-2815-5e0d-87cf-c6e9ca5c9f34@intel.com> Date: Tue, 10 Sep 2019 09:06:50 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/10/2019 5:36 AM, Wang, Haiyue wrote: > Thanks Ferruh, Bruce. > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Monday, September 9, 2019 21:18 >> To: Richardson, Bruce >> Cc: Wang, Haiyue ; Ray Kinsella ; dev@dpdk.org; Sun, Chenmin >> >> Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information >> >> On 9/9/2019 1:50 PM, Ferruh Yigit wrote: >>> On 9/9/2019 1:40 PM, Bruce Richardson wrote: >>>> On Mon, Sep 09, 2019 at 12:23:36PM +0100, Ferruh Yigit wrote: >>>>> On 9/7/2019 3:42 AM, Wang, Haiyue wrote: >>>>>>> -----Original Message----- >>>>>>> From: Yigit, Ferruh >>>>>>> Sent: Friday, September 6, 2019 22:22 >>>>>>> To: Ray Kinsella ; Wang, Haiyue >>>>>>> Cc: dev@dpdk.org >>>>>>> Subject: Re: [dpdk-dev] [RFC v2 1/3] ethdev: add the API for getting trace information >>>>>>> >>>>>>> On 8/13/2019 1:51 PM, Ray Kinsella wrote: >>>>>>>> >>>>>>>> >>>>>>>> On 13/08/2019 04:24, Stephen Hemminger wrote: >>>>>>>>> On Tue, 13 Aug 2019 11:06:10 +0800 >>>>>>>>> Haiyue Wang wrote: >>>>>>>>> >>>>>>>>>> Enhance the PMD to support retrieving trace information like >>>>>>>>>> Rx/Tx burst selection etc. >>>>>>>>>> >>>>>>>>>> Signed-off-by: Haiyue Wang >>>>>>>>>> --- >>>>>>>>>> lib/librte_ethdev/rte_ethdev.c | 18 ++++++++++++++++++ >>>>>>>>>> lib/librte_ethdev/rte_ethdev.h | 9 +++++++++ >>>>>>>>>> lib/librte_ethdev/rte_ethdev_core.h | 4 ++++ >>>>>>>>>> 3 files changed, 31 insertions(+) >>>>>>>>>> >>>>>>>>>> diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c >>>>>>>>>> index 17d183e..6098fad 100644 >>>>>>>>>> --- a/lib/librte_ethdev/rte_ethdev.c >>>>>>>>>> +++ b/lib/librte_ethdev/rte_ethdev.c >>>>>>>>>> @@ -4083,6 +4083,24 @@ rte_eth_tx_queue_info_get(uint16_t port_id, uint16_t queue_id, >>>>>>>>>> } >>>>>>>>>> >>>>>>>>>> int >>>>>>>>>> +rte_eth_trace_info_get(uint16_t port_id, uint16_t queue_id, >>>>>>>>>> + enum rte_eth_trace type, char *buf, int sz) >>>>>>> >>>>>>> Better to use struct as argument instead of individual variables because it is >>>>>>> easier to extend the struct later if needed. >>>>>>> >>>>>>>>>> +{ >>>>>>>>>> + struct rte_eth_dev *dev; >>>>>>>>>> + >>>>>>>>>> + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); >>>>>>>>>> + >>>>>>>>>> + if (buf == NULL) >>>>>>>>>> + return -EINVAL; >>>>>>>>>> + >>>>>>>>>> + dev = &rte_eth_devices[port_id]; >>>>>>>>>> + >>>>>>>>>> + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->trace_info_get, -ENOTSUP); >>>>>>>>>> + >>>>>>>>>> + return dev->dev_ops->trace_info_get(dev, queue_id, type, buf, sz); >>>>>>>>> >>>>>>>>> What if queueid is out of bounds? >>>>>>>>> >>>>>>>>> The bigger problem is that this information is like a log message >>>>>>>>> and unstructured, which makes it device specific and useless for automation. >>>>>>>> >>>>>>>> IMHO - this is much better implemented as a capability bitfield, that >>>>>>>> can be queried. >>>>>>> >>>>>>> +1 to return the datapath capability as bitfield. >>>>>>> >>>>>>> Also +1 to have a new API, >>>>>>> - I am not sure about the API name, 'rte_eth_trace_info_get()', can we find >>>>>>> something better instead of 'trace' there. >>>>>>> - I think we should limit this API only to get current datapath configuration, >>>>>>> for clarity of the API don't return capability or not datapath related config. >>>>>>> >>>>>>> Also this information not always supported in queue level, what do you think >>>>>>> having ability to get this information in port level, >>>>>>> like this API can return a struct, which may have a field that says if the >>>>>>> output is for queue or port, or this can be another bitfield, what do you think? >>>>>>> >>>>>> >>>>>> #define RX_SCALAR (1ULL < 0) >>>>>> #define RX_VECTOR_AVX2 ... >>>>> >>>>> What about having RX_VECTOR value, later another bit group for the details of >>>>> the vectorization: >>>>> SSE >>>>> AVX2 >>>>> AVX512 >>>>> NEON >>>>> ALTIVEC >>>>> >>>>> Since above options can exist together, what about using values for them instead >>>>> of bitfields? Reserving 4 bits, 2^4 = 16, can be enough I think for long term. >>>>> >>>> Rather than having named vector types, we just need to worry about the ones >>>> for the current architecture. Therefore I'd suggest just using vector >>>> widths, one bit each for 16B, 32B and 64B vector support. For supporting >>>> multiple values, 16 combinations is not enough for all the possibilities. >>>> >>> >>> vector width can be an option too, no objection there. But this is only for >>> current configuration, so it can be a combination, we have now 5 types and >>> allocating space for 16. >>> >> >> correction: it can *not* be a combination > > I think we can merge the RX_VECTOR and TX_VECTOR together, use 6 bits for vector > mode detail. And for vector width, the SSE, NEON name should indicates it ? > > I renamed the definitions to try to make things clear. > > enum rte_eth_burst_mode_option { > BURST_SCALAR = (1 << 0), > BURST_VECTOR = (1 << 1), > > BURST_VECTOR_MODE_MASK = (0x3F << 2), > BURST_ALTIVEC = (1 << 2), > BURST_NEON = (2 << 2), > BURST_SSE = (3 << 2), > BURST_AVX2 = (4 << 2), > BURST_AVX512 = (5 << 2), Do we need to have bitfields for this, I was suggesting reserve 4 bits, bit 2-5 (inclusive) and use their value: BURST_VECTOR_MODE_IDX = 2 BURST_VECTOR_MODE_SIZE = 4 BURST_VECTOR_MODE_MASK = ((1 << BURST_VECTOR_MODE_SIZE) - 1) << BURST_VECTOR_MODE_IDX vector_mode = (options & BURST_VECTOR_MODE_MASK) >> BURST_VECTOR_MODE_IDX if (vector_mode == 0) // BURST_SSE if (vector_mode == 1) // BURST_AVX2 if (vector_mode == 2) // BURST_AVX512 if (vector_mode == 3) // BURST_NEON .... Can any vector mode be combination of above, if not why use bitfields? > > BURST_SCATTERED = (1 << 8), > BURST_BULK_ALLOC = (1 << 9), > BURST_NORMAL = (1 << 10), Not sure about this one, what is the difference between scalar? > BURST_SIMPLE = (1 << 11), > }; > > /** > * Ethernet device RX/TX queue packet burst mode information structure. > * Used to retrieve information about packet burst mode setting. > */ > struct rte_eth_burst_mode { > uint32_t per_queue_support:1; /**< Support to set per queue burst */ > > uint64_t options; > }; > > And three APIs: > > 1. > __rte_experimental > int rte_eth_rx_burst_mode_get(uint16_t port_id, uint16_t queue_id, > struct rte_eth_burst_mode *mode); > > > 2. > __rte_experimental > int rte_eth_tx_burst_mode_get(uint16_t port_id, uint16_t queue_id, > struct rte_eth_burst_mode *mode); > > 3. > __rte_experimental > const char * > rte_eth_burst_mode_option_name(uint64_t option); What about 'rte_eth_burst_mode_name()' ? > > > PMD two ops: > > typedef void (*eth_burst_mode_get_t)(struct rte_eth_dev *dev, > uint16_t queue_id, struct rte_eth_burst_mode *mode); > > struct eth_dev_ops { > ... > eth_burst_mode_get_t rx_burst_mode_get; /**< Get RX burst mode */ > eth_burst_mode_get_t tx_burst_mode_get; /**< Get TX burst mode */ > ... > }; >